1. 26 Aug, 2018 2 commits
  2. 25 Aug, 2018 2 commits
    • Ido Schimmel's avatar
      mlxsw: spectrum_switchdev: Do not leak RIFs when removing bridge · 602b74ed
      Ido Schimmel authored
      When a bridge device is removed, the VLANs are flushed from each
      configured port. This causes the ports to decrement the reference count
      on the associated FIDs (filtering identifier). If the reference count of
      a FID is 1 and it has a RIF (router interface), then this RIF is
      destroyed.
      
      However, if no port is member in the VLAN for which a RIF exists, then
      the RIF will continue to exist after the removal of the bridge. To
      reproduce:
      
      # ip link add name br0 type bridge vlan_filtering 1
      # ip link set dev swp1 master br0
      # ip link add link br0 name br0.10 type vlan id 10
      # ip address add 192.0.2.0/24 dev br0.10
      # ip link del dev br0
      
      The RIF associated with br0.10 continues to exist.
      
      Fix this by iterating over all the bridge device uppers when it is
      destroyed and take care of destroying their RIFs.
      
      Fixes: 99f44bb3 ("mlxsw: spectrum: Enable L3 interfaces on top of bridge devices")
      Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
      Reviewed-by: default avatarPetr Machata <petrm@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      602b74ed
    • David S. Miller's avatar
      Merge branch '1GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-queue · ae923785
      David S. Miller authored
      Jeff Kirsher says:
      
      ====================
      Intel Wired LAN Driver Updates 2018-08-24
      
      This series contains fixes to e1000, igb, ixgb, ixgbe and i40e.
      
      YueHaibing from Huawei provides a change to use dma_zalloc_coherent()
      instead of calls to allocator followed by a memset for ixgb.
      
      Bo Chen provides a couple of fixes for e1000, first by adding a check to
      prevent a NULL pointer dereference.  The second change is to clean up a
      possible resource leak on old transmit and receive rings when the device
      is not up.
      
      Jesus fixes an issue in the usage of an advanced transmit context
      descriptor for retrieving the timestamp of a packet for AF_PACKET if the
      IGB_TX_FLAGS_VLAN is not set in igb.
      
      Jia-Ju Bai provides several patches which replace GFP_ATOMIC with
      GFP_KERNEL, when using kzalloc() and kcalloc() which is not necessary.
      Also found an instance of mdelay() call which could be replaced with
      msleep().
      
      Tony fixes ixgbe to allow MTU changes with XDP, by adding checks to
      ensure only supported values and return -EINVAL for when it is not
      supported.
      
      Sebastian fixed an issue that was not clearing VF mailbox memory and
      ensure queues are re-enabled correctly.
      
      Martyna fixes a transmit timeout when DCB is configured when bringing up
      an interface.
      
      Jake fixes a previous commit which accidentally reversed the check of
      the data pointer, so we can accurately count the size of the stats.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ae923785
  3. 24 Aug, 2018 12 commits
  4. 23 Aug, 2018 24 commits