- 15 Feb, 2014 13 commits
-
-
Larry Finger authored
This is simply a wrapper around schedule_work(). Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
This is simply another name for INIT_WORK(). Signed-off-by:
-
Larry Finger authored
This wrapper is a simple call to mutex_exit(). Signed-off-by:
-
Larry Finger authored
Signed-off-by:
-
Larry Finger authored
This inline function checks that the pointer is not NULL and then returns the rx_data member. Unfortunately, all 3 callers of this function have dereferenced that pointer before this routine is called. As the check for NULL is useless, eliminate the routine. Reported-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Larry Finger authored
This simple routine is replaced by a simple access of the len member. Reported-by:
-
Larry Finger authored
Reported-by:
-
Larry Finger authored
These functions are not called from the outside source. Suggested-by:
-
Larry Finger authored
We have now removed everthing from the union except the struct. The union can be deleted, the struct renamed, and the referencing of members of the struct becomes a lot simpler. Some, but not all, of the problems noted by checkpatch.pl have been fixed. Sugggested-by:
-
Larry Finger authored
This alignment entry in union recv_frame does nothing. It certainly dues not ensure alignment. Suggested-by: Jes.Sorensen@redhat.com Signed-off-by:
-
Larry Finger authored
Struct recv_frame_hdr already contains a list head. This one is pointless. Suggested-by:
-
Julia Lawall authored
On success, the function netdev_alloc_skb initializes the dev field of its result to its first argument, so this doesn't have to be done in the calling context. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression skb,privn,e; @@ skb = netdev_alloc_skb(privn,...); ... when strict ( -skb->dev = privn; | ?skb = e ) // </smpl> Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
Levente Kurusa authored
Since MSR_AP is 0x3, ANDing it with 0xFC will never be true. Add a NOT operation to 0xFC so that we will AND with the last three bits which will result in a possibility that the condition will succeed. Signed-off-by:
Levente Kurusa <levex@linux.com> Signed-off-by:
-
- 14 Feb, 2014 27 commits
-
-
Mark Asselstine authored
To avoid buffer overflow while reading a corrupted or possibly modified port file we validate the length of each part of the port record to ensure it doesn't exceed the length of the destination buffer. https://bugzilla.kernel.org/show_bug.cgi?id=69931Signed-off-by:
Mark Asselstine <asselsm@gmail.com> Signed-off-by:
-
H Hartley Sweeten authored
The trigger sources were already validataed in the (*do_cmdtest) before the (*do_cmd) is called. Remove the unnecessary checks in pcl816_ai_cmd(). Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
H Hartley Sweeten authored
The trigger sources were already validataed in the (*do_cmdtest) before the (*do_cmd) is called. Remove the unnecessary checks in pcl812_ai_cmd(). Signed-off-by:
-
H Hartley Sweeten authored
The trigger sources were already validataed in the (*do_cmdtest) before the (*do_cmd) is called. Refactor the code in das800_ai_do_cmd() to use if/else instead of the switch since the default cases can never be reached. Signed-off-by:
-
H Hartley Sweeten authored
The trigger sources were already validataed in the (*do_cmdtest) before the (*do_cmd) is called. Refactor the code in waveform_ai_cmd() to remove the final else which can never be reached. Signed-off-by:
-
H Hartley Sweeten authored
The trigger sources were already validataed in the (*do_cmdtest) before the (*do_cmd) is called. Refactor the code in cb_pcidas_ai_cmd() to remove the final else which can never be reached. Signed-off-by:
-
H Hartley Sweeten authored
This driver has a (*do_cmdtest) function for analog input async command support but the (*do_cmd) function just returns -EINVAL. Remove the incomplete async command support. Signed-off-by:
-
H Hartley Sweeten authored
The trigger sources were already validataed in the (*do_cmdtest) before the (*do_cmd) is called. Refactor the code in pci9111_ai_do_cmd() to use if/else instead of the switch since the default cases can never be reached. Signed-off-by:
-
H Hartley Sweeten authored
Currently the (*do_cmdtest) indicates that TRIG_TIMER is a valid scan_begin_src but later this source is tested as -EINVAL. To simplify the code a bit just remove the TRIG_TIMER source. Signed-off-by:
-
H Hartley Sweeten authored
Remove the unnecessary check of 'cmd->chanlist_len > 0'. The (*do_cmdtest) already validated this before the (*do_cmd) was called. Signed-off-by:
-
H Hartley Sweeten authored
It's not necessary to clear the returned data pointer when an (*insn_read) times out. For aesthetics, remove all of these in the drivers. Signed-off-by:
-
H Hartley Sweeten authored
Have the comedi core display a standard dev_dbg() message when a timeout occurs and remove all the driver specific messages. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input settle and end-of- conversion. These tests use different registers but the same bit so the register is passed as the 'context'. The same test is used in dmm32at_ai_cmd() but the 'insn' is not available. This is ok since the test function, and comedi_timeout() don't use it. Use comedi_timout() to wait for the analog output end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Combine the logic for the pcl812 and acl812 end-of-conversion in the helper function to simplify the driver. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input pipe full, scanning, amd end-of-conversion status. The status to check it passed as the 'context' to comedi_timeout(). Use comedi_timeout() to wait for the analog output end-of-conversion. This also fixes a possible bug where invalid data is returned for the analog input read if the conversion did not complete, The analog output has a similar possible bug where the cached readback value is incorrect if the conversion times out. Signed-off-by:
-
H Hartley Sweeten authored
The wait_for() macro in this driver is a bit nasty. It effects control flow which according to the CodingStyle is a _very_ bad idea. The mux_busy() and ad_done() macros are also bad since they rely on a local variable having a specific name. Remove these macros and use comedi_timeout() to wait for the analog input mux busy completion and end-of-conversion. Both of these are detected by reading the same register and testing different bits. Pass the bits to test as the 'context' to the callback function. The dt282x_ai_cmd() function also checks for the mux busy completion. The 'insn' is not available here but passing NULL is safe because nothing uses it. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. This prevents a deadlock condition that could occur by providing a timeout in case the end-of-conversion does not happen. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input and output end-of- conversions. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input and output end-of- conversion. Use break to exit the loop when a timeout occurs during the analog input read so that common code can be used to disable the device. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Also, remove some unnecessary comments. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. This also fixes a possible bug where invalid data is returned if the conversion did not complete. Signed-off-by:
-
