Skip to content

L
linux
Switch branch/tag
  1. 15 Sep, 2009 1 commit
  3. 14 Sep, 2009 1 commit
  5. 12 Sep, 2009 1 commit
    • Julia Lawall's avatar
      ASoC: Clean up error handling in MPC5200 DMA setup · 33d7f778
      Julia Lawall authored 
      Error handling code following a kzalloc should free the allocated data.
Error handling code following an ioremap should iounmap the allocated data.

The semantic match that finds the first problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
      33d7f778
  7. 08 Sep, 2009 1 commit
    • Manuel Lauss's avatar
      ASoC: au1x: PSC-AC97 bugfixes · cdc65fbe
      Manuel Lauss authored 
      This patch fixes the following bugs:

- only reprogram bitdepth if it has changed since last call to hw_params.
- add locking inside ac97_read/write functions:
  When reprogramming sample depth, the ac97 unit has to be disabled,
  which should not be done in the middle of codec register accesses.

- retry timed-out codec register accesses.

- wait for status bits to set/clear when starting/stopping various
  functional blocks; very important after reenabling AC97 unit else
  sound may be distorted (e.g. high-pitch noise in 1kHz sine wave).

- clear fifos before/after starting/stopping RX/TX.

- longer timeouts waiting for PSC/AC97 ready after cold reset
  with certain codecs this can take ridiculous amounts of time.

Run-tested on various Au1200 platforms with various codecs.
Signed-off-by: default avatarManuel Lauss <manuel.lauss@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
      cdc65fbe
  9. 07 Sep, 2009 2 commits
  11. 04 Sep, 2009 1 commit
  13. 02 Sep, 2009 1 commit
  15. 01 Sep, 2009 2 commits
  17. 28 Aug, 2009 2 commits
  19. 26 Aug, 2009 4 commits
  21. 25 Aug, 2009 5 commits
  23. 24 Aug, 2009 5 commits
  25. 23 Aug, 2009 2 commits
  27. 21 Aug, 2009 7 commits
  29. 20 Aug, 2009 5 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7