1. 30 Nov, 2017 32 commits
    • Sakari Ailus's avatar
      media: ov13858: Select V4L2_FWNODE · fce8ba67
      Sakari Ailus authored
      The ov13858 driver depends on the V4L2 fwnode, thus add that to Kconfig.
      
      Fixes: 5fcf092e ("[media] ov13858: add support for OV13858 sensor")
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      fce8ba67
    • Sean Young's avatar
      media: rc: partial revert of "media: rc: per-protocol repeat period" · 67f0f15a
      Sean Young authored
      Since commit d57ea877 ("media: rc: per-protocol repeat period"), most
      IR protocols have a lower keyup timeout. This causes problems on the
      ite-cir, which has default IR timeout of 200ms.
      
      Since the IR decoders read the trailing space, with a IR timeout of 200ms,
      the last keydown will have at least a delay of 200ms. This is more than
      the protocol timeout of e.g. rc-6 (which is 164ms). As a result the last
      IR will be interpreted as a new keydown event, and we get two keypresses.
      
      Revert the protocol timeout to 250ms, except for cec which needs a timeout
      of 550ms.
      
      Fixes: d57ea877 ("media: rc: per-protocol repeat period")
      
      Cc: <stable@vger.kernel.org> # 4.14
      Reported-by: default avatarMatthias Reichl <hias@horus.com>
      Signed-off-by: default avatarSean Young <sean@mess.org>
      Tested-by: default avatarMatthias Reichl <hias@horus.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      67f0f15a
    • Laurent Caumont's avatar
      media: dvb: i2c transfers over usb cannot be done from stack · 6d33377f
      Laurent Caumont authored
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarLaurent Caumont <lcaumont2@gmail.com>
      Signed-off-by: default avatarSean Young <sean@mess.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      6d33377f
    • Mauro Carvalho Chehab's avatar
      media: dvb-frontends: complete kernel-doc markups · be9b53c8
      Mauro Carvalho Chehab authored
      For the dvb-frontends that are now part of the documentation,
      complete the kernel-doc markups, in order for them to be
      properly used at the driver's kAPI documentation.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      be9b53c8
    • Mauro Carvalho Chehab's avatar
      media: docs: add documentation for frontend attach info · e61edeb1
      Mauro Carvalho Chehab authored
      Add to the media book the attachment kAPI for the DVB
      frontend drivers that have already some kernel-doc markup.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      e61edeb1
    • Mauro Carvalho Chehab's avatar
      media: dvb_frontends: fix kernel-doc macros · b95b0c98
      Mauro Carvalho Chehab authored
      Now, the Kernel checks for kernel_doc format issues.
      Weird enough, it didn't get any of those troubles. Shssst!
      
      Well, let's fix it, as a preventive way to avoid having
      hundreds of new warnings on some next Linux version.
      
      Tested by adding all files under dvb-frontends that have
      "/**" on them.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      b95b0c98
    • Mauro Carvalho Chehab's avatar
      media: drivers: remove "/**" from non-kernel-doc comments · cba862dc
      Mauro Carvalho Chehab authored
      Several comments are wrongly tagged as kernel-doc, causing
      those warnings:
      
        drivers/media/rc/st_rc.c:98: warning: No description found for parameter 'irq'
        drivers/media/rc/st_rc.c:98: warning: No description found for parameter 'data'
        drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: No description found for parameter 'solo_dev'
        drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: No description found for parameter 'ch'
        drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: No description found for parameter 'qp'
        drivers/media/usb/pwc/pwc-dec23.c:652: warning: Cannot understand  *
         on line 652 - I thought it was a doc line
        drivers/media/usb/dvb-usb/cinergyT2-fe.c:40: warning: No description found for parameter 'op'
        drivers/media/usb/dvb-usb/friio-fe.c:301: warning: Cannot understand  * (reg, val) commad list to initialize this module.
         on line 301 - I thought it was a doc line
        drivers/media/rc/streamzap.c:201: warning: No description found for parameter 'urb'
        drivers/media/rc/streamzap.c:333: warning: No description found for parameter 'intf'
        drivers/media/rc/streamzap.c:333: warning: No description found for parameter 'id'
        drivers/media/rc/streamzap.c:464: warning: No description found for parameter 'interface'
        drivers/media/i2c/ov5647.c:432: warning: Cannot understand  * @short Subdev core operations registration
         on line 432 - I thought it was a doc line
        drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for parameter 'd'
        drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for parameter 'addr'
        drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for parameter 'wbuf'
        drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for parameter 'wlen'
        drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for parameter 'rbuf'
        drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for parameter 'rlen'
        drivers/media/platform/vim2m.c:350: warning: No description found for parameter 'priv'
        drivers/media/dvb-frontends/tua6100.c:34: warning: cannot understand function prototype: 'struct tua6100_priv '
        drivers/media/platform/sti/hva/hva-h264.c:140: warning: cannot understand function prototype: 'struct hva_h264_stereo_video_sei '
        drivers/media/platform/sti/hva/hva-h264.c:150: warning: Cannot understand  * @frame_width: width in pixels of the buffer containing the input frame
         on line 150 - I thought it was a doc line
        drivers/media/platform/sti/hva/hva-h264.c:356: warning: Cannot understand  * @ slice_size: slice size
         on line 356 - I thought it was a doc line
        drivers/media/platform/sti/hva/hva-h264.c:369: warning: Cannot understand  * @ bitstream_size: bitstream size
         on line 369 - I thought it was a doc line
        drivers/media/platform/sti/hva/hva-h264.c:395: warning: Cannot understand  * @seq_info:  sequence information buffer
         on line 395 - I thought it was a doc line
        drivers/media/dvb-frontends/sp887x.c:137: warning: No description found for parameter 'fe'
        drivers/media/dvb-frontends/sp887x.c:137: warning: No description found for parameter 'fw'
        drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for parameter 'n'
        drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for parameter 'd'
        drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for parameter 'quotient_i'
        drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for parameter 'quotient_f'
        drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c:83: warning: cannot understand function prototype: 'struct ttusb '
        drivers/media/platform/sh_veu.c:277: warning: No description found for parameter 'priv'
        drivers/media/dvb-frontends/zl10036.c:33: warning: cannot understand function prototype: 'int zl10036_debug; '
        drivers/media/dvb-frontends/zl10036.c:179: warning: No description found for parameter 'state'
        drivers/media/dvb-frontends/zl10036.c:179: warning: No description found for parameter 'frequency'
        drivers/media/platform/rcar_fdp1.c:1139: warning: No description found for parameter 'priv'
        drivers/media/platform/ti-vpe/vpe.c:933: warning: No description found for parameter 'priv'
        drivers/media/usb/gspca/ov519.c:36: warning: No description found for parameter 'fmt'
        drivers/media/usb/dvb-usb/dib0700_devices.c:3367: warning: No description found for parameter 'adap'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      cba862dc
    • Mauro Carvalho Chehab's avatar
      media: lm3560: add a missing kernel-doc parameter · ed050c21
      Mauro Carvalho Chehab authored
      Fix this warning:
      	drivers/media/i2c/lm3560.c:69: warning: No description found for parameter 'dev'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      ed050c21
    • Mauro Carvalho Chehab's avatar
      media: rcar_jpu: fix two kernel-doc markups · 538cf643
      Mauro Carvalho Chehab authored
      On kernel-doc, struct declarations should be declared as "struct foo".
      
      Fix the following warnings:
      	drivers/media/platform/rcar_jpu.c:265: warning: cannot understand function prototype: 'struct jpu_q_data '
      	drivers/media/platform/rcar_jpu.c:281: warning: cannot understand function prototype: 'struct jpu_ctx '
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      538cf643
    • Mauro Carvalho Chehab's avatar
      media: vsp1: add a missing kernel-doc parameter · 2afe216d
      Mauro Carvalho Chehab authored
      Fix this warning:
      	drivers/media/platform/vsp1/vsp1_dl.c:87: warning: No description found for parameter 'has_chain'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      2afe216d
    • Mauro Carvalho Chehab's avatar
      media: soc_camera: fix a kernel-doc markup · bd98f7a1
      Mauro Carvalho Chehab authored
      Remove this warning:
      	drivers/media/platform/soc_camera/soc_scale_crop.c:309: warning: Cannot understand  * @icd		- soc-camera device
      	 on line 309 - I thought it was a doc line
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      Acked-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
      bd98f7a1
    • Mauro Carvalho Chehab's avatar
      media: mt2063: fix some kernel-doc warnings · 69a52ad3
      Mauro Carvalho Chehab authored
      Fix those warnings:
      	drivers/media/tuners/mt2063.c:1413: warning: No description found for parameter 'f_ref'
      	drivers/media/tuners/mt2063.c:1413: warning: Excess function parameter 'f_Ref' description in 'MT2063_fLO_FractionalTerm'
      	drivers/media/tuners/mt2063.c:1476: warning: Excess function parameter 'f_Avoid' description in 'MT2063_CalcLO2Mult'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      69a52ad3
    • Mauro Carvalho Chehab's avatar
      media: radio-wl1273: fix a parameter name at kernel-doc macro · 5bef1c0b
      Mauro Carvalho Chehab authored
      Solve those warnings:
      	drivers/media/radio/radio-wl1273.c:1337: warning: No description found for parameter 'radio'
      	drivers/media/radio/radio-wl1273.c:1337: warning: Excess function parameter 'core' description in 'wl1273_fm_set_tx_power'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      5bef1c0b
    • Mauro Carvalho Chehab's avatar
      media: s3c-camif: add missing description at s3c_camif_find_format() · fa787125
      Mauro Carvalho Chehab authored
      Fix this warning:
      	drivers/media/platform/s3c-camif/camif-core.c:112: warning: No description found for parameter 'vp'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      fa787125
    • Mauro Carvalho Chehab's avatar
      media: mtk-vpu: add description for wdt fields at struct mtk_vpu · 98156359
      Mauro Carvalho Chehab authored
      Fix those warnings:
        drivers/media/platform/mtk-vpu/mtk_vpu.c:223: warning: No description found for parameter 'wdt'
        drivers/media/platform/mtk-vpu/mtk_vpu.c:223: warning: No description found for parameter 'wdt_refcnt'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      98156359
    • Mauro Carvalho Chehab's avatar
      media: vdec: fix some kernel-doc warnings · d714a755
      Mauro Carvalho Chehab authored
      Fix those warnings:
        drivers/media/platform/mtk-vcodec/vdec/vdec_h264_if.c:69: warning: No description found for parameter 'reserved'
        drivers/media/platform/mtk-vcodec/vdec/vdec_vp8_if.c:175: warning: Excess struct member 'dev' description in 'vdec_vp8_inst'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      d714a755
    • Mauro Carvalho Chehab's avatar
      media: tvp514x: fix kernel-doc parameters · c5bb8318
      Mauro Carvalho Chehab authored
      There are some struct fields that aren't documented, and some
      consts whose comments start with /**, but they aren't kernel-doc
      annotations. So, fix it:
      
        drivers/media/i2c/tvp514x.c:127: warning: No description found for parameter 'hdl'
        drivers/media/i2c/tvp514x.c:127: warning: No description found for parameter 'pad'
        drivers/media/i2c/tvp514x.c:127: warning: No description found for parameter 'format'
        drivers/media/i2c/tvp514x.c:127: warning: No description found for parameter 'int_seq'
        drivers/media/i2c/tvp514x.c:219: warning: cannot understand function prototype: 'const struct v4l2_fmtdesc tvp514x_fmt_list[] = '
        drivers/media/i2c/tvp514x.c:235: warning: cannot understand function prototype: 'const struct tvp514x_std_info tvp514x_std_list[] = '
        drivers/media/i2c/tvp514x.c:941: warning: No description found for parameter 'fmt'
        drivers/media/i2c/tvp514x.c:941: warning: Excess function parameter 'format' description in 'tvp514x_set_pad_format'
        drivers/media/i2c/tvp514x.c:1208: warning: cannot understand function prototype: 'const struct i2c_device_id tvp514x_id[] = '
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      c5bb8318
    • Mauro Carvalho Chehab's avatar
      media: netup_unidvb: fix a bad kernel-doc markup · b5a21f8a
      Mauro Carvalho Chehab authored
      There is a bad kernel-doc markup, producing the following warnings:
      
        drivers/media/pci/netup_unidvb/netup_unidvb_core.c:85: warning: bad line: 			Bits [0-7]:	DMA packet size, 188 bytes
        drivers/media/pci/netup_unidvb/netup_unidvb_core.c:86: warning: bad line: 			Bits [16-23]:	packets count in block, 128 packets
        drivers/media/pci/netup_unidvb/netup_unidvb_core.c:87: warning: bad line: 			Bits [24-31]:	blocks count, 8 blocks
        drivers/media/pci/netup_unidvb/netup_unidvb_core.c:89: warning: bad line: 			For example, value of 375000000 equals to 3 sec
      
      Fix that, and use a list for the bits option, in order for it
      to be better format, if we add it to a driver's documentation
      file.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      b5a21f8a
    • Mauro Carvalho Chehab's avatar
      media: s5k6aa: describe some function parameters · 070250a1
      Mauro Carvalho Chehab authored
      as warned:
        drivers/media/i2c/s5k6aa.c:429: warning: No description found for parameter 's5k6aa'
        drivers/media/i2c/s5k6aa.c:679: warning: No description found for parameter 's5k6aa'
        drivers/media/i2c/s5k6aa.c:733: warning: No description found for parameter 's5k6aa'
        drivers/media/i2c/s5k6aa.c:733: warning: No description found for parameter 'preset'
        drivers/media/i2c/s5k6aa.c:787: warning: No description found for parameter 'sd'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      070250a1
    • Mauro Carvalho Chehab's avatar
      media: s5k6a3: document some fields at struct s5k6a3 · 7cd18369
      Mauro Carvalho Chehab authored
      drivers/media/i2c/s5k6a3.c:68: warning: No description found for parameter 'clock'
      drivers/media/i2c/s5k6a3.c:68: warning: No description found for parameter 'clock_frequency'
      drivers/media/i2c/s5k6a3.c:68: warning: No description found for parameter 'power_count'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      7cd18369
    • Mauro Carvalho Chehab's avatar
      media: radio-si476x: fix kernel-doc markups · d156f293
      Mauro Carvalho Chehab authored
      get rid of the following warnings:
        drivers/media/radio/radio-si476x.c:317: warning: No description found for parameter 'v4l2dev'
        drivers/media/radio/radio-si476x.c:317: warning: No description found for parameter 'ctrl_handler'
        drivers/media/radio/radio-si476x.c:317: warning: No description found for parameter 'debugfs'
        drivers/media/radio/radio-si476x.c:317: warning: No description found for parameter 'audmode'
        drivers/media/radio/radio-si476x.c:317: warning: Excess struct member 'kref' description in 'si476x_radio'
        drivers/media/radio/radio-si476x.c:317: warning: Excess struct member 'core_lock' description in 'si476x_radio'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      d156f293
    • Mauro Carvalho Chehab's avatar
      media: ix2505v: get rid of /** comments · 4521af78
      Mauro Carvalho Chehab authored
      As warned:
      
        drivers/media/dvb-frontends/ix2505v.c:24: warning: cannot understand function prototype: 'int ix2505v_debug; '
        drivers/media/dvb-frontends/ix2505v.c:59: warning: No description found for parameter 'state'
        drivers/media/dvb-frontends/ix2505v.c:128: warning: No description found for parameter 'fe'
      
      None of the comments there are kernel-doc. So, remove them with:
      
      	perl -pi -e 's,\/\*\*,/*,g' drivers/media/dvb-frontends/ix2505v.c
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      4521af78
    • Mauro Carvalho Chehab's avatar
      media: tw68: fix kernel-doc markups · ef69f8d2
      Mauro Carvalho Chehab authored
      There are a few mistakes on the existing markups:
      
        drivers/media/pci/tw68/tw68-risc.c:32: warning: Cannot understand  *  @rp		pointer to current risc program position
         on line 32 - I thought it was a doc line
        drivers/media/pci/tw68/tw68-risc.c:144: warning: No description found for parameter 'pci'
        drivers/media/pci/tw68/tw68-risc.c:144: warning: No description found for parameter 'buf'
        drivers/media/pci/tw68/tw68-risc.c:144: warning: No description found for parameter 'sglist'
        drivers/media/pci/tw68/tw68-risc.c:144: warning: No description found for parameter 'top_offset'
        drivers/media/pci/tw68/tw68-risc.c:144: warning: No description found for parameter 'bottom_offset'
        drivers/media/pci/tw68/tw68-risc.c:144: warning: No description found for parameter 'bpl'
        drivers/media/pci/tw68/tw68-risc.c:144: warning: No description found for parameter 'padding'
        drivers/media/pci/tw68/tw68-risc.c:144: warning: No description found for parameter 'lines'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      ef69f8d2
    • Mauro Carvalho Chehab's avatar
      media: pxa_camera: get rid of kernel_doc warnings · 8fd87479
      Mauro Carvalho Chehab authored
      Get rid of the following warnings:
          drivers/media/platform/pxa_camera.c:247: warning: No description found for parameter 'layout'
          drivers/media/platform/pxa_camera.c:867: warning: No description found for parameter 'buf'
          drivers/media/platform/pxa_camera.c:867: warning: No description found for parameter 'sg'
          drivers/media/platform/pxa_camera.c:867: warning: No description found for parameter 'sglen'
          drivers/media/platform/pxa_camera.c:867: warning: Excess function parameter 'vb' description in 'pxa_init_dma_channel'
          drivers/media/platform/pxa_camera.c:867: warning: Excess function parameter 'dma' description in 'pxa_init_dma_channel'
          drivers/media/platform/pxa_camera.c:867: warning: Excess function parameter 'cibr' description in 'pxa_init_dma_channel'
          drivers/media/platform/pxa_camera.c:1029: warning: No description found for parameter 'last_submitted'
          drivers/media/platform/pxa_camera.c:1029: warning: No description found for parameter 'last_issued'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      8fd87479
    • Mauro Carvalho Chehab's avatar
      media: sta2x11: document missing function parameters · 9ec2b402
      Mauro Carvalho Chehab authored
      As warned:
      
          drivers/media/pci/sta2x11/sta2x11_vip.c:414: warning: No description found for parameter 'priv'
          drivers/media/pci/sta2x11/sta2x11_vip.c:442: warning: No description found for parameter 'priv'
          drivers/media/pci/sta2x11/sta2x11_vip.c:476: warning: No description found for parameter 'priv'
          drivers/media/pci/sta2x11/sta2x11_vip.c:493: warning: No description found for parameter 'priv'
          drivers/media/pci/sta2x11/sta2x11_vip.c:524: warning: No description found for parameter 'priv'
          drivers/media/pci/sta2x11/sta2x11_vip.c:548: warning: No description found for parameter 'priv'
          drivers/media/pci/sta2x11/sta2x11_vip.c:566: warning: No description found for parameter 'file'
          drivers/media/pci/sta2x11/sta2x11_vip.c:566: warning: No description found for parameter 'priv'
          drivers/media/pci/sta2x11/sta2x11_vip.c:594: warning: No description found for parameter 'priv'
          drivers/media/pci/sta2x11/sta2x11_vip.c:651: warning: No description found for parameter 'priv'
          drivers/media/pci/sta2x11/sta2x11_vip.c:717: warning: No description found for parameter 'priv'
      
      Most of the above are for the unused priv argument.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      9ec2b402
    • Mauro Carvalho Chehab's avatar
      media: m5mols: fix some kernel-doc markups · 897aa67a
      Mauro Carvalho Chehab authored
      Fix those warnings:
      	drivers/media/i2c/m5mols/m5mols_capture.c:42: warning: No description found for parameter 'sd'
      	drivers/media/i2c/m5mols/m5mols_capture.c:42: warning: No description found for parameter 'addr_num'
      	drivers/media/i2c/m5mols/m5mols_capture.c:42: warning: No description found for parameter 'addr_den'
      	drivers/media/i2c/m5mols/m5mols_capture.c:42: warning: No description found for parameter 'val'
      	drivers/media/i2c/m5mols/m5mols_capture.c:60: warning: No description found for parameter 'info'
      	drivers/media/i2c/m5mols/m5mols_controls.c:134: warning: No description found for parameter 'info'
      	drivers/media/i2c/m5mols/m5mols_core.c:124: warning: No description found for parameter 'data'
      	drivers/media/i2c/m5mols/m5mols_core.c:124: warning: No description found for parameter 'length'
      	drivers/media/i2c/m5mols/m5mols_core.c:124: warning: Excess function parameter 'size' description in 'm5mols_swap_byte'
      	drivers/media/i2c/m5mols/m5mols_core.c:142: warning: No description found for parameter 'sd'
      	drivers/media/i2c/m5mols/m5mols_core.c:241: warning: No description found for parameter 'sd'
      	drivers/media/i2c/m5mols/m5mols_core.c:299: warning: No description found for parameter 'sd'
      	drivers/media/i2c/m5mols/m5mols_core.c:324: warning: No description found for parameter 'sd'
      	drivers/media/i2c/m5mols/m5mols_core.c:324: warning: No description found for parameter 'reg'
      	drivers/media/i2c/m5mols/m5mols_core.c:357: warning: No description found for parameter 'sd'
      	drivers/media/i2c/m5mols/m5mols_core.c:357: warning: No description found for parameter 'mode'
      	drivers/media/i2c/m5mols/m5mols_core.c:374: warning: No description found for parameter 'info'
      	drivers/media/i2c/m5mols/m5mols_core.c:429: warning: No description found for parameter 'sd'
      	drivers/media/i2c/m5mols/m5mols_core.c:503: warning: No description found for parameter 'sd'
      	drivers/media/i2c/m5mols/m5mols_core.c:671: warning: No description found for parameter 'info'
      	drivers/media/i2c/m5mols/m5mols_core.c:694: warning: No description found for parameter 'info'
      	drivers/media/i2c/m5mols/m5mols_core.c:798: warning: No description found for parameter 'sd'
      	drivers/media/i2c/m5mols/m5mols_core.c:853: warning: No description found for parameter 'sd'
      	drivers/media/i2c/m5mols/m5mols_core.c:853: warning: No description found for parameter 'on'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      897aa67a
    • Mauro Carvalho Chehab's avatar
      media: exynos4-is: fix kernel-doc warnings · 3b060ba0
      Mauro Carvalho Chehab authored
      Fix those kernel-doc warnings:
      
          drivers/media/platform/exynos4-is/mipi-csis.c:229: warning: No description found for parameter 'clk_frequency'
          drivers/media/platform/exynos4-is/mipi-csis.c:229: warning: Excess struct member 'clock_frequency' description in 'csis_state'
          drivers/media/platform/exynos4-is/media-dev.c:69: warning: No description found for parameter 'p'
          drivers/media/platform/exynos4-is/media-dev.c:160: warning: No description found for parameter 'p'
          drivers/media/platform/exynos4-is/media-dev.c:160: warning: No description found for parameter 'on'
          drivers/media/platform/exynos4-is/media-dev.c:160: warning: Excess function parameter 'fimc' description in 'fimc_pipeline_s_power'
          drivers/media/platform/exynos4-is/media-dev.c:160: warning: Excess function parameter 'state' description in 'fimc_pipeline_s_power'
          drivers/media/platform/exynos4-is/media-dev.c:229: warning: No description found for parameter 'ep'
          drivers/media/platform/exynos4-is/media-dev.c:260: warning: No description found for parameter 'ep'
          drivers/media/platform/exynos4-is/media-dev.c:260: warning: Excess function parameter 'fimc' description in '__fimc_pipeline_close'
          drivers/media/platform/exynos4-is/media-dev.c:288: warning: No description found for parameter 'ep'
          drivers/media/platform/exynos4-is/media-dev.c:288: warning: Excess function parameter 'pipeline' description in '__fimc_pipeline_s_stream'
          drivers/media/platform/exynos4-is/media-dev.c:916: warning: No description found for parameter 'fmd'
          drivers/media/platform/exynos4-is/fimc-capture.c:155: warning: No description found for parameter 'ctx'
          drivers/media/platform/exynos4-is/fimc-capture.c:868: warning: No description found for parameter 'num_planes'
          drivers/media/platform/exynos4-is/fimc-capture.c:1108: warning: No description found for parameter 'fimc'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      3b060ba0
    • Mauro Carvalho Chehab's avatar
      media: venc: don't use kernel-doc for undescribed enums · 440568f8
      Mauro Carvalho Chehab authored
      There are no descriptions for some enums, with produces lots
      of warnings:
      
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_LUMA' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_LUMA2' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_LUMA3' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_CHROMA' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_CHROMA2' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_CHROMA3' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_MV_INFO' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_BS_HEADER' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_PROB_BUF' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_RC_INFO' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_RC_CODE' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_RC_CODE2' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_RC_CODE3' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_MAX' not described in enum 'venc_vp8_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:51: warning: Enum value 'VENC_H264_VPU_WORK_BUF_RC_INFO' not described in enum 'venc_h264_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:51: warning: Enum value 'VENC_H264_VPU_WORK_BUF_RC_CODE' not described in enum 'venc_h264_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:51: warning: Enum value 'VENC_H264_VPU_WORK_BUF_REC_LUMA' not described in enum 'venc_h264_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:51: warning: Enum value 'VENC_H264_VPU_WORK_BUF_REC_CHROMA' not described in enum 'venc_h264_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:51: warning: Enum value 'VENC_H264_VPU_WORK_BUF_REF_LUMA' not described in enum 'venc_h264_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:51: warning: Enum value 'VENC_H264_VPU_WORK_BUF_REF_CHROMA' not described in enum 'venc_h264_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:51: warning: Enum value 'VENC_H264_VPU_WORK_BUF_MV_INFO_1' not described in enum 'venc_h264_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:51: warning: Enum value 'VENC_H264_VPU_WORK_BUF_MV_INFO_2' not described in enum 'venc_h264_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:51: warning: Enum value 'VENC_H264_VPU_WORK_BUF_SKIP_FRAME' not described in enum 'venc_h264_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:51: warning: Enum value 'VENC_H264_VPU_WORK_BUF_MAX' not described in enum 'venc_h264_vpu_work_buf'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:60: warning: Enum value 'H264_BS_MODE_SPS' not described in enum 'venc_h264_bs_mode'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:60: warning: Enum value 'H264_BS_MODE_PPS' not described in enum 'venc_h264_bs_mode'
          drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c:60: warning: Enum value 'H264_BS_MODE_FRAME' not described in enum 'venc_h264_bs_mode'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      440568f8
    • Mauro Carvalho Chehab's avatar
      media: davinci: fix kernel-doc warnings · 389a455d
      Mauro Carvalho Chehab authored
      There are several of kernel-doc warnings:
      
          drivers/media/platform/davinci/vpif_display.c:114: warning: No description found for parameter 'sizes'
          drivers/media/platform/davinci/vpif_display.c:165: warning: No description found for parameter 'vq'
          drivers/media/platform/davinci/vpif_display.c:165: warning: Excess function parameter 'vb' description in 'vpif_start_streaming'
          drivers/media/platform/davinci/vpif_display.c:780: warning: No description found for parameter 'vpif_cfg'
          drivers/media/platform/davinci/vpif_display.c:780: warning: No description found for parameter 'chan_cfg'
          drivers/media/platform/davinci/vpif_display.c:780: warning: No description found for parameter 'index'
          drivers/media/platform/davinci/vpif_display.c:813: warning: No description found for parameter 'vpif_cfg'
          drivers/media/platform/davinci/vpif_display.c:813: warning: No description found for parameter 'ch'
          drivers/media/platform/davinci/vpif_display.c:813: warning: No description found for parameter 'index'
          drivers/media/platform/davinci/vpif_capture.c:121: warning: No description found for parameter 'sizes'
          drivers/media/platform/davinci/vpif_capture.c:174: warning: No description found for parameter 'vq'
          drivers/media/platform/davinci/vpif_capture.c:174: warning: Excess function parameter 'vb' description in 'vpif_start_streaming'
          drivers/media/platform/davinci/vpif_capture.c:636: warning: No description found for parameter 'iface'
          drivers/media/platform/davinci/vpif_capture.c:647: warning: No description found for parameter 'ch'
          drivers/media/platform/davinci/vpif_capture.c:647: warning: No description found for parameter 'muxmode'
          drivers/media/platform/davinci/vpif_capture.c:676: warning: No description found for parameter 'vpif_cfg'
          drivers/media/platform/davinci/vpif_capture.c:676: warning: No description found for parameter 'chan_cfg'
          drivers/media/platform/davinci/vpif_capture.c:676: warning: No description found for parameter 'input_index'
          drivers/media/platform/davinci/vpif_capture.c:712: warning: No description found for parameter 'vpif_cfg'
          drivers/media/platform/davinci/vpif_capture.c:712: warning: No description found for parameter 'ch'
          drivers/media/platform/davinci/vpif_capture.c:712: warning: No description found for parameter 'index'
          drivers/media/platform/davinci/vpif_capture.c:798: warning: No description found for parameter 'std'
          drivers/media/platform/davinci/vpif_capture.c:798: warning: Excess function parameter 'std_id' description in 'vpif_g_std'
          drivers/media/platform/davinci/vpif_capture.c:940: warning: No description found for parameter 'fmt'
          drivers/media/platform/davinci/vpif_capture.c:940: warning: Excess function parameter 'index' description in 'vpif_enum_fmt_vid_cap'
          drivers/media/platform/davinci/vpif_capture.c:1750: warning: No description found for parameter 'dev'
      
      Fix them.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      389a455d
    • Mauro Carvalho Chehab's avatar
      media: v4l2-core: Fix kernel-doc markups · d28b2cf9
      Mauro Carvalho Chehab authored
      There are some troubles on kernel-doc markups, as warned:
      
      	drivers/media/v4l2-core/v4l2-dv-timings.c:259: warning: No description found for parameter 't1'
      	drivers/media/v4l2-core/v4l2-dv-timings.c:259: warning: No description found for parameter 't2'
      	drivers/media/v4l2-core/v4l2-dv-timings.c:259: warning: No description found for parameter 'pclock_delta'
      	drivers/media/v4l2-core/v4l2-dv-timings.c:259: warning: No description found for parameter 'match_reduced_fps'
      	drivers/media/v4l2-core/tuner-core.c:242: warning: bad line: internal parameters, like LNA mode
      	drivers/media/v4l2-core/tuner-core.c:765: warning: No description found for parameter 'mode'
      	drivers/media/v4l2-core/videobuf2-memops.c:127: warning: cannot understand function prototype: 'const struct vm_operations_struct vb2_common_vm_ops = '
      	drivers/media/v4l2-core/v4l2-mem2mem.c:190: warning: No description found for parameter 'm2m_dev'
      	drivers/media/v4l2-core/v4l2-mem2mem.c:291: warning: No description found for parameter 'm2m_ctx'
      	drivers/media/v4l2-core/videobuf-core.c:233: warning: No description found for parameter 'q'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      d28b2cf9
    • Mauro Carvalho Chehab's avatar
      media: rc: fix kernel-doc parameter names · 1855e988
      Mauro Carvalho Chehab authored
      There are several parameters there that are named wrong, as
      reported by those warnings:
      
      	drivers/media/rc/ir-sharp-decoder.c:47: warning: No description found for parameter 'ev'
      	drivers/media/rc/ir-sharp-decoder.c:47: warning: Excess function parameter 'duration' description in 'ir_sharp_decode'
      	drivers/media/rc/ir-sanyo-decoder.c:56: warning: No description found for parameter 'ev'
      	drivers/media/rc/ir-sanyo-decoder.c:56: warning: Excess function parameter 'duration' description in 'ir_sanyo_decode'
      	drivers/media/rc/ir-xmp-decoder.c:43: warning: No description found for parameter 'ev'
      	drivers/media/rc/ir-xmp-decoder.c:43: warning: Excess function parameter 'duration' description in 'ir_xmp_decode'
      	drivers/media/rc/ir-jvc-decoder.c:47: warning: No description found for parameter 'ev'
      	drivers/media/rc/ir-jvc-decoder.c:47: warning: Excess function parameter 'duration' description in 'ir_jvc_decode'
      	drivers/media/rc/ir-lirc-codec.c:34: warning: No description found for parameter 'dev'
      	drivers/media/rc/ir-lirc-codec.c:34: warning: No description found for parameter 'ev'
      	drivers/media/rc/ir-lirc-codec.c:34: warning: Excess function parameter 'input_dev' description in 'ir_lirc_decode'
      	drivers/media/rc/ir-lirc-codec.c:34: warning: Excess function parameter 'duration' description in 'ir_lirc_decode'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      1855e988
    • Mauro Carvalho Chehab's avatar
      media: atomisp: stop producing hundreds of kernel-doc warnings · d929fb4e
      Mauro Carvalho Chehab authored
      A recent change on Kernel 4.15-rc1 causes all tags with
      /** to be handled as kernel-doc markups. Well, several
      atomisp modules, it doesn't use kernel-doc, but some other
      documentation markup (doxygen?).
      
      So, suppress all those warns by:
      	- replacing /**< by /**.
      	- replacing /** by /*.
      
      The core changes were done with:
      
      	for i in $(find drivers/staging/media/atomisp -type f); do sed 's,/\*\* ,/\*, ' -i $i; done
      	for i in $(find drivers/staging/media/atomisp -type f); do sed 's,/\*\*<,/\**,' -i $i; done
      	for i in drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/debug/src/ia_css_debug.c drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/rmgr/src/rmgr_vbuf.c; do perl -ne 's,\/\*\*$,/*,g; print $_'  $i > a && mv a $i; done;
      
      A few manual adjustments were made, where needed.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      d929fb4e
  2. 27 Nov, 2017 8 commits