1. 16 Jan, 2020 3 commits
  2. 10 Jan, 2020 2 commits
    • YueHaibing's avatar
      scsi: lpfc: Make lpfc_defer_acc_rsp static · fdb827e4
      YueHaibing authored
      Fix sparse warning:
      
      drivers/scsi/lpfc/lpfc_nportdisc.c:344:1: warning:
       symbol 'lpfc_defer_acc_rsp' was not declared. Should it be static?
      
      Link: https://lore.kernel.org/r/20200107014956.41748-1-yuehaibing@huawei.comReported-by: default avatarHulk Robot <hulkci@huawei.com>
      Reviewed-by: default avatarJames Smart <james.smart@broadcom.com>
      Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      fdb827e4
    • Martin K. Petersen's avatar
      Merge tag 'block-ioctl-cleanup-5.6' into 5.6/scsi-queue · 1c46a2cf
      Martin K. Petersen authored
      Pull compat_ioctl cleanup from Arnd. Here's his description:
      
      This series concludes the work I did for linux-5.5 on the compat_ioctl()
      cleanup, killing off fs/compat_ioctl.c and block/compat_ioctl.c by moving
      everything into drivers.
      
      Overall this would be a reduction both in complexity and line count, but
      as I'm also adding documentation the overall number of lines increases
      in the end.
      
      My plan was originally to keep the SCSI and block parts separate.
      This did not work easily because of interdependencies: I cannot
      do the final SCSI cleanup in a good way without first addressing the
      CDROM ioctls, so this is one series that I hope could be merged through
      either the block or the scsi git trees, or possibly both if you can
      pull in the same branch.
      
      The series comes in these steps:
      
      1. clean up the sg v3 interface as suggested by Linus. I have
         talked about this with Doug Gilbert as well, and he would
         rebase his sg v4 patches on top of "compat: scsi: sg: fix v3
         compat read/write interface"
      
      2. Actually moving handlers out of block/compat_ioctl.c and
         block/scsi_ioctl.c into drivers, mixed in with cleanup
         patches
      
      3. Document how to do this right. I keep getting asked about this,
         and it helps to point to some documentation file.
      
      The branch is based on another one that fixes a couple of bugs found
      during the creation of this series.
      
      Changes since v3:
        https://lore.kernel.org/lkml/20200102145552.1853992-1-arnd@arndb.de/
      
      - Move sr_compat_ioctl fixup to correct patch (Ben Hutchings)
      - Add Reviewed-by tags
      
      Changes since v2:
        https://lore.kernel.org/lkml/20191217221708.3730997-1-arnd@arndb.de/
      
      - Rebase to v5.5-rc4, which contains the earlier bugfixes
      - Fix sr_block_compat_ioctl() error handling bug found by
        Ben Hutchings
      - Fix idecd_locked_compat_ioctl() compat_ptr() bug
      - Don't try to handle HDIO_DRIVE_TASKFILE in drivers/ide
      - More documentation improvements
      
      Changes since v1:
        https://lore.kernel.org/lkml/20191211204306.1207817-1-arnd@arndb.de/
      
      - move out the bugfixes into a branch for itself
      - clean up scsi sg driver further as suggested by Christoph Hellwig
      - avoid some ifdefs by moving compat_ptr() out of asm/compat.h
      - split out the blkdev_compat_ptr_ioctl function; bug spotted by
        Ben Hutchings
      - Improve formatting of documentation
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      1c46a2cf
  3. 03 Jan, 2020 35 commits