- 05 Jul, 2016 1 commit
-
-
Kamal Mostafa authored
Ignore: yes Signed-off-by:Kamal Mostafa <kamal@canonical.com>
-
- 30 Jun, 2016 35 commits
-
-
Kamal Mostafa authored
Signed-off-by: -
Hannes Reinecke authored
Not every device will return a useable VPD identification, but still might support ALUA. Rather than disable ALUA support we should be allowing the device identification to be empty and attach individual ALUA device handler to each devices. [mkp: Fixed typo reported by Bart] Reported-by:
Paul Mackerras <paulus@ozlabs.org> Signed-off-by:
Hannes Reinecke <hare@suse.com> Tested-by:
Bart Van Assche <bart.vanassche@sandisk.com> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com> BugLink: http://bugs.launchpad.net/bugs/1567602 (cherry-picked from commit fe8b9534) Signed-off-by:
Stefan Bader <stefan.bader@canonical.com> Acked-by:
Brad Figg <brad.figg@canonical.com> Signed-off-by:
-
Hannes Reinecke authored
Sending a 'REPORT TARGET PORT GROUP' command is a costly operation, as the array has to gather information about all ports. So instead of using RTPG to poll for a status update when a port is in transitioning we should be sending a TEST UNIT READY, and wait for the sense code to report success. Reviewed-by:
Ewan Milne <emilne@redhat.com> Reviewed-by:
Christoph Hellwig <hch@lst.de> Signed-off-by:
Hannes Reinecke <hare@suse.de> Signed-off-by:
-
Hannes Reinecke authored
When we read in the target port group state we should be updating all affected port groups, otherwise we risk running out of sync. Reviewed-by:
-
Hannes Reinecke authored
When we receive a unit attention code of 'ALUA state changed' we should recheck the state, as it might be due to an implicit ALUA state transition. This allows us to return NEEDS_RETRY instead of ADD_TO_MLQUEUE, allowing to terminate the retries after a certain time. At the same time a workqueue item might already be queued, which should be started immediately to avoid any delays. Reviewed-by:
-
Hannes Reinecke authored
Add a new blacklist flag BLIST_SYNC_ALUA to instruct the alua device handler to use synchronous command submission for ALUA commands. Reviewed-by:
-
Hannes Reinecke authored
Some arrays may only capable of handling one STPG at a time, so this patch adds a singlethreaded workqueue for STPGs to be submitted synchronously. Reviewed-by:
-
Hannes Reinecke authored
The current ALUA device_handler has two drawbacks: - We're sending a 'SET TARGET PORT GROUP' command to every LUN, disregarding the fact that several LUNs might be in a port group and will be automatically switched whenever _any_ LUN within that port group receives the command. - Whenever a LUN is in 'transitioning' mode we cannot block I/O to that LUN, instead the controller has to abort the command. This leads to increased traffic across the wire and heavy load on the controller during switchover. With this patch the RTPG handling is moved to a per-portgroup workqueue. This reduces the number of 'REPORT TARGET PORT GROUP' and 'SET TARGET PORT GROUPS' sent to the controller as we're sending them now per port group, and not per device as previously. It also allows us to block I/O to any LUN / port group found to be in 'transitioning' ALUA mode, as the workqueue item will be requeued until the controller moves out of transitioning. Reviewed-by:
-
Hannes Reinecke authored
The 'relative port' field is not used, and might get stale when the port group changes. So remove the field altogether. Reviewed-by:
-
Hannes Reinecke authored
When the optimize_stpg module option is set we should just set it once during port_group allocation. Doing so allows us to override it later with device specific settings. Reviewed-by:
-
Hannes Reinecke authored
revert commit a8e5a2d5 ("[SCSI] scsi_dh_alua: ALUA handler attach should succeed while TPG is transitioning") This reverts commit a8e5a2d5 Obsoleted by the next patch. Reviewed-by:
-
Hannes Reinecke authored
Rework alua_check_vpd() to use scsi_vpd_get_tpg() and move the port group selection into the function, too. With that we can simplify alua_initialize() to just call alua_check_tpgs() and alua_check_vpd(); Reviewed-by:
-
Hannes Reinecke authored
Use scsi_vpd_lun_id() to assign a unique device identification to the alua port group structure. Reviewed-by:
-
Hannes Reinecke authored
The port group needs to be a separate structure as several LUNs might belong to the same group. Reviewed-by:
-
Hannes Reinecke authored
The RTPG buffer will only evaluated within alua_rtpg(), so we can allocate it locally there and avoid having to put it into the global structure. Reviewed-by:
-
Hannes Reinecke authored
All commands are issued synchronously, so no need to open-code scsi_execute_req_flags() anymore. And we can get rid of the static sense code structure element. scsi_execute_req_flags() will be setting REQ_QUIET and REQ_PREEMPT, but that is perfectly fine as we're evaluating and logging any errors ourselves and we really need to send the command even if the device is quiesced. Reviewed-by:
-
Hannes Reinecke authored
If the call to SET TARGET PORT GROUPS fails we have no idea what state the array is left in, so we need to issue a call to REPORT TARGET PORT GROUPS in these cases. Reviewed-by:
-
Hannes Reinecke authored
The 'activate_complete' function needs to be executed after stpg has finished, so we can as well execute stpg synchronously and call the function directly. Reviewed-by:
-
Hannes Reinecke authored
Separate out SET TARGET PORT GROUP functionality into a separate function alua_stpg(). Reviewed-by:
-
Hannes Reinecke authored
Pass in the buffer as a function argument for submit_rtpg(). Reviewed-by:
-
Hannes Reinecke authored
With commit 83ea0e5e ("scsi_dh_alua: use scsi_vpd_tpg_id()") these variables became obsolete, but weren't removed. [mkp: Fixed checkpatch warning] Signed-off-by:
Johannes Thumshirn <jthumshirn@suse.de> Reviewed-by:
-
Hannes Reinecke authored
Use the common function 'scsi_vpd_tpg_id()' instead of open-coding it in scsi_dh_alua. [mkp: Applied by hand] Signed-off-by:
Johannes Thumshirn <jthumshirn@suse.com> Reviewed-by:
-
Hannes Reinecke authored
Implement scsi_vpd_tpg_id() to extract the target port group id and the relative port id from SCSI VPD page 0x83. Reviewed-by:
-
Hannes Reinecke authored
Add a function scsi_vpd_lun_id() to return a unique device identifcation based on the designation descriptors of VPD page 0x83. As devices might implement several descriptors the order of preference is: - NAA IEE Registered Extended - EUI-64 based 16-byte - EUI-64 based 12-byte - NAA IEEE Registered - NAA IEEE Extended A SCSI name string descriptor is preferred to all of them if the identification is longer than 16 bytes. The returned unique device identification will be formatted as a SCSI Name string to avoid clashes between different designator types. [mkp: Fixed up kernel doc comment from Johannes] Signed-off-by:
-
Hannes Reinecke authored
Most sense code is already handled in the generic code, so we shouldn't be adding special cases here. However, when doing so we need to check for unit attention whenever we're sending an internal command. Signed-off-by:
-
Hannes Reinecke authored
Instead of returning an error code in alua_check_tpgs() we should rather return the tpgs mode directly and have a cleaner syntax. Signed-off-by:
-
Hannes Reinecke authored
Use 'get_unaligned_XX' and 'put_unaligned_XX' instead of open-coding it. Signed-off-by:
-
Hannes Reinecke authored
We should be using a flag when RTPG extended header is not supported, that saves us sending RTPG twice for older arrays. Signed-off-by:
-
Hannes Reinecke authored
Fixup copy-and-paste error in the description of stpg_endio(). Signed-off-by:
-
Hannes Reinecke authored
Fixup submit_rtpg() to always return a standard SCSI return code. Signed-off-by:
-
Hannes Reinecke authored
Use standard logging functions instead of hand-crafted ones. Signed-off-by:
Bart Van Assche <bvanassche@sandisk.com> Reviewed-by:
-
Hannes Reinecke authored
The only check for a valid sense code is calling scsi_normalize_sense() and check the return value. So drop the pointless checks and rely on scsi_normalize_sense() to figure out if the sense code is valid. With that we can also remove the 'senselen' field. Signed-off-by:
-
Hannes Reinecke authored
Issue different logging messages if ALUA is not supported or the TPGS setting is invalid. Signed-off-by:
-
Hannes Reinecke authored
The SCSI device now has the VPD page 0x83 information attached, so there is no need to query it again. [mkp: Fixed a checkpatch warning] Signed-off-by:
-
Hannes Reinecke authored
Non-disk devices might support ALUA, but the firmware implementation is untested and frequently broken. As we're don't actually need it disable ALUA support for non-disk device for now. Signed-off-by:
-
- 29 Jun, 2016 1 commit
-
-
Kamal Mostafa authored
Ignore: yes Signed-off-by:
-
- 28 Jun, 2016 3 commits
-
-
Kamal Mostafa authored
Signed-off-by: -
Colin Ian King authored
BugLink: http://bugs.launchpad.net/bugs/1594871 Sync with the latest Xenial zfs-linux 0.6.5.6-0ubuntu10 Signed-off-by:
Colin Ian King <colin.king@canonical.com> Acked-by:
Tim Gardner <tim.gardner@canonical.com> Signed-off-by:
-
Kamal Mostafa authored
BugLink: http://bugs.launchpad.net/bugs/1589886Signed-off-by:
-
