- 15 Jan, 2015 2 commits
-
-
Takashi Iwai authored
The commit commit [33f4acd3: ALSA: hda - Enable mic mute hotkey and LEDs for an HP machine] introduced a quirk for a HP machine involving with the input event handling. Although the relevant code is protected via IS_ENABLED(CONFIG_INPUT), this doesn't suffice when the audio driver is built in while the input is module. As an easy workaround, this patch forcibly selects CONFIG_INPUT in Kconfig. This shouldn't be a practical problem since CONFIG_INPUT is almost mandatory for all systems. Also, this allows to remove the ugly ifdefs in the code. Fixes: 33f4acd3 ('ALSA: hda - Enable mic mute hotkey and LEDs for an HP machine') Acked-by:
David Henningsson <david.henningsson@canonical.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
Davidlohr Bueso authored
Call __set_current_state() instead of assigning the new state directly. These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments, keeping track of who changed the state. Signed-off-by:
Davidlohr Bueso <dbueso@suse.de> Signed-off-by:
-
- 13 Jan, 2015 2 commits
-
-
Qais Yousef authored
Fixes the following compilation error: include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’: include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration] if (snd_BUG_ON(!stream)) snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly, so include it. Signed-off-by:Qais Yousef <qais.yousef@imgtec.com> Acked-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
-
Takashi Iwai authored
Merge tag 'topic/i915-hda-componentized-2015-01-12' of git://anongit.freedesktop.org/drm-intel into for-next
-
- 12 Jan, 2015 36 commits
-
-
Takashi Iwai authored
-
Takashi Iwai authored
Promote line6 driver from staging to sound/usb/line6 directory, and maintain through sound subsystem tree. This commit just moves the code and adapts Makefile / Kconfig. The further renames and misc cleanups will follow. Signed-off-by: -
Chris Rorvick authored
Remove declarations from the header and move the definitions up in the source so they need not be forward declared. Signed-off-by:
Chris Rorvick <chris@rorvick.com> Reviewed-by:
Stefan Hajnoczi <stefanha@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
-
Chris Rorvick authored
Which *_disconnect() to call on disconnect is known at initialization. Add a function pointer to the `usb_line6' struct and use to call into the appropriate logic instead of evaluating the conditional logic. Signed-off-by:
-
Chris Rorvick authored
Which *_process_message() function (if any) to call when data is received is known at initialization. Add a function pointer to the `usb_line6' struct and use to call into the appropriate logic instead of evaluating the conditional logic for each message. Signed-off-by:
-
Chris Rorvick authored
Casting the `struct usb_line6' pointer at the call point makes the code difficult to read. This is substantially cleaned up by moving the cast into the callees. Signed-off-by:
-
Chris Rorvick authored
Casting the `struct usb_line6' pointer at the call point makes the code difficult to read. This is substantially cleaned up by moving the cast into the callees. Signed-off-by:
-
Chris Rorvick authored
The device type can now be used to determine the addresses of the audio endpoints for the interface. Drop the conditional logic and make these values properties. Signed-off-by:
-
Chris Rorvick authored
Commit 1027f476 (staging: line6: sync with upstream) removed PCM from the Pocket POD capabilities but left the endpoint configuration. Signed-off-by:
-
Chris Rorvick authored
The device type can now be used to determine the addresses of the control endpoints for the interface. Drop the conditional logic and make these values properties. Signed-off-by:
-
Chris Rorvick authored
The device type can now be used to determine the altsetting for the interface. Drop the conditional logic and make this value a property. Signed-off-by:
-
Chris Rorvick authored
The driver only supports interface 0 of the TonePort UX2 and POD Studio UX2 devices. Use the device table to filter on this. Signed-off-by:
-
Chris Rorvick authored
The driver only supports interface 1 of the Pocket POD. Use the device table to filter on this. Signed-off-by:
-
Chris Rorvick authored
The driver uses a different altsetting depending on the interface. Add device type entries for each of these. Signed-off-by:
-
Chris Rorvick authored
The PODxt Live device has both a POD and a Variax interface. Add device type entries for each of these. Signed-off-by:
-
Chris Rorvick authored
The `LINE6_CAP_CTRL_PCM_HW' macro combines three capabilities to save horizontal space when defining the properties entries. Now that these are no longer limited to single lines this is not such a concern. Specify capabilities individually when defining each property for better clarity. Signed-off-by:
-
Chris Rorvick authored
Specify the index of the properties entry explicitly to define this structure more robustly. Also, drop the `L6PROP' macro in favor of initializing each member explicitly on its own line since horizontal space is limited and more attributes will be added later. Signed-off-by:
-
Chris Rorvick authored
Including "BIT" in the macro name is pointless. Replace with "CAP" to provide some context for what its value represents. Signed-off-by:
-
Chris Rorvick authored
Signed-off-by:
-
Chris Rorvick authored
These are now only used to build the device table. Each entry in this table is already clearly documented as to what device it maps to so the macros become unnecessary indirection. Signed-off-by:
-
Chris Rorvick authored
The driver currently uses the device's idProduct as input to several switch statements. In some cases this is not sufficiently granular and the interface number must be taken into account. Store the device type in `usb_line6' and key off of it instead. New types can then be added that map to specific interfaces on the device so that this conditional logic can be flattened out. Signed-off-by:
-
Chris Rorvick authored
The current logic uses the index of the matched entry from the device table as an offset to the corresponding properties entry. The values of the new `line6_device_type' enum are ordered such that they can be used as an index into either of these arrays. Drop the device entry lookup logic and use the device type (via the .driver_info member) instead. Signed-off-by:
-
Chris Rorvick authored
Define an enum containing the supported devices and associate each entry in the device table to the respective value. Signed-off-by:
-
Chris Rorvick authored
Wrap USB_DEVICE to avoid repeating the Line 6 vendor ID. Signed-off-by:
-
Chris Rorvick authored
Support for these devices appears to have never been completed. Remove them from the device table along with a minimal amount of supporting code. Signed-off-by:
-
Chris Rorvick authored
This function was no longer used as of commit 28079044 (staging: line6: drop MIDI parameter sysfs attrs). Signed-off-by:
-
Chris Rorvick authored
The `device_bit' member was no longer used as of commit 28079044 (staging: line6: drop MIDI parameter sysfs attrs). Signed-off-by:
-
Jonas Lundqvist authored
Fix three space prohibited errors in pcm.h found by checkpatch.pl. Signed-off-by:
Jonas Lundqvist <jonas@gannon.se> Reviewed-by:
Jeremiah Mahler <jmmahler@gmail.com> Signed-off-by:
-
Rickard Strandqvist authored
The NULL check was done to late, and there it was a risk of a possible null pointer dereference. This was partially found by using a static code analysis program called cppcheck. Signed-off-by:
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Reviewed-by:
-
Takashi Iwai authored
Fix sparse warnings below by using snd_pcm_format_t properly: sound/pci/rme32.c:682:60: sparse: incorrect type in argument 2 (different base types) sound/pci/rme96.c:1006:69: sparse: incorrect type in argument 2 (different base types) ..... Signed-off-by: -
David Flater authored
Detected sound font memory goes unreported unless the kernel was built with ALSA debugging enabled. Elevate that to a pr_info. Signed-off-by:
David Flater <dave@flaterco.com> Signed-off-by:
-
David Flater authored
Applicable to any kernel since 2013: The special case added in commit 1338fc97 did not handle the possibility that the address space on an AWE64 Value would wrap around at 512 KiB. That is what it does, so the memory is still not detected on those cards. Fix that with a logic clean-up that eliminates the need for a special case. Signed-off-by:
-
Imre Deak authored
After switching to using the component interface this API isn't needed any more. v2-3: unchanged v4: - move the removal of i915_powerwell.h to this patch (Takashi) Signed-off-by:
Imre Deak <imre.deak@intel.com> Reviewed-by:
Daniel Vetter <daniel.vetter@ffwll.ch>
-
Imre Deak authored
Register a component master to be used to interface with the i915 driver. This is meant to replace the current interface which is based on module symbol lookups. Note that currently we keep the existing behavior and pin the i915 module while the hda driver is loaded. Using the component interface allows us to remove this dependency once support for dynamically enabling / disabling the HDMI functionality is added to the driver. v2: - change roles between the hda and i915 components (Daniel) v3: - rename display_component to audio_component (Daniel) v4: - move removal of i915_powerwell.h from this patch to the next (Takashi) - request_module fails if module support isn't enabled, so ignore any error it returns and depend on the following NULL check of the component ops (Takashi) - change over to using dev_* instead of pr_* (Takashi) Signed-off-by:
-
Imre Deak authored
chip is already passed to most of the i915 interface functions. Unify the interface by passing intel_hda instead of chip and passing it to all functions. Passing intel_hda instead of chip makes more sense since this is an intel specific interface. Also in an upcoming patch we will use intel_hda in all of these functions so by passing intel_hda we can save on some pointer casts from chip to intel_hda. This will be needed by an upcoming patch adding component support. No functional change. v2-3: unchanged v4: - pass intel_hda instead of chip Signed-off-by:
-
Imre Deak authored
This struct will be needed by the component code added in an upcoming patch, so export it into a new hda_intel.h file. At the same time also merge hda_i915.h into this new header, there is no reason to keep two separate intel specific header file. Suggested-by:
-
