• unknown's avatar
    Bug#21587 FLUSH TABLES causes server crash when used with HANDLER statements · f5dd3491
    unknown authored
    This bug is a symptom of the way handler's tables are managed. The
    most different aspect, compared to the conventional behavior, is that
    the handler's tables are long lived, meaning that their lifetimes are
    not bounded by the duration of the command that opened them. For this
    effect the handler code uses its own list (handler_tables instead of
    open_tables) to hold open handler tables so that the tables won't be
    closed at the end of the command/statement. Besides the handler_tables
    list, there is a hash (handler_tables_hash) which is used to associate
    handler aliases to tables and to refresh the tables upon demand (flush
    tables).
    
    The current implementation doesn't work properly with refreshed tables
    -- more precisely when flush commands are issued by other initiators.
    This happens because when a handler open or read statement is being
    processed, the associated table has to be opened or locked and, for this
    matter, the open_tables and handler_tables lists are swapped so that the
    new table being opened is inserted into the handler_tables list. But when
    opening or locking the table, if the refresh version is different from the
    thread refresh version then all used tables in the open_tables list (now
    handler_tables) are refreshed. In the "refreshing" process the handler
    tables are flushed (closed) without being properly unlinked from the
    handler hash.
    
    The current implementation also fails to properly discard handlers of
    dropped tables, but this and other problems are going to be addressed
    in the fixes for bugs 31397 and 31409.
    
    The chosen approach tries to properly save and restore the table state
    so that no table is flushed during the table open and lock operations.
    The logic is almost the same as before with the list swapping, but with
    a working glue code.
    
    The test case for this bug is going to be committed into 5.1 because it
    requires a test feature only avaiable in 5.1 (wait_condition).
    
    
    sql/sql_handler.cc:
      Backup and reset the open_tables and handler_table lists when opening
      a new handler table and merge the opened table into the handler_tables
      list afterwards. When locking, do the same but possibly close the table
      if a refresh is pending.
    f5dd3491
sql_handler.cc 23.5 KB