• Kristian Nielsen's avatar
    MDEV-9383: Server fails to read master.info after upgrade 10.0 -> 10.1 · 1cf852d8
    Kristian Nielsen authored
    In some cases, MariaDB 10.0 could write a master.info file that was read
    incorrectly by 10.1 and could cause server to fail to start after an upgrade.
    
    (If writing a new master.info file that is shorter than the old, extra
    junk may remain at the end of the file. This is handled properly in
    10.1 with an END_MARKER line, but this line is not written by
    10.0. The fix here is to make 10.1 robust at reading the master.info
    files written by 10.0).
    
    Fix several things around reading master.info and read_mi_key_from_file():
    
     - read_mi_key_from_file() did not distinguish between a line with and
       without an eqals '=' sign.
    
     - If a line was empty, read_mi_key_from_file() would incorrectly return
       the key from the previous call.
    
     - An extra using_gtid=X line left-over by MariaDB 10.0 might incorrectly
       be read and overwrite the correct value.
    
     - Fix incorrect usage of strncmp() which should be strcmp().
    
     - Add test cases.
    1cf852d8
bad5_master.info 107 Bytes