• unknown's avatar
    Bug#28012 Patch : IM crashes instead of reporting an error when mysqldpath is bad · 4ffd997a
    unknown authored
      
    On the windows platform, if an instance object failed to initialize during
    program start, the instance manager would crash.
    This could happen if an incorrect mysqld path was supplied in the 
    defaults configuration file.
    The patch prevents the program from crashing and makes it show an
    error message instead.
    
    
    mysql-test/r/im_options.result:
      - Options have changed names.
    server-tools/instance-manager/instance.cc:
      - Added code to verify that the instance object was initialized
        before any attempt is made to start the associated process.
      - Instance::complete_initialization method will now return TRUE
        on an error during instance initialization.
    server-tools/instance-manager/instance_options.cc:
      - Parsed result byte sequence from executed process doesn't contain a new line
        character anymore.
    server-tools/instance-manager/parse_output.cc:
      - 'popen' didn't behave as intended on the windows platform.
      - The function parse_output_and_get_value was completly rewritten to correct the
        error in the windows built and to be more easily maintained across platforms.
    server-tools/instance-manager/parse_output.h:
      - 'popen' didn't behave as intended on the windows platform.
      - The function parse_output_and_get_value was completly rewritten to correct the
        error in the windows built and to be more easily maintained across platforms.
    server-tools/instance-manager/portability.h:
      - Add more portability constants for convenience.
    4ffd997a
parse_output.cc 10.7 KB