• unknown's avatar
    Cleanup the instance manager code. · 26b6b1b2
    unknown authored
    
    BitKeeper/deleted/.del-factory.h~c1679505d3a6dd53:
      Delete: server-tools/instance-manager/factory.h
    BitKeeper/deleted/.del-factory.cc~6836cccd4cd35b4d:
      Delete: server-tools/instance-manager/factory.cc
    server-tools/instance-manager/Makefile.am:
      - remove Commands_factory: it'll be needed when we add support
      for NNTP/HTTP connections, currently it only adds unnecessary
      complexity.
    server-tools/instance-manager/commands.cc:
      - fix coding style: no else after return; fix comments, make
      one place a bit faster.
    server-tools/instance-manager/guardian.cc:
      - fix coding style and comments.
      - we must register the current thread in the thread registry
        before entering pthread_cond_timedwait, because at shutdown
        the thread registry will try to kick out of wait all blocked 
        threads. Unregistered threads are not awakened by the registry. 
        This fixes the failinig assert in Thread_registry::~Thread_registry
        at shutdown, when shutdown is requested and there is an
        instance monitored by Guardian.
    server-tools/instance-manager/guardian.h:
      - fix coding style: enums must start with enum_
    server-tools/instance-manager/instance.h:
      - move comment to the variable it comments
    server-tools/instance-manager/instance_map.cc:
      - cleanup
    server-tools/instance-manager/instance_options.cc:
      - cleanup; no else after return (fix coding style).
    server-tools/instance-manager/manager.cc:
      - fix alignment; make some code easier to read.
    server-tools/instance-manager/mysql_connection.cc:
      - remove Commands_factory
    server-tools/instance-manager/options.cc:
      - fix a possible crash when the instance manager is started with
      --no-defaults --defaults-file=~/.my.cnf: if we return
      without cloning saved_argv by calling load_defaults, Options::cleanup
      will crash on attempt to free_defaults(saved_argv);
    server-tools/instance-manager/parse.cc:
      - get rid of Commands_factory
    server-tools/instance-manager/parse.h:
      - get rid of Commands_factory
    server-tools/instance-manager/parse_output.cc:
      - in parse_output_and_get_value return error also if the specified
        pattern was not found, or the command failed to execute.
    server-tools/instance-manager/portability.h:
      - fix coding style (// comments are allowed only at ends of lines)
    server-tools/instance-manager/thread_registry.cc:
      - implement Thread_registry::cond_timedwait
    server-tools/instance-manager/thread_registry.h:
      - implement Thread_registry::cond_timedwait; remove
        unused out parameter from Thread_registry::cond_wait.
    server-tools/instance-manager/user_map.cc:
      - safety: newline can take 2 bytes.
    26b6b1b2
manager.cc 6.36 KB