• unknown's avatar
    Cleanups and optimization during review of new code · 44086a62
    unknown authored
    
    mysql-test/t/kill.test:
      Moved --disable_reconnect earlier to avoid race condition
    sql/sql_help.cc:
      Cleanup during review of new code
      (Moved variable definitions first in function
    sql/sql_insert.cc:
      Cleanup during review of new code
    sql/sql_lex.cc:
      Cleanup during review of new code
    sql/sql_parse.cc:
      Cleanup during review of new code
      Changed potential problem with previous_table_ref where it dependent that TABLE_LIST first element would be next_local
      Rearanged code in add_table_to_list() to remove extra if
      Combined 2 calls to calloc() to one
    sql/sql_view.cc:
      Remove extra indentation level
      Combined common 'on error' exit
    sql/sql_yacc.yy:
      Fixed comment style
    sql/table.cc:
      Cleanup during review of new code
      - Changed while() loops to for() loop (to make code more readable)
      - Removed not needed initialization of variables
      - Removed not needed 'else' cases
      - Removed trivial ASSERT's that was checked by previous code
      - Moved comment setting last in Natural_join_column::check_grants()
    44086a62
sql_insert.cc 79 KB