• unknown's avatar
    Fix for BUG#12228: SP cache code: · 502e97f8
    unknown authored
    * Cleanup SP Cache code, now SP Cache only deletes sp_head objects in 
      sp_cache_flush_obsolete() invalidates all pointers to routines in the cache.
    * Use new SP Cache use contract in the code.
    
    There is no test case because it doesn't seem to be possible to cause thread races to end
    the same way they end in heavy-load test. This patch removes the crash in heavy test.
    
    
    mysql-test/r/type_bit.result:
      Drop the tables this test tries to create
    mysql-test/r/view.result:
      Drop function this test creates
    mysql-test/t/type_bit.test:
      Drop the tables this test tries to create
    mysql-test/t/view.test:
      Drop function this test creates
    sql/sp.cc:
      Fix for BUG#12228: When a routine is deleted/modified, invalidate all cached SPs in all
      threads. We need to do so because sp_lex_keeper::{prelocking_tables, query_tables_own_last}
      in one SP may depend on another SP sp_lex_keeper::m_lex is using.
    sql/sp_cache.cc:
      Fix for BUG#12228:
      * Move class sp_cache to here from sp_cache.h, document the functions.
      * sp_cache_insert, sp_cache_remove, sp_cache_invalidate and sp_cache_lookup must not delete
        sp_head* objects as they may be called during SP execution when sp_head objects are used.
      * Added sp_cache_flush_obsolete() function that may delete sp_head objects.
      * Removed sp_cache_remove as there is no need for it now - when we change one SP we should
        invalidate all other SPs, because sp_lex_keeper::{prelocking_tables, 
        query_tables_own_last} from one SP depend on content of another SP (used in 
        sp_lex_keeper::m_lex).
    sql/sp_cache.h:
      Fix for BUG#12228:
      * Move class sp_cache to sp_cache.cc it is not needed in .h file
      * Added comments
    sql/sql_parse.cc:
      Fix for BUG#12228: Call new sp_cache_flush_obsolete() function before running the query
    sql/sql_prepare.cc:
      Fix for BUG#12228: Call new sp_cache_flush_obsolete() function before preparing/executing a PS
    502e97f8
sql_prepare.cc 69.1 KB