• Martin Hansson's avatar
    Bug#46454: MySQL wrong index optimisation leads to incorrect result & crashes · 4c3917b6
    Martin Hansson authored
    Problem 1:
    When the 'Using index' optimization is used, the optimizer may still - after
    cost-based optimization - decide to use another index in order to avoid using
    a temporary table. But when this happens, the flag to the storage engine to 
    read index only (not table) was still set. Fixed by resetting the flag in the 
    storage engine and TABLE structure in the above scenario, unless the new index
    allows for the same optimization.
    Problem 2:
    When a 'ref' access method was employed by cost-based optimizer, (when the column
    is non-NULLable), it was assumed that it needed no initialization if 'quick' access
    methods (since they are based on range scan). When ORDER BY optimization overrides 
    the decision, however, it expects to have this initialized and hence crashes. 
    Fixed in 5.1 (was fixed in 6.0 already) by initializing 'quick' even when there's 
    'ref' access. 
    
    mysql-test/r/order_by.result:
      Bug#46454: Test result.
    mysql-test/t/order_by.test:
      Bug#46454: Test case.
    sql/sql_select.cc:
      Bug#46454: 
      Problem 1 fixed in make_join_select()
      Problem 2 fixed in test_if_skip_sort_order()
    sql/table.h:
      Bug#46454: Added comment to field.
    4c3917b6
order_by.test 64 KB