• unknown's avatar
    Do not use 'created' for time anymore in Start_log_event, it's the same · 418fcdf1
    unknown authored
    as the already-stored timestamp. Now 'created' is used only to know if
    this is a first binlog or not. And we may re-use the superfluous bytes
    in 5.0 when we need room.
    
    
    sql/log_event.cc:
      This sort of reverts a change I made in 3.23.57. In 3.23.57 I set 'created' to 0
      if this was a non-first binlog, so I made mysqlbinlog not print the "created xx"
      part if created == 0. While this was sensible, as 'created' is 0 or equal to
      the timestamp which is already stored in the event, we can always print
      "created xx" by using the timestamp, and leaving the use of 'created' only to
      know if this is a first binlog or not (which we print as "created at startup").
    sql/log_event.h:
      In Start_log_event, 'created' is always the same as 'when', or O.
      We didn't need 4 bytes for this, a bit would have been enough (O or
      "same as 'when'"). Possibly in 5.0 we will re-use the useless bytes.
    418fcdf1
log_event.cc 18 KB