• Kristian Nielsen's avatar
    MDEV-7080: rpl.rpl_gtid_crash fails sporadically in buildbot · 7671fd70
    Kristian Nielsen authored
    The real problem here was inconsistent handling of entry->commit_errno in
    MYSQL_BIN_LOG::write_transaction_or_stmt(). Some return paths were setting it
    to the value of errno, some where not. And the setting was redundant anyway,
    as it is set consistently by the caller.
    
    Fix by consistently setting it in the caller, and not in each return path in
    the function.
    
    The test failure happened because a DBUG_EXECUTE_IF() used in the test case
    set an entry->commit_errno that was immediately overwritten in the caller with
    whatever happened to be the value of errno. This could lead to different error
    message in the .result file.
    7671fd70
log.cc 287 KB