• unknown's avatar
    Prevent adding 'CREATE TABLE .. SELECT' query to the binary log when the · 9286d1c1
    unknown authored
    insertion of new records partially failed. It would get logged because of the
    logic to log a partially-failed 'INSERT ... SELECT' (which can't be rolled back
    in non-transactional tables), but 'CREATE TABLE ... SELECT' is always rolled
    back on failure, even for non-transactional tables. (Bug #6682)
    (Original fix reimplemented after review by Serg and Guilhem.)
    
    
    mysql-test/t/insert_select.test:
      Add test case for Bug #6682
    mysql-test/r/insert_select.result:
      Add results for test case for Bug #6682
    sql/sql_table.cc:
      moved tmp_disable_binlog() and reenable_binlog macros to sql/sql_class.h
    sql/sql_insert.cc:
      disable binlog during call to super's ::send_error in select_create class
    sql/sql_class.h:
      add select_create::send_error()
    BitKeeper/etc/logging_ok:
      Logging to logging@openlogging.org accepted
    9286d1c1
sql_insert.cc 43.6 KB