• kostja@dipika.(none)'s avatar
    A fix and a test case for Bug#34166 Server crash in SHOW OPEN TABLES and · b46ce809
    kostja@dipika.(none) authored
    pre-locking.
    
    The crash was caused by an implicit assumption in check_table_access() that
    table_list parameter is always a part of lex->query_tables.
    
    When iterating over the passed list of tables, check_table_access() used
    to stop only when lex->query_tables_last_not_own was reached. 
    In case of pre-locking, lex->query_tables_last_own is not NULL and points
    to some element of lex->query_tables. When the parameter
    of check_table_access() was not part of lex->query_tables, loop invariant
    could never be violated and a crash would happen when the current table
    pointer would point beyond the end of the provided list.
    
    The fix is to change the signature of check_table_access() to also accept
    a numeric limit of loop iterations, similarly to check_grant(), and 
    supply this limit in all places when we want to check access of tables
    that are outside lex->query_tables, or just want to check access to one table.
    b46ce809
sql_parse.cc 217 KB