• Tatiana A. Nurnberg's avatar
    Bug#47655: Memory free error when connecting to 4.1 server from 5.1+ client · 1b0be8c5
    Tatiana A. Nurnberg authored
    When starting the (5.1+) mysql command-line client, we try to get
    "select @@version_comment" from the server to present it to the
    user. Recent clients are aware that older servers do not have that
    variable and fall back on other info to be able to present *something*
    at least. This fallback string was allocated through the POSIX interface,
    but released through the my*() suite, which rightfully complained about
    the imbalance in calls when compiled with --debug. While this wasn't
    as bad as it looked (no double-free, use of uninitialized or freed
    buffer, etc.), it did look funky.
    
    Using my_strdup() now for what will be my_free()d later.
    
    client/mysql.cc:
      Use my_strdup() for server_version, as we'll my_free() it later
      and don't want to upset the mysql client's memory accounting.
    1b0be8c5
mysql.cc 137 KB