• Georgi Kodinov's avatar
    Bug #55188: GROUP BY, GROUP_CONCAT and TEXT - inconsistent results · de5029a4
    Georgi Kodinov authored
    In order to be able to check if the set of the grouping fields in a 
    GROUP BY has changed (and thus to start a new group) the optimizer
    caches the current values of these fields in a set of Cached_item 
    derived objects.
    The Cached_item_str, used for caching varchar and TEXT columns,
    is limited in length by the max_sort_length variable.
    A String buffer to store the value with an alloced length of either
    the max length of the string or the value of max_sort_length 
    (whichever is smaller) in Cached_item_str's constructor.
    Then, at compare time the value of the string to compare to was 
    truncated to the alloced length of the string buffer inside 
    Cached_item_str.
    This is all fine and valid, but only if you're not assigning 
    values near or equal to the alloced length of this buffer.
    Because when assigning values like this the alloced length is 
    rounded up and as a result the next set of data will not match the
    group buffer, thus leading to wrong results because of the changed
    alloced_length.
    Fixed by preserving the original maximum length in the 
    Cached_item_str's constructor and using this instead of the 
    alloced_length to limit the string to compare to.
    Test case added.
    de5029a4
item.h 104 KB