• unknown's avatar
    Fix for BUG#25507 "multi-row insert delayed + auto increment causes · f6834c02
    unknown authored
    duplicate key entries on slave" (two concurrrent connections doing
    multi-row INSERT DELAYED to insert into an auto_increment column,
    caused replication slave to stop with "duplicate key error" (and
    binlog was wrong)), and BUG#26116 "If multi-row INSERT
    DELAYED has errors, statement-based binlogging breaks" (the binlog
    was not accounting for all rows inserted, or slave could stop).
    The fix is that: if (statement-based) binlogging is on, a multi-row
    INSERT DELAYED is silently converted to a non-delayed INSERT.
    Note: it is not possible to test BUG#25507 in 5.0 (requires mysqlslap),
    so it is tested only in the changeset for 5.1. However, BUG#26116
    is tested here, and the fix for BUG#25507 is the same code change.
    
    
    mysql-test/r/innodb-replace.result:
      result update
    mysql-test/t/innodb-replace.test:
      now that multi-row delayed inserts are converted to normal inserts
      if the statement-based binlog is enabled,
      no error is issued even if this engine does not support INSERT DELAYED,
      as the insert does not go through the INSERT DELAYED code.
      To preserve the goal of this test, we change the statements to single-
      row inserts.
    sql/sql_insert.cc:
      A multi-row INSERT DELAYED cannot be recorded to a statement-based
      binlog in a way that describes the insertions actually done;
      in that case we fallback to a non-delayed INSERT.
    mysql-test/r/rpl_insert_delayed.result:
      result. Master and slave match.
    mysql-test/t/rpl_insert_delayed.test:
      Test for BUG#26116 (see if one error at first row on master makes the
      slave's data incorrect, see if one error at second row on master
      makes slave stop).
    f6834c02
sql_insert.cc 91.8 KB