Commit 09db4976 authored by unknown's avatar unknown

Bug#27499 DROP TABLE race with SHOW TABLE STATUS

They can drop table after table names list creation and before table opening.
We open non existing table and get ER_NO_SUCH_TABLE error.
In this case we do not store the record into I_S table and clear error.


sql/sql_show.cc:
  Hide error for not existing table
parent 579c2bff
...@@ -2314,18 +2314,32 @@ int get_all_tables(THD *thd, TABLE_LIST *tables, COND *cond) ...@@ -2314,18 +2314,32 @@ int get_all_tables(THD *thd, TABLE_LIST *tables, COND *cond)
res= open_normal_and_derived_tables(thd, show_table_list, res= open_normal_and_derived_tables(thd, show_table_list,
MYSQL_LOCK_IGNORE_FLUSH); MYSQL_LOCK_IGNORE_FLUSH);
lex->sql_command= save_sql_command; lex->sql_command= save_sql_command;
/* /*
We should use show_table_list->alias instead of They can drop table after table names list creation and
show_table_list->table_name because table_name before table opening. We open non existing table and
could be changed during opening of I_S tables. It's safe get ER_NO_SUCH_TABLE error. In this case we do not store
to use alias because alias contains original table name the record into I_S table and clear error.
in this case.
*/ */
res= schema_table->process_table(thd, show_table_list, table, if (thd->net.last_errno == ER_NO_SUCH_TABLE)
res, orig_base_name, {
show_table_list->alias); res= 0;
close_tables_for_reopen(thd, &show_table_list); thd->clear_error();
DBUG_ASSERT(!lex->query_tables_own_last); }
else
{
/*
We should use show_table_list->alias instead of
show_table_list->table_name because table_name
could be changed during opening of I_S tables. It's safe
to use alias because alias contains original table name
in this case.
*/
res= schema_table->process_table(thd, show_table_list, table,
res, orig_base_name,
show_table_list->alias);
close_tables_for_reopen(thd, &show_table_list);
DBUG_ASSERT(!lex->query_tables_own_last);
}
if (res) if (res)
goto err; goto err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment