made do_backtrace an env function that uses errfile #201

fixes #201

buildheader/make_tdb.cc

@@ -463,6 +463,7 @@ static void print_db_env_struct (void) {
                              "int (*iterate_pending_lock_requests)        (DB_ENV *env, iterate_requests_callback callback, void *extra)",
                              "void (*set_loader_memory_size)(DB_ENV *env, uint64_t (*get_loader_memory_size_callback)(void))",
                              "uint64_t (*get_loader_memory_size)(DB_ENV *env)",
+                             "void (*env_do_backtrace)                    (DB_ENV *env)",
                              NULL};
 
         sort_and_dump_fields("db_env", true, extra);
@@ -854,7 +855,6 @@ int main (int argc, char *const argv[] __attribute__((__unused__))) {
     printf("void db_env_set_num_bucket_mutexes(uint32_t) %s;\n", VISIBLE);
     printf("int db_env_set_toku_product_name(const char*) %s;\n", VISIBLE);
     printf("void db_env_try_gdb_stack_trace(const char *gdb_path) %s;\n", VISIBLE);
-    printf("void db_env_do_backtrace(void) %s;\n", VISIBLE);
 
     printf("#if defined(__cplusplus) || defined(__cilkplusplus)\n}\n#endif\n");
     printf("#endif\n");

portability/toku_assert.cc

@@ -138,31 +138,30 @@ void toku_assert_set_fpointers(int (*toku_maybe_get_engine_status_text_pointer)(
 bool toku_gdb_dump_on_assert = false;
 void (*do_assert_hook)(void) = NULL;
 
-extern "C" void db_env_do_backtrace(void) __attribute__((__visibility__("default")));  // also declared in db.h for consumers of that API
-extern "C" void db_env_do_backtrace(void) {
+void db_env_do_backtrace(FILE *outf) {
     // backtrace
 #if !TOKU_WINDOWS
     int n = backtrace(backtrace_pointers, N_POINTERS);
-    fprintf(stderr, "Backtrace: (Note: toku_do_assert=0x%p)\n", toku_do_assert); fflush(stderr);
-    backtrace_symbols_fd(backtrace_pointers, n, fileno(stderr));
+    fprintf(outf, "Backtrace: (Note: toku_do_assert=0x%p)\n", toku_do_assert); fflush(outf);
+    backtrace_symbols_fd(backtrace_pointers, n, fileno(outf));
 #endif
 
-    fflush(stderr);
+    fflush(outf);
     
     if (engine_status_num_rows && toku_maybe_get_engine_status_text_p) {
 	int buffsize = engine_status_num_rows * 128;  // assume 128 characters per row (gross overestimate, should be safe)
 	char buff[buffsize];	
 	toku_maybe_get_engine_status_text_p(buff, buffsize);  
-	fprintf(stderr, "Engine status:\n%s\n", buff);
+	fprintf(outf, "Engine status:\n%s\n", buff);
+    } else {
+	fprintf(outf, "Engine status function not available\n");
     }
-    else
-	fprintf(stderr, "Engine status function not available\n");
-    fprintf(stderr, "Memory usage:\n");
-    fflush(stderr);	    // just in case malloc_stats() crashes, we still want engine status (and to know that malloc_stats() failed)
+    fprintf(outf, "Memory usage:\n");
+    fflush(outf);	    // just in case malloc_stats() crashes, we still want engine status (and to know that malloc_stats() failed)
     if (malloc_stats_f) {
         malloc_stats_f();
     }
-    fflush(stderr);	    
+    fflush(outf);
 
     if (do_assert_hook) do_assert_hook();
     if (toku_gdb_dump_on_assert) {
@@ -172,7 +171,7 @@ extern "C" void db_env_do_backtrace(void) {
 
 __attribute__((noreturn))
 static void toku_do_backtrace_abort(void) {
-    db_env_do_backtrace();
+    db_env_do_backtrace(stderr);
 
 #if TOKU_WINDOWS
     //Following commented methods will not always end the process (could hang).

src/ydb.cc

@@ -2452,6 +2452,14 @@ static uint64_t env_get_loader_memory_size(DB_ENV *env) {
     return memory_size;
 }
 
+static void env_do_backtrace(DB_ENV *env) {
+    if (env->i->errfile) {
+        db_env_do_backtrace(env->i->errfile);
+    } else {
+        db_env_do_backtrace(stderr);
+    }
+}
+
 static int 
 toku_env_create(DB_ENV ** envp, uint32_t flags) {
     int r = ENOSYS;
@@ -2527,6 +2535,7 @@ toku_env_create(DB_ENV ** envp, uint32_t flags) {
     USENV(change_fsync_log_period);
     USENV(set_loader_memory_size);
     USENV(get_loader_memory_size);
+    USENV(do_backtrace);
 #undef USENV
     
     // unlocked methods

toku_include/toku_assert.h

@@ -98,6 +98,7 @@ PATENT RIGHTS GRANT:
 
 #include <stdint.h>
 #include <errno.h>
+#include <stdio.h>
 
 #ifdef NDEBUG
 #error NDEBUG should not be set
@@ -134,6 +135,7 @@ void toku_do_assert_expected_fail(uintptr_t/*expr*/, uintptr_t /*expected*/, con
 // #define GCOV
 
 extern void (*do_assert_hook)(void); // Set this to a function you want called after printing the assertion failure message but before calling abort().  By default this is NULL.
+void db_env_do_backtrace(FILE *outf);
 
 #if defined(GCOV) || TOKU_WINDOWS
 #define assert(expr)      toku_do_assert((expr) != 0, #expr, __FUNCTION__, __FILE__, __LINE__, get_maybe_error_errno())