Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mariadb
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
mariadb
Commits
1fb33e4a
Commit
1fb33e4a
authored
Jun 13, 2013
by
Sergei Golubchik
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
MDEV-4529 Assertion `tmp->state == 4' fails on mix of INSTALL SONAME / UNINSTALL PLUGIN
fix incorrect assert
parent
36c75351
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
38 additions
and
1 deletion
+38
-1
mysql-test/r/plugin.result
mysql-test/r/plugin.result
+19
-0
mysql-test/t/plugin.test
mysql-test/t/plugin.test
+14
-0
sql/sql_plugin.cc
sql/sql_plugin.cc
+5
-1
No files found.
mysql-test/r/plugin.result
View file @
1fb33e4a
...
...
@@ -173,3 +173,22 @@ select 1;
UNINSTALL PLUGIN example;
UNINSTALL PLUGIN MyISAM;
ERROR HY000: Built-in plugins cannot be deleted
select plugin_name from information_schema.plugins where plugin_library like 'ha_example%';
plugin_name
install soname 'ha_example';
select plugin_name from information_schema.plugins where plugin_library like 'ha_example%';
plugin_name
EXAMPLE
UNUSABLE
uninstall plugin example;
select plugin_name from information_schema.plugins where plugin_library like 'ha_example%';
plugin_name
UNUSABLE
install soname 'ha_example';
select plugin_name from information_schema.plugins where plugin_library like 'ha_example%';
plugin_name
EXAMPLE
UNUSABLE
uninstall soname 'ha_example';
select plugin_name from information_schema.plugins where plugin_library like 'ha_example%';
plugin_name
mysql-test/t/plugin.test
View file @
1fb33e4a
...
...
@@ -155,3 +155,17 @@ UNINSTALL PLUGIN example;
--
error
ER_PLUGIN_DELETE_BUILTIN
UNINSTALL
PLUGIN
MyISAM
;
#
# MDEV-4529 Assertion `tmp->state == 4' fails on mix of INSTALL SONAME / UNINSTALL PLUGIN
#
select
plugin_name
from
information_schema
.
plugins
where
plugin_library
like
'ha_example%'
;
install
soname
'ha_example'
;
select
plugin_name
from
information_schema
.
plugins
where
plugin_library
like
'ha_example%'
;
uninstall
plugin
example
;
select
plugin_name
from
information_schema
.
plugins
where
plugin_library
like
'ha_example%'
;
install
soname
'ha_example'
;
select
plugin_name
from
information_schema
.
plugins
where
plugin_library
like
'ha_example%'
;
uninstall
soname
'ha_example'
;
select
plugin_name
from
information_schema
.
plugins
where
plugin_library
like
'ha_example%'
;
sql/sql_plugin.cc
View file @
1fb33e4a
...
...
@@ -2032,9 +2032,13 @@ static bool finalize_install(THD *thd, TABLE *table, const LEX_STRING *name)
ER_CANT_INITIALIZE_UDF
,
ER
(
ER_CANT_INITIALIZE_UDF
),
name
->
str
,
"Plugin is disabled"
);
}
else
if
(
tmp
->
state
!=
PLUGIN_IS_UNINITIALIZED
)
{
/* already installed */
return
0
;
}
else
{
DBUG_ASSERT
(
tmp
->
state
==
PLUGIN_IS_UNINITIALIZED
);
if
(
plugin_initialize
(
tmp
))
{
report_error
(
REPORT_TO_USER
,
ER_CANT_INITIALIZE_UDF
,
name
->
str
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment