Commit 4de39a7a authored by Paul McCullagh's avatar Paul McCullagh

According to Sergei this code must be removed when a second engine supports XA

parent decc3a36
......@@ -1583,17 +1583,20 @@ int ha_recover(HASH *commit_list)
if (info.commit_list)
sql_print_information("Starting crash recovery...");
#ifndef WILL_BE_DELETED_LATER
/* With PBXT 1.0.09 2 engines now support XA. According to Sergei, this
code below should therefore be removed. The code below
handles the case when the engines report prepared transactions,
but the binlogs are missing or have no recovery information.
In this case the tc_heuristic_recover variable determines whether
prepared transcations should be committed or rolled back.
If there is only one engine, then rollback is safe.
*/
#ifdef WILL_BE_DELETED_LATER
/*
for now, only InnoDB supports 2pc. It means we can always safely
rollback all pending transactions, without risking inconsistent data
*/
/* TODO: FIX THIS (2009-11-25)!
With PBXT 1.0.09 2 engines now support XA. For the moment I am just taking
out the assertion which fails because pbxt_xa_support is enabled by
default.
*/
//DBUG_ASSERT(total_ha_2pc == (ulong) opt_bin_log+1); // only InnoDB and binlog
DBUG_ASSERT(total_ha_2pc == (ulong) opt_bin_log+1); // only InnoDB and binlog
tc_heuristic_recover= TC_HEURISTIC_RECOVER_ROLLBACK; // forcing ROLLBACK
info.dry_run=FALSE;
#endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment