Commit 57980ef4 authored by jimw@mysql.com's avatar jimw@mysql.com

Bug #18617: mysql-test-run.pl, partially wrong handling of option "start-dirty"

  This was a case of too much code. The --start-dirty option should act
  just like --start-and-exit, except it skips the database initialization
  step. Now it does, which means it picks up the options from the specified
  test case.
parent b57eb9e1
...@@ -407,22 +407,7 @@ sub main () { ...@@ -407,22 +407,7 @@ sub main () {
} }
} }
if ( $opt_start_dirty ) if ( $opt_bench )
{
if ( ndbcluster_start($opt_with_ndbcluster) )
{
mtr_error("Can't start ndbcluster");
}
if ( mysqld_start('master',0,[],[],$using_ndbcluster_master) )
{
mtr_report("Servers started, exiting");
}
else
{
mtr_error("Can't start the mysqld server");
}
}
elsif ( $opt_bench )
{ {
run_benchmarks(shift); # Shift what? Extra arguments?! run_benchmarks(shift); # Shift what? Extra arguments?!
} }
...@@ -2027,10 +2012,11 @@ sub run_testcase ($) { ...@@ -2027,10 +2012,11 @@ sub run_testcase ($) {
} }
# ---------------------------------------------------------------------- # ----------------------------------------------------------------------
# If --start-and-exit given, stop here to let user manually run tests # If --start-and-exit or --start-dirty given, stop here to let user manually
# run tests
# ---------------------------------------------------------------------- # ----------------------------------------------------------------------
if ( $opt_start_and_exit ) if ( $opt_start_and_exit or $opt_start_dirty )
{ {
mtr_report("\nServers started, exiting"); mtr_report("\nServers started, exiting");
exit(0); exit(0);
...@@ -3409,11 +3395,12 @@ Misc options ...@@ -3409,11 +3395,12 @@ Misc options
comment=STR Write STR to the output comment=STR Write STR to the output
script-debug Debug this script itself script-debug Debug this script itself
timer Show test case execution time timer Show test case execution time
start-and-exit Only initiate and start the "mysqld" servers, use the startup start-and-exit Only initialize and start the servers, using the
settings for the specified test case if any startup settings for the specified test case (if any)
start-dirty Only start the "mysqld" servers without initiation start-dirty Only start the servers (without initialization) for
fast Don't try to cleanup from earlier runs the specified test case (if any)
reorder Reorder tests to get less server restarts fast Don't try to clean up from earlier runs
reorder Reorder tests to get fewer server restarts
help Get this help text help Get this help text
unified-diff | udiff When presenting differences, use unified diff unified-diff | udiff When presenting differences, use unified diff
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment