Commit 75cfee68 authored by petr@mysql.com's avatar petr@mysql.com

post review fix

parent b698b862
...@@ -418,15 +418,16 @@ static int search_default_file_with_ext(DYNAMIC_ARRAY *args, MEM_ROOT *alloc, ...@@ -418,15 +418,16 @@ static int search_default_file_with_ext(DYNAMIC_ARRAY *args, MEM_ROOT *alloc,
/* trim trailing whitespace from directory name */ /* trim trailing whitespace from directory name */
end= ptr + strlen(ptr) - 1; end= ptr + strlen(ptr) - 1;
/* /* fgets() stores the newline character in the buffer */
This would work fine even if no whitespaces are met if ((end[0] == '\n') || (end[0] == '\r') ||
since fgets() stores the newline character in the buffer my_isspace(&my_charset_latin1, end[0]))
*/ {
for (; my_isspace(&my_charset_latin1, *(end - 1)); end--) for (; my_isspace(&my_charset_latin1, *(end - 1)); end--)
{} {}
end[0]= 0; end[0]= 0;
}
/* print error msg if there is nothing after !inludedir directive */ /* print error msg if there is nothing after !includedir directive */
if (end == ptr) if (end == ptr)
{ {
fprintf(stderr, fprintf(stderr,
...@@ -444,7 +445,7 @@ static int search_default_file_with_ext(DYNAMIC_ARRAY *args, MEM_ROOT *alloc, ...@@ -444,7 +445,7 @@ static int search_default_file_with_ext(DYNAMIC_ARRAY *args, MEM_ROOT *alloc,
search_file= search_dir->dir_entry + i; search_file= search_dir->dir_entry + i;
ext= fn_ext(search_file->name); ext= fn_ext(search_file->name);
/* check extenstion */ /* check extension */
for (tmp_ext= (char**) f_extensions; *tmp_ext; *tmp_ext++) for (tmp_ext= (char**) f_extensions; *tmp_ext; *tmp_ext++)
{ {
if (!strcmp(ext, *tmp_ext)) if (!strcmp(ext, *tmp_ext))
...@@ -496,6 +497,14 @@ static int search_default_file_with_ext(DYNAMIC_ARRAY *args, MEM_ROOT *alloc, ...@@ -496,6 +497,14 @@ static int search_default_file_with_ext(DYNAMIC_ARRAY *args, MEM_ROOT *alloc,
continue; continue;
} }
else
if (recursion_level >= max_recursion_level)
{
fprintf(stderr,
"warning: skipping !include directive as maximum include"
"recursion level was reached in file %s at line %d\n",
name, line);
}
if (*ptr == '[') /* Group name */ if (*ptr == '[') /* Group name */
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment