[t:2539] Modified makefiles to behave for gcc 4.4.1.

Fixed code to remove warnings (checked result of 'system()' and printf warnings)

git-svn-id: file:///svn/toku/tokudb@19560 c7de825b-a66e-492c-adef-691d508d4ae1

db-benchmark-test/db-benchmark-test.c

@@ -155,7 +155,8 @@ static void benchmark_setup (void) {
 	char unlink_cmd[strlen(dbdir) + strlen("rm -rf ") + 1];
 	snprintf(unlink_cmd, sizeof(unlink_cmd), "rm -rf %s", dbdir);
 	//printf("unlink_cmd=%s\n", unlink_cmd);
-	system(unlink_cmd);
+	r = system(unlink_cmd);
+        CKERR(r);
 
         if (strcmp(dbdir, ".") != 0) {
             r = toku_os_mkdir(dbdir,S_IRWXU|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH);

db-benchmark-test/scanscan.c

@@ -229,7 +229,7 @@ static void print_engine_status(void) {
       char buff[buffsize];
       env->get_engine_status_text(env, buff, buffsize);
       printf("Engine status:\n");
-      printf(buff);
+      printf("%s", buff);
     }
 #endif
 }

linux/tests/Makefile

@@ -4,6 +4,8 @@ CPPFLAGS += -I../../toku_include -I.. -I.
 CFLAGS = -Wall -Werror -g -O0 -std=c99
 ifeq ($(GCCVERSION),4.4.2)
 	CFLAGS += -Wno-deprecated
+else ifeq ($(GCCVERSION),4.4.1)
+	CFLAGS += -Wno-deprecated
 endif
 ifneq ($(GCOV),)
 	CFLAGS += -fprofile-arcs -ftest-coverage -DGCOV

newbrt/tests/log-test.c

@@ -13,7 +13,8 @@ test_main (int argc __attribute__((__unused__)),
 	  const char *argv[] __attribute__((__unused__))) {
     int r;
     long long lognum;
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
     r = toku_os_mkdir(dname, S_IRWXU);    assert(r==0);
     r = toku_logger_find_next_unused_log_file(dname,&lognum);
     assert(r==0 && lognum==0LL);

newbrt/tests/log-test2.c

@@ -14,7 +14,8 @@ int
 test_main (int argc __attribute__((__unused__)),
 	  const char *argv[] __attribute__((__unused__))) {
     int r;
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
     r = toku_os_mkdir(dname, S_IRWXU);    assert(r==0);
     TOKULOGGER logger;
     r = toku_logger_create(&logger);

newbrt/tests/log-test3.c

@@ -14,7 +14,8 @@ int
 test_main (int argc __attribute__((__unused__)),
 	  const char *argv[] __attribute__((__unused__))) {
     int r;
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
     r = toku_os_mkdir(dname, S_IRWXU);    assert(r==0);
     TOKULOGGER logger;
     r = toku_logger_create(&logger);

newbrt/tests/log-test4.c

@@ -14,7 +14,8 @@ int
 test_main (int argc __attribute__((__unused__)),
 	  const char *argv[] __attribute__((__unused__))) {
     int r;
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
     r = toku_os_mkdir(dname, S_IRWXU);                               assert(r==0);
     TOKULOGGER logger;
     r = toku_logger_create(&logger);                                 assert(r == 0);

newbrt/tests/log-test5.c

@@ -16,7 +16,8 @@ int
 test_main (int argc __attribute__((__unused__)),
 	  const char *argv[] __attribute__((__unused__))) {
     int r;
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
     r = toku_os_mkdir(dname, S_IRWXU);    assert(r==0);
     TOKULOGGER logger;
     r = toku_logger_create(&logger);

newbrt/tests/log-test6.c

@@ -16,7 +16,8 @@ int
 test_main (int argc __attribute__((__unused__)),
 	  const char *argv[] __attribute__((__unused__))) {
     int r;
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
     r = toku_os_mkdir(dname, S_IRWXU);    assert(r==0);
     TOKULOGGER logger;
     r = toku_logger_create(&logger);

newbrt/tests/log-test7.c

@@ -67,13 +67,16 @@ test_main (int argc __attribute__((__unused__)),
     int i;
     int loop;
     const int numloops = 100;
+    int r;
     for (loop = 0; loop < numloops; loop++) {
-        system(rmrf);
+        r = system(rmrf);
+        CKERR(r);
         for (i = 0; i < NUM_LOGGERS; i++) setup_logger(i);
         for (i = 0; i < NUM_LOGGERS; i++) play_with_logger(i);
         for (i = 0; i < NUM_LOGGERS; i++) tear_down_logger(i);
     }
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
 
     return 0;
 }

newbrt/tests/logcursor-bad-checksum.c

@@ -26,7 +26,8 @@ test_main (int argc, const char *argv[]) {
     default_parse_args(argc, argv);
 
     int r;
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
     r = toku_os_mkdir(dname, S_IRWXU);    assert(r==0);
     TOKULOGGER logger;
     LSN lsn = ZERO_LSN;

newbrt/tests/logcursor-empty-logdir.c

@@ -15,7 +15,8 @@ test_main (int argc, const char *argv[]) {
     default_parse_args(argc, argv);
 
     int r;
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
     r = toku_os_mkdir(dname, S_IRWXU);    assert(r==0);
 
     // verify the log is empty

newbrt/tests/logcursor-empty-logfile-2.c

@@ -15,7 +15,8 @@ test_main (int argc, const char *argv[]) {
     default_parse_args(argc, argv);
 
     int r;
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
     r = toku_os_mkdir(dname, S_IRWXU);    assert(r==0);
     TOKULOGGER logger;
     LSN lsn = ZERO_LSN;

newbrt/tests/logcursor-empty-logfile-3.c

@@ -15,7 +15,8 @@ test_main (int argc, const char *argv[]) {
     default_parse_args(argc, argv);
 
     int r;
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
     r = toku_os_mkdir(dname, S_IRWXU);    assert(r==0);
     TOKULOGGER logger;
     LSN lsn = ZERO_LSN;

newbrt/tests/logcursor-empty-logfile.c

@@ -15,7 +15,8 @@ test_main (int argc, const char *argv[]) {
     default_parse_args(argc, argv);
 
     int r;
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
     r = toku_os_mkdir(dname, S_IRWXU);    assert(r==0);
     TOKULOGGER logger;
     LSN lsn = ZERO_LSN;

newbrt/tests/logcursor-timestamp.c

@@ -23,7 +23,8 @@ test_main (int argc, const char *argv[]) {
     default_parse_args(argc, argv);
 
     int r;
-    system(rmrf);
+    r = system(rmrf);
+    CKERR(r);
     r = toku_os_mkdir(dname, S_IRWXU);    assert(r==0);
     TOKULOGGER logger;
     LSN lsn = ZERO_LSN;

newbrt/tests/recovery-bad-last-entry.c

@@ -15,7 +15,8 @@ run_test(void) {
 
     while ( 1 ) {
         // setup the test dir
-        system("rm -rf " TESTDIR);
+        r = system("rm -rf " TESTDIR);
+        CKERR(r);
         r = toku_os_mkdir(TESTDIR, S_IRWXU); assert(r == 0);
 
         // create the log
@@ -48,8 +49,10 @@ run_test(void) {
         sprintf(fname, "%s/%s", TESTDIR, "log000000000000.tokulog");
 
         r = toku_stat(fname, &st); assert(r==0);
-        if ( st.st_size - trim > magic_begin_end_checkpoint_sz )
-            truncate(fname, st.st_size - trim);
+        if ( st.st_size - trim > magic_begin_end_checkpoint_sz ) {
+            r = truncate(fname, st.st_size - trim);
+            CKERR(r);
+        }
         else
             break;
         // run recovery

newbrt/tests/recovery-cbegin-cend-hello.c

@@ -10,7 +10,8 @@ run_test(void) {
     int r;
 
     // setup the test dir
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     r = toku_os_mkdir(TESTDIR, S_IRWXU); assert(r == 0);
 
     // create the log

newbrt/tests/recovery-cbegin-cend.c

@@ -8,7 +8,8 @@ run_test(void) {
     int r;
 
     // setup the test dir
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     r = toku_os_mkdir(TESTDIR, S_IRWXU); assert(r == 0);
 
     // put begin and end checkpoint into separate log files

newbrt/tests/recovery-cbegin.c

@@ -8,7 +8,8 @@ run_test(void) {
     int r;
 
     // setup the test dir
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     r = toku_os_mkdir(TESTDIR, S_IRWXU); assert(r == 0);
 
     // create the log

newbrt/tests/recovery-cend-cbegin.c

@@ -10,7 +10,8 @@ run_test(void) {
     int r;
 
     // setup the test dir
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     r = toku_os_mkdir(TESTDIR, S_IRWXU); assert(r == 0);
 
     // create the log

newbrt/tests/recovery-empty.c

@@ -10,7 +10,8 @@ run_test(void) {
     int r;
 
     // setup the test dir
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     r = toku_os_mkdir(TESTDIR, S_IRWXU); assert(r == 0);
 
     // create the log

newbrt/tests/recovery-fopen-missing-file.c

@@ -10,7 +10,8 @@ run_test(void) {
     int r;
 
     // setup the test dir
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     r = toku_os_mkdir(TESTDIR, S_IRWXU); assert(r == 0);
 
     // create the log

newbrt/tests/recovery-hello.c

@@ -10,7 +10,8 @@ run_test(void) {
     int r;
 
     // setup the test dir
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     r = toku_os_mkdir(TESTDIR, S_IRWXU); assert(r == 0);
 
     // create the log

newbrt/tests/recovery-lsn-error-during-forward-scan.c

@@ -20,7 +20,8 @@ run_test(void) {
     int r;
 
     // setup the test dir
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     r = toku_os_mkdir(TESTDIR, S_IRWXU); assert(r == 0);
 
     // log 1 has the checkpoint

newbrt/tests/recovery-no-datadir.c

@@ -10,7 +10,8 @@ run_test(void) {
     int r;
 
     // setup the test dir
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     r = toku_os_mkdir(TESTDIR, S_IRWXU); assert(r == 0);
 
     // create the log

newbrt/tests/recovery-no-log.c

@@ -10,7 +10,8 @@ run_test(void) {
     int r;
 
     // setup the test dir
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     r = toku_os_mkdir(TESTDIR, S_IRWXU); assert(r == 0);
 
     // redirect stderr

newbrt/tests/recovery-no-logdir.c

@@ -10,7 +10,8 @@ run_test(void) {
     int r;
 
     // setup the test dir
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     r = toku_os_mkdir(TESTDIR, S_IRWXU); assert(r == 0);
 
     // run recovery

newbrt/tests/test_logcursor.c

@@ -51,14 +51,16 @@ int test_main(int argc, const char *argv[]) {
     // start from a clean directory
     char rmrf_cmd[100];
     sprintf(rmrf_cmd, "rm -rf %s", LOGDIR);
-    system(rmrf_cmd);
+    r = system(rmrf_cmd);
+    CKERR(r);
     toku_os_mkdir(LOGDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     if ( (r=create_logfiles()) !=0 ) return r;
 
     if ( (r=test_0()) !=0 ) return r;
     if ( (r=test_1()) !=0 ) return r;
 
-    system(rmrf_cmd);
+    r = system(rmrf_cmd);
+    CKERR(r);
     return r;
 }
 

src/lock_tree/tests/test_00070_ltm.c

@@ -71,7 +71,8 @@ int main(int argc, const char *argv[]) {
     compare_fun = intcmp;
     dup_compare = intcmp;
 
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     toku_os_mkdir(TESTDIR, S_IRWXU|S_IRWXG|S_IRWXO);
 
     run_test(FALSE);

src/lock_tree/tests/test_00080_lt_refcount.c

@@ -139,7 +139,8 @@ int main(int argc, const char *argv[]) {
     compare_fun = intcmp;
     dup_compare = intcmp;
 
-    system("rm -rf " TESTDIR);
+    r = system("rm -rf " TESTDIR);
+    CKERR(r);
     toku_os_mkdir(TESTDIR, S_IRWXU|S_IRWXG|S_IRWXO);
 
     initial_setup();

src/tests/big-nested-abort-abort.c

@@ -83,7 +83,8 @@ static void
 setup (void) {
     DB_TXN *txn;
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       CKERR(r);
 
     r=db_env_create(&env, 0); CKERR(r);

src/tests/big-nested-abort-commit.c

@@ -82,7 +82,8 @@ static void
 setup (void) {
     DB_TXN *txn;
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       CKERR(r);
 
     r=db_env_create(&env, 0); CKERR(r);

src/tests/big-nested-commit-abort.c

@@ -77,7 +77,8 @@ static void
 setup (void) {
     DB_TXN *txn;
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       CKERR(r);
 
     r=db_env_create(&env, 0); CKERR(r);

src/tests/big-nested-commit-commit.c

@@ -77,7 +77,8 @@ static void
 setup (void) {
     DB_TXN *txn;
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       CKERR(r);
 
     r=db_env_create(&env, 0); CKERR(r);

src/tests/bug1381.c

@@ -11,7 +11,8 @@ static void do_1381_maybe_lock (int do_table_lock, u_int64_t *raw_count) {
     int r;
     DB_TXN * const null_txn = 0;
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
 

src/tests/bug627.c

@@ -11,7 +11,8 @@ do_627 (void) {
     int r;
     DB_ENV *env;
     DB *db;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       assert(r==0);
 
     r=db_env_create(&env, 0); assert(r==0);

src/tests/checkpoint1.c

@@ -26,10 +26,11 @@ insert(int i)
 static void
 checkpoint1 (void)
 {
-    system("rm -rf " ENVDIR);
+    int r;
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
-    int r;
     r = db_env_create(&env, 0);                                                     CKERR(r);
 
     r = env->open(env, ENVDIR, DB_INIT_LOCK|DB_INIT_LOG|DB_INIT_MPOOL|DB_INIT_TXN|DB_CREATE|DB_PRIVATE, S_IRWXU+S_IRWXG+S_IRWXO); CKERR(r);

src/tests/create-datadir.c

@@ -10,7 +10,8 @@ char *nameb="b.db";
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/cursor-more-than-a-leaf-provdel.c

@@ -12,8 +12,9 @@ const int num_insert = 25000;
 
 static void
 setup (void) {
-    system("rm -rf " ENVDIR);
     int r;
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       CKERR(r);
 
     r=db_env_create(&env, 0); CKERR(r);

src/tests/cursor-step-over-delete.c

@@ -10,8 +10,9 @@ DB_TXN *txn;
 
 static void
 test_setup (void) {
-    system("rm -rf " ENVDIR);
     int r;
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       CKERR(r);
 
     r=db_env_create(&env, 0); CKERR(r);

src/tests/env-put-multiple.c

@@ -52,7 +52,8 @@ static void run_test (void) {
     if (verbose)
         printf("env-put-multiple num_dbs[%u]\n", num_dbs);
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/filesize.c

@@ -58,9 +58,10 @@ close_em (void)
 static void
 setup(void)
 {
-    system("rm -rf " ENVDIR);
-    toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     int r;
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
+    toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     r = db_env_create(&env, 0);                                         CKERR(r);
     r = env->open(env, ENVDIR, envflags, S_IRWXU+S_IRWXG+S_IRWXO);      CKERR(r);
     r = db_create(&db, env, 0);                                         CKERR(r);

src/tests/helgrind2.c

@@ -15,7 +15,8 @@ DB *db;
 
 static void initialize (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, 0777);
 
     // setup environment

src/tests/helgrind3.c

@@ -15,7 +15,8 @@ DB *db;
 
 static void initialize (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, 0777);
 
     // setup environment

src/tests/inflate.c

@@ -46,9 +46,10 @@ reopen_em (void)
 static void
 setup(void)
 {
-    system("rm -rf " ENVDIR);
-    toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     int r;
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
+    toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     r = db_env_create(&env, 0);                                         CKERR(r);
     r = env->open(env, ENVDIR, envflags, S_IRWXU+S_IRWXG+S_IRWXO);      CKERR(r);
     r = db_create(&db, env, 0);                                         CKERR(r);

src/tests/inflate2.c

@@ -46,9 +46,10 @@ reopen_em (void)
 static void
 setup(void)
 {
-    system("rm -rf " ENVDIR);
-    toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     int r;
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
+    toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     r = db_env_create(&env, 0);                                         CKERR(r);
     r = env->open(env, ENVDIR, envflags, S_IRWXU+S_IRWXG+S_IRWXO);      CKERR(r);
     r = db_create(&db, env, 0);                                         CKERR(r);

src/tests/isolation-read-committed.c

@@ -8,7 +8,8 @@ const int envflags = DB_INIT_MPOOL|DB_CREATE|DB_THREAD |DB_INIT_LOCK|DB_INIT_LOG
 int test_main (int argc, char * const argv[]) {
     parse_args(argc, argv);
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     r = db_env_create(&env, 0);                                                         CKERR(r);

src/tests/isolation.c

@@ -8,7 +8,8 @@ const int envflags = DB_INIT_MPOOL|DB_CREATE|DB_THREAD |DB_INIT_LOCK|DB_INIT_LOG
 int test_main (int argc, char * const argv[]) {
     parse_args(argc, argv);
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     r = db_env_create(&env, 0);                                                         CKERR(r);

src/tests/keyrange-dupsort-unflat.c

@@ -15,7 +15,8 @@ static void test (void) {
     u_int64_t limit=100;
     u_int64_t ilimit=100;
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       CKERR(r);
     r=db_env_create(&env, 0); CKERR(r);
     // set the cachetable to size 1 so that things won't fit.

src/tests/keyrange-dupsort.c

@@ -15,7 +15,8 @@ static void test (void) {
     u_int64_t limit=10;
     u_int64_t ilimit=10;
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       CKERR(r);
     r=db_env_create(&env, 0); CKERR(r);
     // set the cachetable to size 1 so that things won't fit.

src/tests/keyrange-unflat.c

@@ -16,7 +16,8 @@ static void test (void) {
     u_int64_t permute[limit];
     int r;
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       CKERR(r);
     r=db_env_create(&env, 0); CKERR(r);
     // set the cachetable to size 1 so that things won't fit.

src/tests/keyrange.c

@@ -15,7 +15,8 @@ static void test (void) {
     u_int64_t limit=30000;
     int r;
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       CKERR(r);
     r=db_env_create(&env, 0); CKERR(r);
     env->set_errfile(env, stderr);

src/tests/manyfiles.c

@@ -15,8 +15,9 @@ DB_TXN *txn;
 
 static void
 test_setup (void) {
-    system("rm -rf " ENVDIR);
     int r;
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       CKERR(r);
 
     r=db_env_create(&env, 0); CKERR(r);

src/tests/medium-nested-commit-commit.c

@@ -86,7 +86,8 @@ static void
 test_setup (void) {
     DB_TXN *txn;
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);       CKERR(r);
 
     r=db_env_create(&env, 0); CKERR(r);

src/tests/powerfail.c

@@ -54,9 +54,10 @@ static long shuffle (long l, int i) {
 }
 
 static void do_write (void) {
-    system("rm -rf " ENVDIR);
-    toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     int r;
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
+    toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     r = db_env_create(&env, 0);                                         CKERR(r);
     r = env->open(env, ENVDIR, envflags, S_IRWXU+S_IRWXG+S_IRWXO);      CKERR(r);
 

src/tests/progress.c

@@ -83,10 +83,11 @@ static void
 
 start_env(void) {
     assert(env==NULL);
-    system("rm -rf " ENVDIR);
+    int r;
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
-    int r;
     r = db_env_create(&env, 0);
     CKERR(r);
     r = env->open(env, ENVDIR, DB_INIT_LOCK|DB_INIT_LOG|DB_INIT_MPOOL|DB_INIT_TXN|DB_CREATE|DB_PRIVATE, S_IRWXU+S_IRWXG+S_IRWXO);

src/tests/recover-2483.c

@@ -18,7 +18,8 @@ char *vals[N];
 static void
 do_x1_shutdown (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);                                                     assert(r==0);
 
     r=db_env_create(&env, 0);                                                  assert(r==0);

src/tests/recover-checkpoint-fcreate-fdelete-fcreate.c

@@ -11,7 +11,8 @@ char *nameb="b.db";
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *db;

src/tests/recover-checkpoint-fopen-abort.c

@@ -10,7 +10,8 @@ char *nameb="b.db";
 
 static void run_test (BOOL do_commit, BOOL do_abort) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-checkpoint-fopen-commit.c

@@ -10,7 +10,8 @@ char *nameb="b.db";
 
 static void run_test (BOOL do_commit, BOOL do_abort) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-checkpoint-fopen-dupsort-abort.c

@@ -10,7 +10,8 @@ char *nameb="b.db";
 
 static void run_test (BOOL do_commit, BOOL do_abort) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-checkpoint-fopen-dupsort-commit.c

@@ -10,7 +10,8 @@ char *nameb="b.db";
 
 static void run_test (BOOL do_commit, BOOL do_abort) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-compare-db.c

@@ -21,7 +21,8 @@ static int my_compare(DB *UU(db), const DBT *a, const DBT *b) {
 static void
 do_x1_shutdown (BOOL do_commit, BOOL do_abort) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *dba, *dbb;

src/tests/recover-dbopen-eclose.c

@@ -9,7 +9,8 @@ const int envflags = DB_INIT_MPOOL|DB_CREATE|DB_THREAD |DB_INIT_LOCK|DB_INIT_LOG
 static void run_test (void) {
     int r;
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-delboth-after-checkpoint.c

@@ -10,7 +10,8 @@ static void
 run_test (BOOL do_commit, BOOL do_abort) {
     int r;
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-delboth-checkpoint.c

@@ -10,7 +10,8 @@ static void
 run_test (BOOL do_commit, BOOL do_abort) {
     int r;
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-fassociate-dupsort.c

@@ -11,7 +11,8 @@ char *nameb="b.db";
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *dba, *dbb;

src/tests/recover-fassociate-nodup.c

@@ -11,7 +11,8 @@ char *nameb="b.db";
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *dba, *dbb;

src/tests/recover-fclose-in-checkpoint.c

@@ -15,7 +15,8 @@ static void checkpoint_callback_closeit(void *extra) {
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-fcreate-fclose.c

@@ -11,7 +11,8 @@ char *nameb="b.db";
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *db;

src/tests/recover-fcreate-fdelete.c

@@ -11,7 +11,8 @@ char *nameb="b.db";
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *db;

src/tests/recover-fcreate-xabort.c

@@ -11,7 +11,8 @@ char *nameb="b.db";
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *db;

src/tests/recover-fopen-checkpoint-fclose.c

@@ -10,7 +10,8 @@ char *namea="a.db";
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-fopen-fclose-checkpoint.c

@@ -10,7 +10,8 @@ char *namea="a.db";
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-fopen-fdelete-checkpoint-fcreate.c

@@ -21,7 +21,8 @@ static void put_something(DB_ENV *env, DB *db, char *k, char *v) {
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-lsn-filter-multiple.c

@@ -60,7 +60,8 @@ put_multiple_generate(DB *dest_db, DB *src_db, DBT *dest_key, DBT *dest_val, con
 static void run_test (void) {
     int r;
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-lsn-filter.c

@@ -12,7 +12,8 @@ char *namea="a.db";
 static void run_test (void) {
     int r;
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-missing-dbfile-2.c

@@ -19,7 +19,8 @@ const char *nameb=NAMEB;
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
 

src/tests/recover-missing-dbfile.c

@@ -18,7 +18,8 @@ const char *nameb=NAMEB;
 
 static void run_test (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *dba;

src/tests/recover-put-multiple-fdelete-all.c

@@ -51,7 +51,8 @@ put_multiple_generate(DB *dest_db, DB *src_db, DBT *dest_key, DBT *dest_val, con
 static void run_test (void) {
     int r;
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-put-multiple-fdelete-some.c

@@ -60,7 +60,8 @@ put_multiple_generate(DB *dest_db, DB *src_db, DBT *dest_key, DBT *dest_val, con
 static void run_test (void) {
     int r;
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-split-checkpoint.c

@@ -26,7 +26,8 @@ static void test_checkpoint_callback2(void *extra) {
 
 static void run_test (BOOL do_commit, BOOL do_abort) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env = NULL;

src/tests/recover-straddle-txn-nested.c

@@ -11,7 +11,8 @@ char *namea="a.db";
 static void run_test (void) {
     int r;
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-straddle-txn.c

@@ -11,7 +11,8 @@ char *namea="a.db";
 static void run_test (void) {
     int r;
 
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env;

src/tests/recover-tablelock.c

@@ -10,7 +10,8 @@ char *namea="a.db";
 static void
 do_x1_shutdown (BOOL do_commit, BOOL do_abort) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     r = db_env_create(&env, 0);                                                         CKERR(r);

src/tests/recover-test1.c

@@ -15,7 +15,8 @@ DBT key,data;
 static void
 do_x1_shutdown (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     CKERR(r);
 

src/tests/recover-test2.c

@@ -19,7 +19,8 @@ char *vals[N];
 static void
 do_x1_shutdown (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);                                                     assert(r==0);
 
     r=db_env_create(&env, 0);                                                  assert(r==0);

src/tests/recover-test3.c

@@ -19,7 +19,8 @@ char *vals[N];
 static void
 do_x1_shutdown (void) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     r=toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);                                                     assert(r==0);
 
     r=db_env_create(&env, 0);                                                  assert(r==0);

src/tests/recover-x1-abort.c

@@ -23,7 +23,8 @@ char *nameb="b.db";
 static void
 do_x1_shutdown (BOOL do_commit, BOOL do_abort) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *dba, *dbb;

src/tests/recover-x1-commit.c

@@ -23,7 +23,8 @@ char *nameb="b.db";
 static void
 do_x1_shutdown (BOOL do_commit, BOOL do_abort) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *dba, *dbb;

src/tests/recover-x1-nested-abort.c

@@ -23,7 +23,8 @@ char *nameb="b.db";
 static void
 do_x1_shutdown (BOOL do_commit, BOOL do_abort) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *dba, *dbb;

src/tests/recover-x1-nested-commit.c

@@ -23,7 +23,8 @@ char *nameb="b.db";
 static void
 do_x1_shutdown (BOOL do_commit, BOOL do_abort) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *dba, *dbb;

src/tests/recover-x2-abort.c

@@ -34,7 +34,8 @@ put (DB_TXN *txn, DB *db, char *key, char *data) {
 static void
 do_x2_shutdown (BOOL do_commit) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *dba, *dbb; // Use two DBs so that BDB doesn't get a lock conflict

src/tests/recover-x2-commit.c

@@ -34,7 +34,8 @@ put (DB_TXN *txn, DB *db, char *key, char *data) {
 static void
 do_x2_shutdown (BOOL do_commit) {
     int r;
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
     DB_ENV *env;
     DB *dba, *dbb; // Use two DBs so that BDB doesn't get a lock conflict

src/tests/redirect.c

@@ -47,10 +47,11 @@ static void insert(int index, int64_t i);
 static void
 start_env(void) {
     assert(env==NULL);
-    system("rm -rf " ENVDIR);
+    int r;
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
-    int r;
     r = db_env_create(&env, 0);
     CKERR(r);
     r = env->open(env, ENVDIR, DB_INIT_LOCK|DB_INIT_LOG|DB_INIT_MPOOL|DB_INIT_TXN|DB_CREATE|DB_PRIVATE, S_IRWXU+S_IRWXG+S_IRWXO);

src/tests/root_fifo_1.c

@@ -51,7 +51,8 @@ static void root_fifo_1(int n, int create_outside) {
     int r;
 
     // create the env
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env = null_env;

src/tests/root_fifo_2.c

@@ -47,7 +47,8 @@ static void root_fifo_2(int n, int create_outside) {
     int r;
 
     // create the env
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     DB_ENV *env = null_env;

src/tests/root_fifo_31.c

@@ -81,7 +81,8 @@ static void root_fifo_31(int n) {
     int r;
 
     // create the env
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     // populate

src/tests/root_fifo_32.c

@@ -81,7 +81,8 @@ static void root_fifo_32(int n) {
     int r;
 
     // create the env
-    system("rm -rf " ENVDIR);
+    r = system("rm -rf " ENVDIR);
+    CKERR(r);
     toku_os_mkdir(ENVDIR, S_IRWXU+S_IRWXG+S_IRWXO);
 
     // populate