Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mariadb
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
mariadb
Commits
858171cb
Commit
858171cb
authored
Jan 27, 2005
by
bar@mysql.com
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
item_timefunc.cc:
CAST now always return a well-formed character string.
parent
b7824315
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
5 deletions
+12
-5
sql/item_timefunc.cc
sql/item_timefunc.cc
+12
-5
No files found.
sql/item_timefunc.cc
View file @
858171cb
...
@@ -2115,7 +2115,6 @@ String *Item_char_typecast::val_str(String *str)
...
@@ -2115,7 +2115,6 @@ String *Item_char_typecast::val_str(String *str)
String
*
res
;
String
*
res
;
uint32
length
;
uint32
length
;
#if 0
if
(
!
charset_conversion
)
if
(
!
charset_conversion
)
{
{
if
(
!
(
res
=
args
[
0
]
->
val_str
(
str
)))
if
(
!
(
res
=
args
[
0
]
->
val_str
(
str
)))
...
@@ -2125,7 +2124,6 @@ String *Item_char_typecast::val_str(String *str)
...
@@ -2125,7 +2124,6 @@ String *Item_char_typecast::val_str(String *str)
}
}
}
}
else
else
#endif
{
{
// Convert character set if differ
// Convert character set if differ
uint
dummy_errors
;
uint
dummy_errors
;
...
@@ -2163,9 +2161,18 @@ String *Item_char_typecast::val_str(String *str)
...
@@ -2163,9 +2161,18 @@ String *Item_char_typecast::val_str(String *str)
void
Item_char_typecast
::
fix_length_and_dec
()
void
Item_char_typecast
::
fix_length_and_dec
()
{
{
uint32
char_length
;
uint32
char_length
;
charset_conversion
=
!
my_charset_same
(
args
[
0
]
->
collation
.
collation
,
cast_cs
)
&&
/*
args
[
0
]
->
collation
.
collation
!=
&
my_charset_bin
&&
We always force character set conversion if cast_cs
cast_cs
!=
&
my_charset_bin
;
is a multi-byte character set. It garantees that the
result of CAST is a well-formed string.
For single-byte character sets we allow just to copy
from the argument. A single-byte character sets string
is always well-formed.
*/
charset_conversion
=
(
cast_cs
->
mbmaxlen
>
1
)
||
!
my_charset_same
(
args
[
0
]
->
collation
.
collation
,
cast_cs
)
&&
args
[
0
]
->
collation
.
collation
!=
&
my_charset_bin
&&
cast_cs
!=
&
my_charset_bin
;
collation
.
set
(
cast_cs
,
DERIVATION_IMPLICIT
);
collation
.
set
(
cast_cs
,
DERIVATION_IMPLICIT
);
char_length
=
(
cast_length
>=
0
)
?
cast_length
:
char_length
=
(
cast_length
>=
0
)
?
cast_length
:
args
[
0
]
->
max_length
/
args
[
0
]
->
collation
.
collation
->
mbmaxlen
;
args
[
0
]
->
max_length
/
args
[
0
]
->
collation
.
collation
->
mbmaxlen
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment