Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mariadb
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
mariadb
Commits
88b6d28a
Commit
88b6d28a
authored
Nov 14, 2005
by
ingo@mysql.com
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug#13707 - Server crash with INSERT DELAYED on MyISAM table
After push fix. Must not access new_field if it is NULL.
parent
43bbd352
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
9 deletions
+12
-9
sql/field.cc
sql/field.cc
+12
-9
No files found.
sql/field.cc
View file @
88b6d28a
...
@@ -6194,6 +6194,8 @@ uint Field_string::max_packed_col_length(uint max_length)
...
@@ -6194,6 +6194,8 @@ uint Field_string::max_packed_col_length(uint max_length)
Field
*
Field_string
::
new_field
(
MEM_ROOT
*
root
,
struct
st_table
*
new_table
)
Field
*
Field_string
::
new_field
(
MEM_ROOT
*
root
,
struct
st_table
*
new_table
)
{
{
Field
*
new_field
;
if
(
type
()
!=
MYSQL_TYPE_VAR_STRING
||
table
==
new_table
)
if
(
type
()
!=
MYSQL_TYPE_VAR_STRING
||
table
==
new_table
)
return
Field
::
new_field
(
root
,
new_table
);
return
Field
::
new_field
(
root
,
new_table
);
...
@@ -6202,15 +6204,16 @@ Field *Field_string::new_field(MEM_ROOT *root, struct st_table *new_table)
...
@@ -6202,15 +6204,16 @@ Field *Field_string::new_field(MEM_ROOT *root, struct st_table *new_table)
This is done to ensure that ALTER TABLE will convert old VARCHAR fields
This is done to ensure that ALTER TABLE will convert old VARCHAR fields
to now VARCHAR fields.
to now VARCHAR fields.
*/
*/
Field
*
new_field
=
new
Field_varstring
(
field_length
,
maybe_null
(),
if
(
new_field
=
new
Field_varstring
(
field_length
,
maybe_null
(),
field_name
,
new_table
,
field_name
,
new_table
,
charset
()))
charset
());
{
/*
/*
delayed_insert::get_local_table() needs a ptr copied from old table.
delayed_insert::get_local_table() needs a ptr copied from old table.
This is what other new_field() methods do too. The above method of
This is what other new_field() methods do too. The above method of
Field_varstring sets ptr to NULL.
Field_varstring sets ptr to NULL.
*/
*/
new_field
->
ptr
=
ptr
;
new_field
->
ptr
=
ptr
;
}
return
new_field
;
return
new_field
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment