Commit 8a0be8a5 authored by Marko Mäkelä's avatar Marko Mäkelä

Bug#13116045 Compilation failure using GCC 4.6.1 in btr/btr0cur.c

btr_record_not_null_field_in_rec(): Remove the parameter rec.
Use rec_offs_nth_sql_null() instead of rec_get_nth_field().

rb:788 approved by Jimmy Yang
parent 14dff92d
...@@ -2864,7 +2864,6 @@ static ...@@ -2864,7 +2864,6 @@ static
void void
btr_record_not_null_field_in_rec( btr_record_not_null_field_in_rec(
/*=============================*/ /*=============================*/
rec_t* rec, /* in: physical record */
ulint n_unique, /* in: dict_index_get_n_unique(index), ulint n_unique, /* in: dict_index_get_n_unique(index),
number of columns uniquely determine number of columns uniquely determine
an index entry */ an index entry */
...@@ -2883,17 +2882,11 @@ btr_record_not_null_field_in_rec( ...@@ -2883,17 +2882,11 @@ btr_record_not_null_field_in_rec(
} }
for (i = 0; i < n_unique; i++) { for (i = 0; i < n_unique; i++) {
ulint rec_len; if (rec_offs_nth_sql_null(offsets, i)) {
byte* field;
field = rec_get_nth_field(rec, offsets, i, &rec_len);
if (rec_len != UNIV_SQL_NULL) {
n_not_null[i]++;
} else {
/* Break if we hit the first NULL value */
break; break;
} }
n_not_null[i]++;
} }
} }
...@@ -2988,7 +2981,7 @@ btr_estimate_number_of_different_key_vals( ...@@ -2988,7 +2981,7 @@ btr_estimate_number_of_different_key_vals(
if (n_not_null) { if (n_not_null) {
btr_record_not_null_field_in_rec( btr_record_not_null_field_in_rec(
rec, n_cols, offsets_rec, n_not_null); n_cols, offsets_rec, n_not_null);
} }
} }
...@@ -3023,8 +3016,7 @@ btr_estimate_number_of_different_key_vals( ...@@ -3023,8 +3016,7 @@ btr_estimate_number_of_different_key_vals(
if (n_not_null) { if (n_not_null) {
btr_record_not_null_field_in_rec( btr_record_not_null_field_in_rec(
next_rec, n_cols, offsets_next_rec, n_cols, offsets_next_rec, n_not_null);
n_not_null);
} }
total_external_size total_external_size
......
2011-10-20 The InnoDB Team
* btr/brt0cur.c:
Fix Bug#13116045 Compilation failure using GCC 4.6.1 in btr/btr0cur.c
2011-10-12 The InnoDB Team 2011-10-12 The InnoDB Team
* btr/btr0cur.c, btr/btr0sea.c, buf/buf0buf.c, buf/buf0lru.c, * btr/btr0cur.c, btr/btr0sea.c, buf/buf0buf.c, buf/buf0lru.c,
......
...@@ -3261,7 +3261,6 @@ static ...@@ -3261,7 +3261,6 @@ static
void void
btr_record_not_null_field_in_rec( btr_record_not_null_field_in_rec(
/*=============================*/ /*=============================*/
rec_t* rec, /*!< in: physical record */
ulint n_unique, /*!< in: dict_index_get_n_unique(index), ulint n_unique, /*!< in: dict_index_get_n_unique(index),
number of columns uniquely determine number of columns uniquely determine
an index entry */ an index entry */
...@@ -3280,17 +3279,11 @@ btr_record_not_null_field_in_rec( ...@@ -3280,17 +3279,11 @@ btr_record_not_null_field_in_rec(
} }
for (i = 0; i < n_unique; i++) { for (i = 0; i < n_unique; i++) {
ulint rec_len; if (rec_offs_nth_sql_null(offsets, i)) {
byte* field;
field = rec_get_nth_field(rec, offsets, i, &rec_len);
if (rec_len != UNIV_SQL_NULL) {
n_not_null[i]++;
} else {
/* Break if we hit the first NULL value */
break; break;
} }
n_not_null[i]++;
} }
} }
...@@ -3398,7 +3391,7 @@ btr_estimate_number_of_different_key_vals( ...@@ -3398,7 +3391,7 @@ btr_estimate_number_of_different_key_vals(
if (n_not_null) { if (n_not_null) {
btr_record_not_null_field_in_rec( btr_record_not_null_field_in_rec(
rec, n_cols, offsets_rec, n_not_null); n_cols, offsets_rec, n_not_null);
} }
} }
...@@ -3433,8 +3426,7 @@ btr_estimate_number_of_different_key_vals( ...@@ -3433,8 +3426,7 @@ btr_estimate_number_of_different_key_vals(
if (n_not_null) { if (n_not_null) {
btr_record_not_null_field_in_rec( btr_record_not_null_field_in_rec(
next_rec, n_cols, offsets_next_rec, n_cols, offsets_next_rec, n_not_null);
n_not_null);
} }
total_external_size total_external_size
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment