Commit 8fc37244 authored by Sergei Golubchik's avatar Sergei Golubchik

MDEV-5958 Inconsitent handling of invalid arguments for mysqld_safe

issue an error for unrecognized options in the [mysqld_safe] section of my.cnf
but don't abort the script
parent 1907bf04
...@@ -190,16 +190,6 @@ shell_quote_string() { ...@@ -190,16 +190,6 @@ shell_quote_string() {
} }
parse_arguments() { parse_arguments() {
# We only need to pass arguments through to the server if we don't
# handle them here. So, we collect unrecognized options (passed on
# the command line) into the args variable.
pick_args=
if test "$1" = PICK-ARGS-FROM-ARGV
then
pick_args=1
shift
fi
for arg do for arg do
# the parameter after "=", or the whole $arg if no match # the parameter after "=", or the whole $arg if no match
val=`echo "$arg" | sed -e 's;^--[^=]*=;;'` val=`echo "$arg" | sed -e 's;^--[^=]*=;;'`
...@@ -256,11 +246,10 @@ parse_arguments() { ...@@ -256,11 +246,10 @@ parse_arguments() {
--help) usage ;; --help) usage ;;
*) *)
if test -n "$pick_args" case "$unrecognized_handling" in
then collect) append_arg_to_args "$arg" ;;
append_arg_to_args "$arg" complain) log_error "unknown option '$arg'" ;;
fi esac
;;
esac esac
done done
} }
...@@ -517,8 +506,16 @@ then ...@@ -517,8 +506,16 @@ then
SET_USER=0 SET_USER=0
fi fi
# If arguments come from [mysqld_safe] section of my.cnf
# we complain about unrecognized options
unrecognized_handling=complain
parse_arguments `$print_defaults $defaults --loose-verbose mysqld_safe safe_mysqld mariadb_safe` parse_arguments `$print_defaults $defaults --loose-verbose mysqld_safe safe_mysqld mariadb_safe`
parse_arguments PICK-ARGS-FROM-ARGV "$@"
# We only need to pass arguments through to the server if we don't
# handle them here. So, we collect unrecognized options (passed on
# the command line) into the args variable.
unrecognized_handling=collect
parse_arguments "$@"
# #
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment