Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mariadb
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
mariadb
Commits
9fbdd4e0
Commit
9fbdd4e0
authored
Apr 18, 2005
by
sergefp@mysql.com
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix for BUG#9298: Make int->string conversion sign-aware in Protocol_simple::store_long
parent
39f412d3
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
17 additions
and
1 deletion
+17
-1
mysql-test/r/group_by.result
mysql-test/r/group_by.result
+9
-0
mysql-test/t/group_by.test
mysql-test/t/group_by.test
+7
-0
sql/protocol.cc
sql/protocol.cc
+1
-1
No files found.
mysql-test/r/group_by.result
View file @
9fbdd4e0
...
...
@@ -702,3 +702,12 @@ c
val-74
val-98
drop table t1,t2;
create table t1 (b int4 unsigned not null);
insert into t1 values(3000000000);
select * from t1;
b
3000000000
select min(b) from t1;
min(b)
3000000000
drop table t1;
mysql-test/t/group_by.test
View file @
9fbdd4e0
...
...
@@ -515,3 +515,10 @@ explain select c from t2 where a = 2 and b = 'val-2' group by c;
select
c
from
t2
where
a
=
2
and
b
=
'val-2'
group
by
c
;
drop
table
t1
,
t2
;
# Test for BUG#9298 "Wrong handling of int4 unsigned columns in GROUP functions"
# (the actual problem was with protocol code, not GROUP BY)
create
table
t1
(
b
int4
unsigned
not
null
);
insert
into
t1
values
(
3000000000
);
select
*
from
t1
;
select
min
(
b
)
from
t1
;
drop
table
t1
;
sql/protocol.cc
View file @
9fbdd4e0
...
...
@@ -810,7 +810,7 @@ bool Protocol_simple::store_long(longlong from)
#endif
char
buff
[
20
];
return
net_store_data
((
char
*
)
buff
,
(
uint
)
(
int10_to_str
((
int
)
from
,
buff
,
-
10
)
-
buff
));
(
uint
)
(
int10_to_str
((
int
)
from
,
buff
,
(
from
<
0
)
?-
10
:
10
)
-
buff
));
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment