Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mariadb
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
mariadb
Commits
d2f7623d
Commit
d2f7623d
authored
Jun 28, 2005
by
unknown
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed comments.
sql/opt_range.cc: comment fixed. sql/sp_head.cc: An obsolete comment removed.
parent
79c1be9e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
8 deletions
+1
-8
sql/opt_range.cc
sql/opt_range.cc
+1
-1
sql/sp_head.cc
sql/sp_head.cc
+0
-7
No files found.
sql/opt_range.cc
View file @
d2f7623d
...
...
@@ -3702,7 +3702,7 @@ get_mm_leaf(PARAM *param, COND *conf_func, Field *field, KEY_PART *key_part,
/*
We need to restore the runtime mem_root of the thread in this
function bec
ua
se it evaluates the value of its argument, while
function bec
au
se it evaluates the value of its argument, while
the argument can be any, e.g. a subselect. The subselect
items, in turn, assume that all the memory allocated during
the evaluation has the same life span as the item itself.
...
...
sql/sp_head.cc
View file @
d2f7623d
...
...
@@ -1474,13 +1474,6 @@ sp_lex_keeper::reset_lex_and_exec_core(THD *thd, uint *nextp,
they want to store some value in local variable, pass return value and
etc... So their life time should be longer than one instruction.
Probably we can call destructors for most of them then we are leaving
routine. But this won't help much as they are allocated in main query
MEM_ROOT anyway. So they all go to global thd->free_list.
May be we can use some other MEM_ROOT for this purprose ???
What else should we do for cleanup ?
cleanup_items() is called in sp_head::execute()
*/
return
res
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment