Commit da04109d authored by sergefp@mysql.com's avatar sergefp@mysql.com

BUG#30385: Server crash when deleting with ORDER BY and LIMIT

in get_index_for_order(), don't walk over the end of the index key parts
when matching index description and needed ordering.
parent ac5309cb
...@@ -193,4 +193,15 @@ select @a; ...@@ -193,4 +193,15 @@ select @a;
@a @a
1 1
drop table t1; drop table t1;
CREATE TABLE t1 (
`date` date ,
`time` time ,
`seq` int(10) unsigned NOT NULL auto_increment,
PRIMARY KEY (`seq`),
KEY `seq` (`seq`),
KEY `time` (`time`),
KEY `date` (`date`)
);
DELETE FROM t1 ORDER BY date ASC, time ASC LIMIT 1;
drop table t1;
End of 4.1 tests End of 4.1 tests
...@@ -184,4 +184,17 @@ delete from t1 where (@a:= f1) order by f1 limit 1; ...@@ -184,4 +184,17 @@ delete from t1 where (@a:= f1) order by f1 limit 1;
select @a; select @a;
drop table t1; drop table t1;
# BUG#30385 "Server crash when deleting with order by and limit"
CREATE TABLE t1 (
`date` date ,
`time` time ,
`seq` int(10) unsigned NOT NULL auto_increment,
PRIMARY KEY (`seq`),
KEY `seq` (`seq`),
KEY `time` (`time`),
KEY `date` (`date`)
);
DELETE FROM t1 ORDER BY date ASC, time ASC LIMIT 1;
drop table t1;
--echo End of 4.1 tests --echo End of 4.1 tests
...@@ -825,6 +825,7 @@ uint get_index_for_order(TABLE *table, ORDER *order, ha_rows limit) ...@@ -825,6 +825,7 @@ uint get_index_for_order(TABLE *table, ORDER *order, ha_rows limit)
if (!(table->keys_in_use_for_query.is_set(idx))) if (!(table->keys_in_use_for_query.is_set(idx)))
continue; continue;
KEY_PART_INFO *keyinfo= table->key_info[idx].key_part; KEY_PART_INFO *keyinfo= table->key_info[idx].key_part;
uint n_parts= table->key_info[idx].key_parts;
uint partno= 0; uint partno= 0;
/* /*
...@@ -834,7 +835,7 @@ uint get_index_for_order(TABLE *table, ORDER *order, ha_rows limit) ...@@ -834,7 +835,7 @@ uint get_index_for_order(TABLE *table, ORDER *order, ha_rows limit)
*/ */
if (!(table->file->index_flags(idx, 0, 1) & HA_READ_ORDER)) if (!(table->file->index_flags(idx, 0, 1) & HA_READ_ORDER))
continue; continue;
for (ord= order; ord; ord= ord->next, partno++) for (ord= order; ord && partno < n_parts; ord= ord->next, partno++)
{ {
Item *item= order->item[0]; Item *item= order->item[0];
if (!(item->type() == Item::FIELD_ITEM && if (!(item->type() == Item::FIELD_ITEM &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment