- 18 Mar, 2008 1 commit
-
-
unknown authored
Each time the server reloads privileges containing table grants, the system will allocate too much memory than needed because of badly chosen growth prediction in the underlying dynamic arrays. This patch introduces a new signature to the hash container initializer which enables a much more pessimistic approach in favour for more efficient memory useage. This patch was supplied by Google Inc. include/hash.h: * New signature for _hash_init. * Defined new function hash_init2 which takes growth_size argument. mysys/hash.c: * New signature for _hash_init. sql/sql_acl.cc: * Changed hash_init signature so that it takes a 'growth_size' smaller than the default. Each time a GRANT_TABLE is allocated a pre-allocated dynamic array is instantiated. A large growth size can result in too many unused hash-entries per table-entry and thus be a waste of free memory.
-
- 10 Mar, 2008 1 commit
-
-
unknown authored
into adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime sql/sql_cache.cc: Auto merged mysql-test/r/query_cache.result: Manual merge mysql-test/t/query_cache.test: Manual merge
-
- 06 Mar, 2008 1 commit
-
-
unknown authored
The initial value of free memory blocks in 0. When the query cache is enabled a new memory block gets allocated and is assigned number 1. The free memory block is later split each time query cache memory is allocated for new blocks. This means that the free memory block counter won't be reduced to zero when the number of allocated blocks are zero, but rather one. To avoid confusion this patch changes this behavior so that the free memory block counter is reset to zero when the query cache is disabled. Note that when the query cache is enabled and resized the free memory block counter was still calculated correctly. mysql-test/r/query_cache.result: test case mysql-test/t/query_cache.test: test case sql/sql_cache.cc: Restore the memory block count to 0 for consistency.
-
- 05 Mar, 2008 1 commit
-
-
unknown authored
storage/ndb/src/kernel/blocks/tsman.cpp: Fix build on Tiger and Leopard, incl. 10.5.2 This is already in vm/ndb_malloc_impl.cpp
-
- 04 Mar, 2008 5 commits
-
-
unknown authored
into mysql.com:/Users/davi/mysql/mysql-5.1-runtime mysql-test/t/mysql_client_test.test: Auto merged
-
unknown authored
mysql-test/t/mysql_client_test.test: Rename mysql_client_test output file to mysql_client_test.out.log
-
unknown authored
into mysql.com:/Users/davi/mysql/mysql-5.1-runtime
-
unknown authored
into mysql.com:/Users/davi/mysql/mysql-5.1-runtime mysql-test/t/mysql_client_test.test: Null merge
-
unknown authored
It's impossible to determine which test inside mysql_client_test failed if the log file is overwritten by mysqltest when dumping the test case results. Redirect mysql_client_test output to a separate file. mysql-test/t/mysql_client_test.test: Redirect mysql_client_test output to a separate log file so it doesn't get overwritten by mysqltest.
-
- 03 Mar, 2008 1 commit
-
-
unknown authored
into quad.:/mnt/raid/alik/MySQL/devel/5.1-rt
-
- 29 Feb, 2008 2 commits
-
-
unknown authored
into mysql.com:/Users/davi/mysql/mysql-5.1-runtime
-
unknown authored
READ_ONLY token was accidentally placed into wrong place ('ident' rule). The proper place is in the 'keyword_sp' rule. The manual should be re-generated after this patch, because the manual depends on the 'keyword_sp' rule. sql/sql_yacc.yy: Move READ_ONLY token to the 'keyword_sp' rule.
-
- 28 Feb, 2008 6 commits
-
-
unknown authored
into buzz.(none):/home/davi/mysql-5.1-runtime mysql-test/r/ps.result: Auto merged mysql-test/t/limit.test: Auto merged mysql-test/t/ps.test: Auto merged sql/item.h: Auto merged sql/item_func.cc: Auto merged sql/sql_class.h: Auto merged sql/item.cc: Auto merged mysql-test/suite/rpl/r/rpl_user_variables.result: Manual merge mysql-test/suite/rpl/t/rpl_user_variables.test: Manual merge sql/sql_yacc.yy: Manual merge
-
unknown authored
must match the order which they were declared in the class definition. sql/item.cc: Fix initialization order, parameter was the last one declared.
-
unknown authored
Rename client_last_error to last_error and client_last_errno to last_errno to not break connectors which use the internal net structure for error handling. include/mysql_com.h: Rename client_last_error to last_error, client_last_errno to last_errno. include/mysql_h.ic: Rename client_last_error to last_error, client_last_errno to last_errno. libmysql/libmysql.c: Rename client_last_error to last_error, client_last_errno to last_errno. libmysql/manager.c: Rename client_last_error to last_error, client_last_errno to last_errno. libmysqld/lib_sql.cc: Rename client_last_error to last_error, client_last_errno to last_errno. libmysqld/libmysqld.c: Rename client_last_error to last_error, client_last_errno to last_errno. server-tools/instance-manager/mysql_connection.cc: Rename client_last_error to last_error, client_last_errno to last_errno. sql/log_event.cc: Rename client_last_error to last_error, client_last_errno to last_errno. sql-common/client.c: Rename client_last_error to last_error, client_last_errno to last_errno. sql/log_event_old.cc: Rename client_last_error to last_error, client_last_errno to last_errno. sql/net_serv.cc: Rename client_last_error to last_error, client_last_errno to last_errno. sql/repl_failsafe.cc: Rename client_last_error to last_error, client_last_errno to last_errno.
-
unknown authored
The problem is that passing anything other than a integer to a limit clause in a prepared statement would fail. This limitation was introduced to avoid replication problems (e.g: replicating the statement with a string argument would cause a parse failure in the slave). The solution is to convert arguments to the limit clause to a integer value and use this converted value when persisting the query to the log. mysql-test/r/limit.result: Update test case result. mysql-test/r/ps.result: Add test case result for Bug#33851 mysql-test/r/rpl_user_variables.result: Test case result for replication of prepared statement with limit clause. mysql-test/t/limit.test: Test parameters to limit clause. mysql-test/t/ps.test: Add test case for Bug#33851 mysql-test/t/rpl_user_variables.test: Test replication of a parameter which value is converted. sql/item.cc: Convert value to integer if it's a parameter to a limit clause. sql/item.h: Flag signal that item is a parameter to a limit clause. sql/item_func.cc: Const member functions, object is not mutated. sql/sql_class.h: Const member functions, object is not mutated. sql/sql_yacc.yy: Flag that item is a parameter to a limit clause.
-
unknown authored
sporadically. mysql-test/r/sp_notembedded.result: Disable test case. mysql-test/t/sp_notembedded.test: Disable test case.
-
unknown authored
(show_check.test fails sporadically). Fix test case for Bug#12183 to make it stable. mysql-test/r/show_check.result: Fix result file. mysql-test/t/show_check.test: Make test case for Bug#12183 stable.
-
- 27 Feb, 2008 7 commits
-
-
unknown authored
into mysql.com:/Users/davi/mysql/mysql-5.1-runtime
-
unknown authored
to reach the desired value. mysql-test/r/flush_read_lock_kill.result: Update test case result. mysql-test/t/flush_read_lock_kill.test: Wait for the debug synchronization point to be reached.
-
unknown authored
into quad.:/mnt/raid/alik/MySQL/devel/5.1-rt-build tests/mysql_client_test.c: Manually merged.
-
unknown authored
-
unknown authored
-
unknown authored
Disable the test case. tests/mysql_client_test.c: Disable test case.
-
unknown authored
-
- 26 Feb, 2008 13 commits
-
-
unknown authored
into quad.:/mnt/raid/alik/MySQL/devel/5.1-rt mysql-test/r/view.result: Auto merged
-
unknown authored
into quad.:/mnt/raid/alik/MySQL/devel/5.1-rt-merged client/mysqltest.c: Auto merged mysql-test/r/view.result: Auto merged sql/ha_ndbcluster.cc: Auto merged sql/ha_ndbcluster_binlog.cc: Auto merged sql/handler.cc: Auto merged sql/log_event.cc: Auto merged sql/mysql_priv.h: Auto merged sql/mysqld.cc: Auto merged sql/set_var.cc: Auto merged sql/sql_class.cc: Auto merged sql/sql_connect.cc: Auto merged sql/sql_parse.cc: Auto merged tests/mysql_client_test.c: Auto merged mysql-test/suite/rpl_ndb/t/disabled.def: Manually merged. mysql-test/t/disabled.def: Manually merged.
-
unknown authored
into quad.:/mnt/raid/alik/MySQL/devel/5.0-rt-merged mysql-test/r/view.result: Auto merged
-
unknown authored
into mysql.com:/Users/davi/mysql/mysql-5.1-runtime
-
unknown authored
tests/mysql_client_test.c: Fix the remaining memory leaks.
-
unknown authored
Bug#34678 @@debug variable's incremental mode The problem is that the per-thread debugging settings stack wasn't being deallocated before the thread termination, leaking the stack memory. The chosen solution is to push a new state if the current is set to the initial settings and pop it (free) once the thread finishes. dbug/dbug.c: Move dbug parser out of _db_set_ to a separate function and make _db_set_ push a new stack if the corrent one is set to the initial settings. dbug/user.r: Update DBUG_SET description. mysql-test/t/disabled.def: Re-enable test case which triggered the leak. mysys/my_thr_init.c: Pop a pushed state, nop if stack is empty. sql/set_var.cc: Handle incremental debug settings. mysql-test/r/variables_debug.result: Add new test case result for Bug#34678 mysql-test/t/variables_debug.test: Add new test case for Bug#34678
-
unknown authored
tests/mysql_client_test.c: Fix a memory leak. Run the test for Bug#28386 only if logging to tables is enabled.
-
unknown authored
into dipika.(none):/opt/local/work/mysql-5.1-runtime
-
unknown authored
not try to push an error into the error stack as it will be ignored anyway.
-
unknown authored
into mysql.com:/Users/davi/mysql/mysql-5.1-runtime tests/mysql_client_test.c: Auto merged
-
unknown authored
into dipika.(none):/opt/local/work/mysql-5.1-runtime tests/mysql_client_test.c: Manual merge.
-
unknown authored
-
unknown authored
(Test for Bug#32265) tests/mysql_client_test.c: Use an API instead of looking into stmt internals to fetch fields.
-
- 25 Feb, 2008 1 commit
-
-
unknown authored
The problem is that the commands COM_STMT_CLOSE, COM_STMT_RESET, COM_STMT_SEND_LONG_DATA weren't being logged to the general log. The solution is to log the general log the aforementioned commands. mysql-test/t/mysql_client_test-master.opt: Also log to table. sql/sql_prepare.cc: Log COM_STMT_CLOSE, COM_STMT_RESET and COM_STMT_SEND_LONG_DATA. tests/mysql_client_test.c: Add test case for Bug#28386
-
- 23 Feb, 2008 1 commit
-
-
unknown authored
into ramayana.hindu.god:/home/tsmith/m/bk/build/51
-