1. 10 Mar, 2006 3 commits
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.1 · 00852307
      unknown authored
      into  mysql.com:/home/mydev/mysql-4.1-bug14980
      
      
      00852307
    • unknown's avatar
      Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX · fbe17c2a
      unknown authored
      For "count(*) while index_column = value" an index read
      is done. It consists of an index scan and retrieval of
      each key.
      
      For efficiency reasons the index scan stores the key in
      the special buffer 'lastkey2' once only. At the first 
      iteration it notes this fact with the flag 
      HA_STATE_RNEXT_SAME in 'info->update'.
      
      For efficiency reasons, the key retrieval for blobs
      does not allocate a new buffer, but uses 'lastkey2'...
      
      Now I clear the HA_STATE_RNEXT_SAME flag whenever the 
      buffer has been polluted. In this case, the index scan
      copies the key value again (and sets the flag again).
      
      
      include/my_base.h:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Changed the comment for HA_STATE_RNEXT_SAME as a warning
        for future uses.
      myisam/mi_delete.c:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Removing the flag HA_STATE_RNEXT_SAME from info->update
        if info->lastkey2 was reused for another purpose than
        index scanning.
      myisam/mi_key.c:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Removing the flag HA_STATE_RNEXT_SAME from info->update
        if info->lastkey2 was reused for another purpose than
        index scanning.
      myisam/mi_rnext_same.c:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Removed trailing space and fixed a comment.
      myisam/mi_unique.c:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Removing the flag HA_STATE_RNEXT_SAME from info->update
        if info->lastkey2 was reused for another purpose than
        index scanning.
      myisam/mi_update.c:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Removing the flag HA_STATE_RNEXT_SAME from info->update
        if info->lastkey2 was reused for another purpose than
        index scanning.
      myisam/mi_write.c:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Removing the flag HA_STATE_RNEXT_SAME from info->update
        if info->lastkey2 was reused for another purpose than
        index scanning.
      mysql-test/r/myisam.result:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Added test result.
      mysql-test/t/myisam.test:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Added test.
      fbe17c2a
    • unknown's avatar
      Merge mysql.com:/M41/comment-4.1 into mysql.com:/M41/mysql-4.1 · bf8fdd38
      unknown authored
      
      scripts/make_binary_distribution.sh:
        Auto merged
      bf8fdd38
  2. 08 Mar, 2006 4 commits
    • unknown's avatar
      mysql-test-run.pl, mtr_cases.pl · a3208c0f
      unknown authored
        - Back porting of some changes in later releases
        - Corrected valgrind support
        - Removed work around for TZ needed in VisualStudio 6
        - Don't restart master to add special settings from "<testcase>-master.opt",
          if same settngs as running master, feature request in bug#12433
        - With --reorder, keep tests with same *-master.opt content together,
          to save even more master restarts
      
      
      mysql-test/lib/mtr_misc.pl:
        Added functions to compare lists of options
      mysql-test/lib/mtr_cases.pl:
        Removed special code for Windows as in VC6 we unset
        TZ to avoid library bug
      mysql-test/mysql-test-run.pl:
        Handle pseudo option --timezone=<spec> that sets TZ
      a3208c0f
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1 · 3c83b827
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/bug17137/my41-bug17137
      
      
      3c83b827
    • unknown's avatar
      Bug#17137 Running "truncate table" on temporary table leaves the table open on a slave · f491db21
      unknown authored
       - Decrease "slave_open_temp_tables" during reopen of truncated table.
       - Add test "rpl_trunc_temp" 
      
      
      sql/sql_delete.cc:
        Decrease "slave_open_temp_tables" after temporary table has been closed, it will be
        increased again when the temp table is reopened after it's been truncated.
      mysql-test/r/rpl_trunc_temp.result:
        New BitKeeper file ``mysql-test/r/rpl_trunc_temp.result''
      mysql-test/t/rpl_trunc_temp.test:
        New BitKeeper file ``mysql-test/t/rpl_trunc_temp.test''
      f491db21
    • unknown's avatar
      mysql-test-run.pl: · cf11f78a
      unknown authored
        Allow space in base directory path, bug#15736
      
      
      mysql-test/mysql-test-run.pl:
        Allow space in base directory path, bug#15736
      cf11f78a
  3. 06 Mar, 2006 4 commits
  4. 04 Mar, 2006 3 commits
  5. 03 Mar, 2006 3 commits
  6. 02 Mar, 2006 6 commits
  7. 01 Mar, 2006 11 commits
  8. 28 Feb, 2006 4 commits
    • unknown's avatar
      mysqltest.test: · bf912125
      unknown authored
        Add real_sleep tests.
      
      
      mysql-test/t/mysqltest.test:
        Add real_sleep tests.
      bf912125
    • unknown's avatar
      mysql-test-run.sh: · 8d5f0fcd
      unknown authored
        Fix URLs.
      README:
        Fix URL.
      mysqltest.result:
        Update test result for real_sleep error message.
      mysqltest.c:
        Fix do_sleep() to print correct command name for real_sleep.
      
      
      client/mysqltest.c:
        Fix do_sleep() to print correct command name for real_sleep.
      mysql-test/r/mysqltest.result:
        Update test result for real_sleep error message.
      mysql-test/README:
        Fix URL.
      mysql-test/mysql-test-run.sh:
        Fix URLs.
      8d5f0fcd
    • unknown's avatar
      mysqltest.c: · 9099fb2d
      unknown authored
        Correct/clarify comments.
      
      
      client/mysqltest.c:
        Correct/clarify comments.
      9099fb2d
    • unknown's avatar
      mysqltest.c: · 46c82ab1
      unknown authored
        Fix typos.
      
      
      client/mysqltest.c:
        Fix typos.
      46c82ab1
  9. 23 Feb, 2006 1 commit
    • unknown's avatar
      Remove 'delayed' to make the test deterministic (already · ea9ea952
      unknown authored
      fixed in 5.0).
      A post-review fix (Bug#13134)
      
      
      mysql-test/r/heap.result:
        Remove 'delayed' to make the test deterministic.
      mysql-test/r/ps.result:
        Remove an unneeded drop table (test case for Bug#13134)
      mysql-test/t/heap.test:
        Remove 'delayed' to make the test deterministic.
      mysql-test/t/ps.test:
        A post-review fix (Bug#13134)
      ea9ea952
  10. 21 Feb, 2006 1 commit
    • unknown's avatar
      A fix and a test case for Bug#13134 "Length of VARCHAR() utf8 · 9cf3f255
      unknown authored
      column is increasing when table is recreated with PS/SP":
      make use of create_field::char_length more consistent in the code.
      Reinit create_field::length from create_field::char_length
      for every execution of a prepared statement (actually fixes the 
      bug).
      
      
      mysql-test/r/ps.result:
        Test results fixed (Bug#13134)
      mysql-test/t/ps.test:
        A test case for Bug#13134 "Length of VARCHAR() utf8 column is 
        increasing when table is recreated with PS/SP"
      sql/field.cc:
        Move initialization of create_field::char_length to the constructor
        of create_field.
      sql/field.h:
        Rename chars_length to char_length (to be consistent with
        how this term is used throughout the rest of the code).
      sql/sql_parse.cc:
        Initialize char_length in add_field_to_list. This function
        effectively works as another create_field constructor.
      sql/sql_table.cc:
        Reinit length from char_length for every field in 
        mysql_prepare_table. This is not needed if we're executing
        a statement for the first time, however, at subsequent executions
        length contains the number of bytes, not characters (as it's expected 
        to).
      9cf3f255