1. 01 Apr, 2004 1 commit
    • unknown's avatar
      InnoDB cleanup: fixing buffer overflows and quoting of quotes · 025ddfea
      unknown authored
      
      innobase/dict/dict0crea.c:
        Remove unneeded prototypes for static functions
        Remove unused parameters from some functions
        Replace some assertions with compile-time checks
        dict_create_add_foreigns_to_dictionary():
        allocate space dynamically for the SQL, and quote quotes
      innobase/dict/dict0dict.c:
        Remove unnecessary prototypes for static functions
        dict_tables_have_same_db(): Remove length limitation
        dict_remove_db_name(): Use strchr()
        dict_get_db_name_len(): Use strchr()
        Replace mem_heap_alloc()+strlen()+memcpy() with mem_heap_strdup()
        Remove unnecessary strlen() calls
        Allocate space dynamically for generated strings
        dict_scan_id(): allow quotes within quoted strings
      innobase/dict/dict0load.c:
        Remove unnecessary strlen() calls
        Replace mem_heap_alloc()+strlen()+memcpy() with mem_heap_strdup()
      innobase/dict/dict0mem.c:
        Replace mem_heap_alloc()+strlen()+memcpy() with mem_heap_strdup()
      innobase/eval/eval0eval.c:
        Make TO_CHAR() work with any machine word width
      innobase/fil/fil0fil.c:
        Replace mem_alloc()+strlen()+strcpy() with mem_strdup()
      innobase/ibuf/ibuf0ibuf.c:
        Make some global variables static
        Add #ifdef UNIV_IBUF_DEBUG around debug statements
      innobase/include/data0data.h:
        Add #ifdef UNIV_DEBUG around dtuple_validate()
      innobase/include/data0data.ic:
        Replace = with == in ut_ad(tuple->magic_n == DATA_TUPLE_MAGIC_N)
      innobase/include/dict0dict.h:
        Add const qualifiers
      innobase/include/lock0lock.h:
        Add UL suffixes to unsigned long masks
      innobase/include/log0log.h:
        Remove unused parameter "type" of log_group_write_buf()
      innobase/include/mem0mem.h:
        Add mem_strdup(), mem_strdupl(), mem_strdupq(), mem_heap_strdup(),
        and mem_heap_strdupl()
      innobase/include/mem0mem.ic:
        Add mem_strdup(), mem_strdupl(), mem_strdupq(), mem_heap_strdup(),
        and mem_heap_strdupl()
      innobase/include/row0uins.h:
        Remove unused parameter "thr" of row_undo_ins()
      innobase/include/row0undo.h:
        Remvoe unused parameter "thr" of row_undo_search_clust_to_pcur()
      innobase/include/ut0byte.h:
        Add const qualifier to ut_cpy_in_lower_case()
        Remove parameter "len" of ut_cmp_in_lower_case()
      innobase/include/ut0mem.h:
        Add ut_strlenq(), ut_strcpyq() and ut_memcpyq()
      innobase/include/ut0mem.ic:
        Add ut_strlenq()
      innobase/include/ut0ut.h:
        Declare ut_sprintf() as a printf-style function
      innobase/lock/lock0lock.c:
        lock_clust_rec_modify_check_and_lock(): Remove unused variable "trx"
      innobase/log/log0log.c:
        Remove unused parameters
      innobase/log/log0recv.c:
        Remove parameter "type" from log_group_write_buf()
      innobase/mem/mem0mem.c:
        Simplify the initialization of block->init_block
      innobase/mtr/mtr0log.c:
        Add a debug assertion to mlog_parse_initial_log_record()
      innobase/page/page0cur.c:
        Add debug assertion to page_cur_insert_rec_write_log()
        Remove hard-coded buffer size in page_cur_parse_insert_rec()
      innobase/page/page0page.c:
        Remove unneeded variable rec
      innobase/pars/pars0opt.c:
        Correct a potential buffer overflow
      innobase/pars/pars0pars.c:
        Replace mem_heap_alloc()+strlen()+memcpy() with mem_heap_strdup()
      innobase/row/row0ins.c:
        Replace parameter "thr" with "trx" in row_ins_foreign_report_add_err()
        Remove unnecessary strlen() call
        Use strchr()
      innobase/row/row0mysql.c:
        Add row_mysql_is_recovered_tmp_table()
        Add row_mysql_is_system_table()
        Compare reserved table names with exact match
        Use strstr() and strchr() and mem_strdupl()
        Compute space needed for generated SQL, and allocate it dynamically
      innobase/row/row0purge.c:
        Remove unused parameters "thr"
      innobase/row/row0row.c:
        Simplify row_get_clust_rec()
      innobase/row/row0uins.c:
        Remove unused parameters "thr"
      innobase/row/row0umod.c:
        Remove unused variable "index"
        row_undo_mod_del_unmark_sec_and_undo_update():
         Remove parameter "node" and variable "rec"
        Remove unused parameters "thr"
      innobase/row/row0undo.c:
        Remove unused parameters "thr"
      innobase/srv/srv0srv.c:
        Replace UT_NOT_USED() with __attribute__((unused))
      innobase/srv/srv0start.c:
        Remove unnecessary strlen() calls
        Remove unused parameter "create_new_db" of open_or_create_log_file()
      innobase/trx/trx0roll.c:
        Replace mem_alloc()+strlen()+memcpy() with mem_strdup()
      innobase/trx/trx0sys.c:
        Remove unnecessary strlen() call
      innobase/ut/ut0byte.c:
        Add const qualifier to ut_cpy_in_lower_case()
        Remove parameter "len" of ut_cmp_in_lower_case()
      innobase/ut/ut0mem.c:
        Add ut_strlenq() and ut_memcpyq()
      sql/ha_innodb.cc:
        Remove parameter "len" of ut_cmp_in_lower_case()
      025ddfea
  2. 31 Mar, 2004 6 commits
    • unknown's avatar
      Merge marko@build.mysql.com:/home/bk/mysql-4.0 · 95367941
      unknown authored
      into hundin.mysql.fi:/home/marko/j/mysql-4.0
      
      
      95367941
    • unknown's avatar
      InnoDB: cleanup of B-tree cursor operations · dbffc480
      unknown authored
      
      innobase/btr/btr0cur.c:
        Remove unused parameter of btr_cur_latch_leaves()
        Simplify logic and add debug assertion in btr_cur_search_to_nth_level()
      dbffc480
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-4.0 · bdb370c8
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/Bugs/mysql-4.0
      
      
      bdb370c8
    • unknown's avatar
      InnoDB: Remove ut_str_contains() and replace it with strchr() · 7c9dba22
      unknown authored
      
      innobase/dict/dict0dict.c:
        Replace ut_str_contains() with strchr()
      innobase/include/ut0mem.h:
        Remove ut_str_contains(), a reinvented strchr()
      innobase/row/row0mysql.c:
        Replace ut_str_contains() with strchr()
      innobase/ut/ut0mem.c:
        Remove ut_str_contains(), a reinvented strchr()
      7c9dba22
    • unknown's avatar
      InnoDB: Remove unused hash table code and parameters · 19b727ad
      unknown authored
      
      innobase/ha/ha0ha.c:
        Remove unused first parameter of ha_chain_get_next()
      innobase/include/ha0ha.ic:
        Remove unused first parameter of ha_chain_get_next()
        Remove unused function ha_next()
      19b727ad
    • unknown's avatar
      InnoDB: Remove unnecessary code, mostly related to stored procedures · 4050e916
      unknown authored
      
      innobase/data/data0data.c:
        Remove unused global variables
      innobase/dict/dict0dict.c:
        Remove unused code
      innobase/dict/dict0mem.c:
        Remove unnecessary function dict_mem_procedure_create()
      innobase/include/dict0dict.h:
        Remove unused code related to stored procedures
      innobase/include/dict0dict.ic:
        Remove unnecessary function dict_procedure_get()
      innobase/include/dict0mem.h:
        Remove unnecessary code related to stored procedures
      innobase/include/dict0types.h:
        Remove dict_proc_t, as procedures are not stored into database
      innobase/include/pars0pars.h:
        Remove call_node_struct and references to dict_proc_t,
        as procedures are not stored into database or called by name
      innobase/include/pars0sym.h:
        Remove procedure_def, as procedures are not stored into database
      innobase/include/pars0types.h:
        Remove call_node_t, as procedures are not called by name
      4050e916
  3. 30 Mar, 2004 3 commits
  4. 29 Mar, 2004 4 commits
  5. 26 Mar, 2004 11 commits
    • unknown's avatar
      some cleanup of last patch for BUG #2342 · 04e879e7
      unknown authored
      
      mysql-test/t/bdb-crash.test:
        added newline
      sql/ha_berkeley.cc:
        added a commet
      04e879e7
    • unknown's avatar
      Merge vvagin@bk-internal.mysql.com:/home/bk/mysql-4.0 · 2e3950b2
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2342/mysql-4.0
      
      
      2e3950b2
    • unknown's avatar
      fixed bug #2342 · aab1e50e
      unknown authored
      "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
      
      1. added new status HA_ADMIN_REJECT and processing of it in mysql_admin_table
      2. got ha_berkley::analyze to return HA_ADMIN_REJECT if there are any 
       transactions with the table.. 
      
      
      mysql-test/r/bdb-crash.result:
        added test for bug #2342 
        "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
      mysql-test/t/bdb-crash.test:
        added test for bug #2342 
        "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
      sql/ha_berkeley.cc:
        fixed bug #2342 
        "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
        
        we have to return new status "HA_ADMIN_REJECT" for ha_berkley::analyze 
        if there are any transaction for this table 
        so as bdb documentation says:
        "The DB->stat method cannot be transaction protected"
      sql/handler.h:
        added new status of table info "HA_ADMIN_REJECT"
        
        We have to return this status for bdb tables which 
        have any active transactions so as bdb-documentation says:
        "The DB->stat method cannot be transaction-protected"
      sql/sql_table.cc:
        added processing of the new status HA_ADMIN_REJECT in mysql_admin_table
        (reason to add this status is explained in comment 
        for commit on sql/handler.h)
      aab1e50e
    • unknown's avatar
      Merge sinisa@bk-internal.mysql.com:/home/bk/mysql-4.0 · 10d80288
      unknown authored
      into sinisa.nasamreza.org:/mnt/work/mysql-4.0
      
      
      10d80288
    • unknown's avatar
      Merge heikki@build.mysql.com:/home/bk/mysql-4.0 · 185c68d9
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-4.0
      
      
      185c68d9
    • unknown's avatar
      mem0dbg.c: · 08d31b97
      unknown authored
        Backport from 4.1: make mem_current_allocated_memory global variable
      
      
      innobase/mem/mem0dbg.c:
        Backport from 4.1: make mem_current_allocated_memory global variable
      08d31b97
    • unknown's avatar
      Merge sinisa@bk-internal.mysql.com:/home/bk/mysql-4.0 · 13e6d008
      unknown authored
      into sinisa.nasamreza.org:/mnt/work/mysql-4.0
      
      
      13e6d008
    • unknown's avatar
      order_by.result: · 9cc75495
      unknown authored
        result of the test case for FORCE INDEX on ORDER BY
      order_by.test:
        test case for FORCE INDEX on ORDER BY
      sql_select.cc:
        Changing behaviour that MySQL server takes FORCE INDEX clause into account when optimising ORDER BY clause
      
      
      sql/sql_select.cc:
        Changing behaviour that MySQL server takes FORCE INDEX clause into account when optimising ORDER BY clause
      mysql-test/t/order_by.test:
        test case for FORCE INDEX on ORDER BY
      mysql-test/r/order_by.result:
        result of the test case for FORCE INDEX on ORDER BY
      9cc75495
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · 202ea81c
      unknown authored
      into mysql.com:/home/my/mysql-4.0
      
      
      202ea81c
    • unknown's avatar
      Allow keys with 0 segements in MyISAM · cc11f6f3
      unknown authored
      This fixed a bug in SELECT DISTINCT when all selected parts where constants. (Bug #3203)
      
      
      myisam/mi_create.c:
        Allow keys with 0 segements.
      mysql-test/r/myisam.result:
        Test for problem with SELECT DISTINCT
      mysql-test/t/myisam.test:
        Test for problem with SELECT DISTINCT
      cc11f6f3
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.0 · 8a6ae839
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-qc-4.0
      
      
      8a6ae839
  6. 25 Mar, 2004 7 commits
  7. 24 Mar, 2004 3 commits
  8. 23 Mar, 2004 5 commits