by adding sleep-and-retries (max 4 times) if MASTER_POS_WAIT() returns NULL
in sync_with_master and sync_slave_with_master.
The problem showed up only today, in MySQL 5.0 in rpl_server_id2.test,
but may affect 4.x as well, so fixing it here. Note that I am also fixing
5.0 too, with the same exact patch, because I don't want to leave 5.0 broken
until the next 4.0->4.1->5.0 merge.


client/mysqltest.c:
  in sync_with_master (and sync_slave_with_master), if MASTER_POS_WAIT() returns NULL,
  it may be that the slave SQL thread did not have time to start yes, so we sleep
  1 sec and retry, 4 times at most.
mysql-test/r/rpl_server_id2.result:
  result update
mysql-test/t/rpl_server_id2.test:
  master_slave.inc already drops the table

innobase/os/os0file.c:
  Remove os_file_lock()

sql/ha_innodb.cc:
  innobase_mysql_print_thd(): initial fix to Bug #3596

  Backport suppression of MSVC++ warning from 4.1


innobase/eval/eval0eval.c:
  Backport suppression of MSVC++ warning from 4.1

 - Tagged ChangeSet@1.1800.1.1 as "mysql-4.0.19"


configure.in:
   - Bumped up version number from 4.0.19 -> 4.0.20

into serg.mylan:/usr/home/serg/Abk/mysql-4.0

innobase/btr/btr0btr.c:
  Changed bug reporting address to http://bugs.mysql.com
innobase/dict/dict0load.c:
  Changed bug reporting address to http://bugs.mysql.com
innobase/ibuf/ibuf0ibuf.c:
  Changed bug reporting address to http://bugs.mysql.com
innobase/lock/lock0lock.c:
  Changed bug reporting address to http://bugs.mysql.com
innobase/row/row0ins.c:
  Changed bug reporting address to http://bugs.mysql.com
innobase/row/row0sel.c:
  Changed bug reporting address to http://bugs.mysql.com
innobase/row/row0umod.c:
  Changed bug reporting address to http://bugs.mysql.com
innobase/row/row0upd.c:
  Changed bug reporting address to http://bugs.mysql.com
innobase/trx/trx0rec.c:
  Changed bug reporting address to http://bugs.mysql.com
innobase/ut/ut0dbg.c:
  Changed bug reporting address to http://bugs.mysql.com

into hundin.mysql.fi:/home/marko/j/mysql-4.0

innobase/row/row0mysql.c:
  Compare database part of table name with memcmp(), not strcmp()

into mysql.com:/home/mydev/mysql-4.0-bug2831

into serg.mylan:/usr/home/serg/Abk/mysql-4.0

"phrase search" should not match partial words (it should not match 'paraphrase searches')

into mysql.com:/home/mydev/mysql-4.0-bug2831

mysql-test/t/rpl000015.test:
  Fix replace_result of $MASTER_MYPORT instead of literal numbers.
  The test case rpl000015 needs one exlpicit literal number.
  It changes partial master settings, which seems to reset other settings
  to their defaults. To test this is obviously the intent of this case.

into hundin.mysql.fi:/home/marko/l/mysql-4.0

innobase/row/row0mysql.c:
  Revert accidental modification to row_lock_table_autoinc_for_mysql()
  made in ChangeSet@1.1794.1.1
mysql-test/r/innodb.result:
  Revert ChangeSet@1.1794.1.1

into mysql.com:/home/mydev/mysql-4.0-bug2831


BitKeeper/etc/logging_ok:
  auto-union

into a80-186-24-72.elisa-laajakaista.fi:/home/my/bk/mysql-4.0

to use long query strings with it.
Bug#3633


BitKeeper/etc/logging_ok:
  Logging to logging@openlogging.org accepted

into mysql.com:/home/mysql_src/mysql-4.0

myisam/mi_dynrec.c:
  need DBUG_RETURN as we DBUG_ENTER

BitKeeper/etc/logging_ok:
  Logging to logging@openlogging.org accepted

sql/sql_acl.cc:
  Auto merged

into mysql.com:/home/mysql_src/mysql-4.0

very minor changes: a STOP SLAVE in a replication test to get rid of a non critical message in slave.err,
and a comment update


mysql-test/r/rpl_server_id2.result:
  result update
mysql-test/t/rpl_server_id2.test:
  We stop the slave before cleaning up otherwise we'll get
  'drop table t1' executed twice, so an error in the slave.err
  (not critical).
sql/slave.cc:
  update comment about 4.1 now that 4.1 is fixed (in a few minutes, exactly)

innobase/include/os0file.h:
  Add os_file_set_eof()
innobase/os/os0file.c:
  Add os_file_set_eof()
innobase/srv/srv0srv.c:
  Replace chsize() or ftruncate() with os_file_set_eof()
sql/ha_innodb.cc:
  Replace my_chsize() with os_file_set_eof()

(Bug #3596)


innobase/srv/srv0srv.c:
  Truncate "<datadir>/innodb.status.<pid>" to its actual size (Bug #3596)
sql/ha_innodb.cc:
  Truncate "<datadir>/innodb.status.<pid>" to its actual size (Bug #3596)

innobase/os/os0file.c:
  Lock files unless #defined __WIN__ or UNIV_HOTBACKUP (Bug #3608)

into hundin.mysql.fi:/home/marko/l/mysql-4.0

VC++Files/client/mysqlclient.dsp:
  Add strxnmov to project files
VC++Files/mysql.dsw:
  Add dependency to prevent compile error

just for beauty of truth.


sql/mysqld.cc:
  correcting sentence (even if option is not really usable,
  as it depends on report-user and report-password which are undocumented
  (and will stay like this)).
sql/slave.cc:
  report password when you must report password.

into mysql.com:/home/mysql_src/mysql-4.0

in hard-coded replication messages, always put small-length info (error codes, explanation of the error) at the beginning,
so that it is not cut by truncation if the query is very long (which happens if the query goes first).


sql/log_event.cc:
  in hard-coded replication messages, always put small-length info (error codes, explanation of the error) at the beginning,
  so that it is not cut by truncation if the query is very long (which happens if the query goes first).

into hundin.mysql.fi:/home/marko/l/mysql-4.0