1. 21 Feb, 2011 1 commit
    • Vladislav Vaintroub's avatar
      Fix remaining 5.2 buildbot problems: · 04879e40
      Vladislav Vaintroub authored
      - Cherrypick MBUG#688404  (PBXT crashes in debug/x64)
      - Fix unixism (rm -rf) in the test suite_timeout
      - Avoid plugin tests on Windows/embedded, plugins do not and will not work here
      04879e40
  2. 19 Feb, 2011 4 commits
  3. 18 Feb, 2011 4 commits
    • Vladislav Vaintroub's avatar
    • Vladislav Vaintroub's avatar
      Linker error, missing extern "C" for mi_killed. · e906ffcf
      Vladislav Vaintroub authored
      Fix is to move extern "C" at the start of header file.
      e906ffcf
    • Michael Widenius's avatar
      Merge with bugfix · 2813f568
      Michael Widenius authored
      sql/multi_range_read.cc:
        Added printing of error if something goes wrong in get_next()
        (Not critical for this bug fix, but this was something that I noticed while testing and found missing)
      storage/myisam/mi_rkey.c:
        Fixed wrong error number in mi_yield_and_check_if_killed()
      2813f568
    • Michael Widenius's avatar
      Fix for lp:711565 "Index Condition Pushdown can make a thread hold MyISAM... · b12e3796
      Michael Widenius authored
      Fix for lp:711565 "Index Condition Pushdown can make a thread hold MyISAM locks as well as be unKILLable for long time"
      - In Maria/MyISAM: Release/re-acquire locks to give queries that wait on them a chance to make progress
      - In Maria/MyISAM: Change from numeric constants to ICP_RES values.
      - In Maria: Do check index condition in maria_rprev() (was lost in the merge/backport?)
      - In Maria/MyISAM/XtraDB: Check if the query was killed, and return immediately if it was.
      
      Added new storage engine error: HA_ERR_ABORTED_BY_USER, for handler to signal that it detected a kill of the query and aborted
      
      Authors: Sergey Petrunia & Monty
      
      include/my_base.h:
        Added HA_ERR_ABORTED_BY_USER, for handler to signal that it detected a kill of the query and aborted
      include/my_handler.h:
        Added comment
      mysql-test/r/myisam_icp.result:
        Updated test
      mysql-test/t/myisam_icp.test:
        Drop used tables at start of test
        Added test case that can help with manual testing of killing index condition pushdown query.
      mysys/my_handler_errors.h:
        Text for new storage engine error
      sql/handler.cc:
        If engine got HA_ERR_ABORTED_BY_USER, send kill message.
      sql/multi_range_read.cc:
        Return error code
      storage/maria/ha_maria.cc:
        Added ma_killed_in_mariadb() to detect kill.
        Ensure that file->external_ref points to TABLE object.
      storage/maria/ma_extra.c:
        Dummy test-if-killed for standalone
      storage/maria/ma_key.c:
        If ma_check_index_cond() fails, set my_errno and info->cur_row.lastpos
      storage/maria/ma_rkey.c:
        Release/re-acquire locks to give queries that wait on them a chance to make progress
        Check if the query was killed, and return immediately if it was
      storage/maria/ma_rnext.c:
        Check if the query was killed, and return immediately if it was
        Added missing fast_ma_writeinfo(info)
      storage/maria/ma_rnext_same.c:
        Check if the query was killed, and return immediately if it was
        Added missing fast_ma_writeinfo(info)
      storage/maria/ma_rprev.c:
        Check if the query was killed, and return immediately if it was
        Added missing fast_ma_writeinfo(info) and ma_check_index_cond()
      storage/maria/ma_search.c:
        Give error message if we find a wrong key
      storage/maria/ma_static.c:
        Added pointer to test-if-killed function
      storage/maria/maria_def.h:
        New prototypes
      storage/myisam/ha_myisam.cc:
        Added mi_killed_in_mariadb()
        Ensure that file->external_ref points to TABLE object.
      storage/myisam/mi_extra.c:
        Dummy test-if-killed for standalone
      storage/myisam/mi_key.c:
        If ma_check_index_cond() fails, set my_errno and info->lastpos
      storage/myisam/mi_rkey.c:
        Ensure that info->lastpos= HA_OFFSET_ERROR in case of error
        Release/re-acquire locks to give queries that wait on them a chance to make progress
        Check if the query was killed, and return immediately if it was
        Reorder code to do less things in case of error.
        Added missing fast_mi_writeinfo()
      storage/myisam/mi_rnext.c:
        Check if the query was killed, and return immediately if it was
        Simplify old ICP code
        Added missing fast_ma_writeinfo(info)
      storage/myisam/mi_rnext_same.c:
        Check if the query was killed, and return immediately if it was
        Added missing fast_mi_writeinfo(info)
      storage/myisam/mi_rprev.c:
        Check if the query was killed, and return immediately if it was
        Simplify error handling of ICP
        Added missing fast_mi_writeinfo(info)
      storage/myisam/mi_search.c:
        Give error message if we find a wrong key
      storage/myisam/mi_static.c:
        Added pointer to test-if-killed function
      storage/myisam/myisamdef.h:
        New prototypes
      storage/xtradb/handler/ha_innodb.cc:
        Added DB_SEARCH_ABORTED_BY_USER and ha_innobase::is_thd_killed()
        Check if the query was killed, and return immediately if it was
      storage/xtradb/handler/ha_innodb.h:
        Added prototype
      storage/xtradb/include/db0err.h:
        Added DB_SEARCH_ABORTED_BY_USER
      storage/xtradb/include/row0mysql.h:
        Added possible ICP errors
      storage/xtradb/row/row0sel.c:
        Use ICP errors instead of constants.
        Detect if killed and return B_SEARCH_ABORTED_BY_USER
      b12e3796
  4. 12 Feb, 2011 4 commits
  5. 11 Feb, 2011 1 commit
  6. 10 Feb, 2011 1 commit
  7. 09 Feb, 2011 2 commits
  8. 07 Feb, 2011 1 commit
  9. 06 Feb, 2011 1 commit
    • Igor Babaev's avatar
      Fixed LP bug #702403 that caused a crash on the tree for mwl#128 · cbeab250
      Igor Babaev authored
      with the test case added by this patch.
      The bug cannot be reproduced with the same test case for the main
      5.3 tree because the backported fix for bug 59696 masks the 
      problem that causes the crash in the mentioned test case. It's not
      clear weather this fix masks this problem in all possible cases. 
      
      Anyway the patch for bug 698882 introduced some inconsistent data
      structures that could contain indirect references to deleted object.
      It happened when two Item_equal objects were merged and the Item_field
      list of the second object was joined to such list of the first object.
      This operation required adjustment of the backward pointers in 
      Item fields from the joined list. However the adjustment was missing 
      and this caused crashes in the tree for mwl#128.
      
      Now the backward pointers are set only when Item_equal items are
      completely built and are not changed anymore.
       
      cbeab250
  10. 05 Feb, 2011 1 commit
    • Igor Babaev's avatar
      Introduced optimizer switch flag 'optimize_join_buffer_size'. · 4b24105d
      Igor Babaev authored
      When this flag is 'off' the size of the used join buffer 
      is taken directly from the system variable 'join_buffer_size'.
      When this flag is 'on' then the size of the buffer depends
      on the estimated number of rows in the partial join whose
      records are to be stored in the buffer.
      By default this flag is set 'on'.
      4b24105d
  11. 01 Feb, 2011 2 commits
    • Vladislav Vaintroub's avatar
      Fix compile errors: · 7e206872
      Vladislav Vaintroub authored
      * declaration in the middle of the block in C file.
      * round() is only available in C99.
      7e206872
    • Igor Babaev's avatar
      Back-ported the patch for bug #59696 from mysql-5.6 code line. · 8041013f
      Igor Babaev authored
      The patch fixed the following optimizer defect: when performing
      substitution for best equal fields into where conditions to be
      able to do their evaluations as soon as possible the optimizer 
      skipped conditions over views. That could lead to suboptimal 
      execution of queries that used views.  
      Slightly changed the test case to demonstrate the performance
      improvements if this fix.
      8041013f
  12. 29 Jan, 2011 1 commit
  13. 28 Jan, 2011 1 commit
    • Igor Babaev's avatar
      Fixed LP bug #707827. · d4929035
      Igor Babaev authored
      This bug could manifest itself when hash join over a varchar column
      with NULL values in some rows was used. It happened because the
      function key_buf_cmp erroneously returned FALSE when one of the joined
      key fields was null while the second was not.
      Also fixed two other bugs in the functions key_hashnr and key_buf_cmp 
      that could possibly lead to wrong results for some queries that
      used hash join over several columns with nulls.
      Also reverted the latest addition of the test case for bug #45092. It
      had been already backported earlier.
      d4929035
  14. 27 Jan, 2011 1 commit
    • Igor Babaev's avatar
      Fixed LP bug #707848. · 3e868cd3
      Igor Babaev authored
      This was another bug in the patch for bug 698882. The new
      code from this patch did not ensured that substitutions
      of fields for best equal fields were performed on all
      AND-OR levels. As a result substitutions for best fields
      in some predicates that had been used by the range optimizer
      were not actually performed while range plans could employ
      these substitutions. This could lead to inconsistent data
      structures and ultimately to a crash.
      3e868cd3
  15. 26 Jan, 2011 1 commit
    • Igor Babaev's avatar
      Fixed LP bug #707555. · a624f99e
      Igor Babaev authored
      The bug was in the code of the patch fixing bug 698882.
      With improper casting the method store_key_field::change_source_field
      was called for the elements of the array TABLE_REF::key_copy that
      were either of a different type or not allocated at all. This caused
      crashes in some queries. 
      a624f99e
  16. 24 Jan, 2011 1 commit
  17. 23 Jan, 2011 2 commits
  18. 22 Jan, 2011 3 commits
  19. 21 Jan, 2011 1 commit
  20. 14 Jan, 2011 7 commits
    • Sergei Golubchik's avatar
      6c907625
    • Sergei Golubchik's avatar
    • Sergei Golubchik's avatar
      Optimize use of SEARCH_SAVE_BUFF in Aria · eec32a33
      Sergei Golubchik authored
      (less not-needed copies of key pages)
      
      storage/maria/ma_rkey.c:
        Fixed wrong test if SEARCH_SAVE_BUFF should be set.
        Now we assume that if we are doing HA_READ_KEY_EXACT,
        we don't have to copy the last key buffer
        (in other words, it's not likely this will be followed
        by a read-next call)
      eec32a33
    • Sergei Golubchik's avatar
      use bulk insert and repair by sort for unique keys in · 418df96d
      Sergei Golubchik authored
      Aria and MyISAM in create_internal_tmp_table_from_heap()
      (safe, as duplicates are impossible).
      This gives a HUGE speed boost!
      
      sql/opt_subselect.cc:
        Fixed problem with wrong recinfo in create_duplicate_weedout_tmp_tabl()
        Tagged the table with 'no_rows' so that when we create the table on disk,
        we only store the index data. This gave us a major speedup!
      sql/sql_select.cc:
        create_tmp_table_from_heap() now uses bulk_insert + repair_by_sort
        when creating Aria/MyISAM tables from HEAP tables.
        This gives a HUGE speed boost!
      storage/maria/ha_maria.cc:
        Extended bulk_insert() to recreate UNIQUE keys for
        internal temporary tables
      storage/maria/ma_open.c:
        Initialize m_info->lock.type properly for temporarly tables
        (needed for start_bulk_insert())
      storage/maria/ma_write.c:
        Don't check uniques that are disabled
      storage/myisam/ha_myisam.cc:
        Extended bulk_insert() to recreate UNIQUE keys for
        internal temporary tables.
      418df96d
    • Sergei Golubchik's avatar
      Added ha_write_tmp_row() for slightly faster write_row for internal temp tables. · 6554977f
      Sergei Golubchik authored
      This will also enable us in the future to collect statistics for
      writes to internal tmp tables.
      
      sql/handler.h:
        Added ha_write_tmp_row()
      sql/opt_subselect.cc:
        ha_write_row -> ha_write_tmp_row
      sql/sql_class.h:
        Added ha_write_tmp_row()
      sql/sql_select.cc:
        ha_write_row -> ha_write_tmp_row
      6554977f
    • Sergei Golubchik's avatar
      Added support for NO_RECORD record format (don't store any row data) for Aria. · f5ea301a
      Sergei Golubchik authored
      This makes the keys smaller (no row pointer) and gives us proper errors if we
      use the table wrongly.
      
      sql/sql_select.cc:
        Use NO_RECORD for tables that doesn't need row data.
      storage/maria/Makefile.am:
        Added ma_norec.c
      storage/maria/ma_check.c:
        Added support for NO_RECORD record format (don't store any row data)
      storage/maria/ma_norec.c:
        Added support for NO_RECORD record format
      storage/maria/ma_open.c:
        Added support for NO_RECORD record format
      storage/maria/ma_search.c:
        Added support for 0 size row pointers (used with NO_RECORD)
      storage/maria/ma_test1.c:
        Added testing of NO_RECORD record format.
      storage/maria/maria_chk.c:
        Added support for NO_RECORD
      storage/maria/maria_def.h:
        Added support for NO_RECORD
      storage/maria/unittest/ma_test_all-t:
        Added testing of NO_RECORD record format
      f5ea301a
    • Sergei Golubchik's avatar
      use normal unique (HA_NOSAME) keys for expression cache · 17c18877
      Sergei Golubchik authored
      temptables, not "uniques", that are hash-based keys.
      
      sql/sql_expression_cache.cc:
        Don't set uniques (we don't want or need an unique
        constraint on this table)
      17c18877