- 01 Mar, 2014 2 commits
-
-
Sergei Golubchik authored
parser: error out on empty role names
-
Sergei Golubchik authored
-
- 28 Feb, 2014 4 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
don't forget to initialize ORDER::fast_field_copier_setup
-
Sergei Golubchik authored
-
- 27 Feb, 2014 8 commits
-
-
Sergei Golubchik authored
Fix ha_table_exists() to take discovery into account correctly. It must be able to discover both table existence (when no frm is found) and table non-existance (when frm was found).
-
Alexander Barkov authored
-
Jan Lindström authored
-
Sergei Golubchik authored
apply the upstream patch
-
Sergei Golubchik authored
-
Elena Stepanova authored
Disable query cache for OQGRAPH
-
Sergei Golubchik authored
-
unknown authored
Add a check for binlog open already during the parsing, so that BINLOG_GTID_POS() can return the error early and not delay it until execution.
-
- 26 Feb, 2014 14 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
update test results
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
unknown authored
-
unknown authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
(assert added by MySQL verified that strnxfrm can only *increase* the string length if from == to, and the latter is a random decision made by individual items and String::realloc). Fix it by avoiding the memcpy in the first place.
-
Sergei Golubchik authored
-
unknown authored
Clean up and improve the parallel implementation code, mainly related to scheduling of work to threads and handling of stop and errors. Fix a lot of bugs in various corner cases that could lead to crashes or corruption. Fix that a single replication domain could easily grab all worker threads and stall all other domains; now a configuration variable --slave-domain-parallel-threads allows to limit the number of workers. Allow next event group to start as soon as previous group begins the commit phase (as opposed to when it ends it); this allows multiple event groups on the slave to participate in group commit, even when no other opportunities for parallelism are available. Various fixes: - Fix some races in the rpl.rpl_parallel test case. - Fix an old incorrect assertion in Log_event iocache read. - Fix repeated malloc/free of wait_for_commit and rpl_group_info objects. - Simplify wait_for_commit wakeup logic. - Fix one case in queue_for_group_commit() where killing one thread would fail to correctly signal the error to the next, causing loss of the transaction after slave restart. - Fix leaking of pthreads (and their allocated stack) due to missing PTHREAD_CREATE_DETACHED attribute. - Fix how one batch of group-committed transactions wait for the previous batch before starting to execute themselves. The old code had a very complex scheduling where the first transaction was handled differently, with subtle bugs in corner cases. Now each event group is always scheduled for a new worker (in a round-robin fashion amongst available workers). Keep a count of how many transactions have started to commit, and wait for that counter to reach the appropriate value. - Fix slave stop to wait for all workers to actually complete processing; before, the wait was for update of last_committed_sub_id, which happens a bit earlier, and could leave worker threads potentially accessing bits of the replication state that is no longer valid after slave stop. - Fix a couple of places where the test suite would kill a thread waiting inside enter_cond() in connection with debug_sync; debug_sync + kill can crash in rare cases due to a race with mysys_var_current_mutex in this case. - Fix some corner cases where we had enter_cond() but no exit_cond(). - Fix that we could get failure in wait_for_prior_commit() but forget to flag the error with my_error(). - Fix slave stop (both for normal stop and stop due to error). Now, at stop we pick a specific safe point (in terms of event groups executed) and make sure that all event groups before that point are executed to completion, and that no event group after start executing; this ensures a safe place to restart replication, even for non-transactional stuff/DDL. In error stop, make sure that all prior event groups are allowed to execute to completion, and that any later event groups that have started are rolled back, if possible. The old code could leave eg. T1 and T3 committed but T2 not, or it could even leave half a transaction not rolled back in some random worker, which would cause big problems when that worker was later reused after slave restart. - Fix the accounting of amount of events queued for one worker. Before, the amount was reduced immediately as soon as the events were dequeued (which happens all at once); this allowed twice the amount of events to be queued in memory for each single worker, which is not what users would expect. - Fix that an error set during execution of one event was sometimes not cleared before executing the next, causing problems with the error reporting. - Fix incorrect handling of thd->killed in worker threads.
-
unknown authored
Removed repetative calls of virtual functions. Removed check of posibility just copy field for every record.
-
Sergey Vojtovich authored
Ported fix for MySQL BUG#51861.
-
- 25 Feb, 2014 2 commits
-
-
Sergei Golubchik authored
-
Sergey Petrunya authored
-
- 24 Feb, 2014 1 commit
-
-
Sergey Petrunya authored
- Change the default flag value to ON. - Update the testcases to be run extended_keys=ON: = trivial test result updates = If extended_keys setting makes a difference for a testcase, run the testcase with extended_keys=off. There were only a few such cases - Update to vcol_select_innodb looks like a worse plan but it will be gone in 10.0.
-
- 22 Feb, 2014 2 commits
-
-
Sergei Golubchik authored
-
Michael Widenius authored
As part of the fix we don't anymore generate a create table statement when doing a CREATE TABLE IF NOT EXISTS table_that_exist LiKE temporary_table if the 'table_that_exist' existed. This is because it's not self evident if we should generate a create statement matching the existing table or the temporary_table. The old code generated a table like the existing table in row based replication and like the temporary table in statement based replication. It's better to ensure that both cases works the same way. mysql-test/suite/rpl/r/rpl_row_create_table.result: Updated results (Now we don't anymore CREATE TABLE IF NOT EXISTS LIKE if the table existed) sql/sql_base.cc: More DBUG_PRINT sql/sql_error.cc: More DBUG_PRINT sql/sql_table.cc: Don't generate a create table statement when doing a CREATE TABLE IF NOT EXISTS table_that_exist like temporary_table if the table existed.
-
- 21 Feb, 2014 2 commits
-
-
Sergei Golubchik authored
-
Igor Babaev authored
update_used_tables for the the where condition to update cached indicators of constant subexpressions. It should be done before further possible simplification of the where condition. This change caused simplification of the executed where conditions in many test cases.
-
- 20 Feb, 2014 3 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
In ::position() federated needs to know an element before the current ("data_cursor") in the single-linked list. Replace list traversal for every ::position() call (which is O(n^2)) with remembering the current element before it's advanced by mysql_fetch_row(). storage/federatedx/federatedx_io_mysql.cc: mdev:5698
-
- 19 Feb, 2014 2 commits
-
-
Sergei Golubchik authored
Use 20-year ssl certificates for mysql-test from RedHat patch
-
Sergei Golubchik authored
On fedora: 1. provide/obsoleve mariadb-* packages 2. MariaDB-common conflicts with mariadb-libs (on filesystem level), but does not provide or obsolete it.
-