- 27 Jan, 2009 1 commit
-
-
Alfranio Correia authored
The fix for BUG#20103 "Escaping with backslash does not work as expected" was implemented too greedy though in that it not only changes the behavior of backslashes within strings but in general, so disabling command shortcuts like \G or \C (which in turn leads to Bug #36391: "mysqlbinlog creates invalid charset statements"). The fix allows the escaping with backslash to take place only inside a string, thus enabling the execution of command shortcuts and presevering the fix for BUG#20103.
-
- 26 Jan, 2009 2 commits
-
-
Chad MILLER authored
-
Ramil Kalimullin authored
myisam_repair_threads > 1 causes crash Problem: parallel repair (myisam_repair_threads > 1) of a myisam table with two or more fulltext keys that use the same parser may lead to a server crash. ALTER TABLE ENABLE KEYS is affected as well. Fix: properly initialize fulltext structures for parallel repair. Note: 1. there's no deterministic test case. 2. now we call parser->init() for each fulltext key (not for each fulltext parser used). storage/myisam/ft_parser.c: Fix for bug #37756: enabling fulltext indexes with myisam_repair_threads > 1 causes crash In ftparser_call_initializer() we "group" parsers and allocate parameters for each unique parser used. In case of parallel repairing we may have a bunch of parsers that use the only MI_INFO structure. Each of these parsers must have its own parameter structure in order not to interfere with others. Moreover, the allocation is done without mutex lock so parallel ftparser_call_initializer() calls are unsafe. Now we don't "group" the fulltext parsers. Parameter allocation code moved to ftparser_alloc_param() function which is called from mi_repair_parallel() as well to allocate parameters for each parser used. storage/myisam/ftdefs.h: Fix for bug #37756: enabling fulltext indexes with myisam_repair_threads > 1 causes crash ftparser_alloc_param(MI_INFO *info) added. storage/myisam/mi_check.c: Fix for bug #37756: enabling fulltext indexes with myisam_repair_threads > 1 causes crash ftparser_alloc_param(info) called in case of parallel repair to allocate fulltext parser parameters. storage/myisam/mi_open.c: Fix for bug #37756: enabling fulltext indexes with myisam_repair_threads > 1 causes crash set keyinfo->ftkey_nr and share->ftkeys.
-
- 24 Jan, 2009 1 commit
-
-
Gleb Shchepa authored
-
- 23 Jan, 2009 6 commits
-
-
Horst Hunger authored
-
Horst Hunger authored
-
Gleb Shchepa authored
in trigger Interchangeable calls to the mysql_change_user client function and invocations of a trigger changing some user variable caused a memory corruption and a crash. The mysql_change_user API call forces TDH::cleanup() on a server that frees user variable entries. However it didn't reset Item_func_set_user_var::entry to NULL because Item_func_set_user_var::cleanup() was not overloaded. So, Item_func_set_user_var::entry held a pointer to freed memory, that caused a crash. The Item_func_set_user_var::cleanup method has been overloaded to cleanup the Item_func_set_user_var::entry field. mysql-test/r/user_var.result: Added test case for bug #42188. mysql-test/t/user_var.test: Added test case for bug #42188. sql/item_func.cc: Bug#42188: crash and/or memory corruption with user variables in trigger The Item_func_set_user_var::cleanup method has been overloaded to cleanup the Item_func_set_user_var::entry field. sql/item_func.h: Bug#42188: crash and/or memory corruption with user variables in trigger The Item_func_set_user_var::cleanup method has been overloaded to cleanup the Item_func_set_user_var::entry field.
-
Horst Hunger authored
Deleted the opt file. Replaced the sleeps by wait condition. Made some beautyfications. Inserted review results.
-
Andrei Elkin authored
an additional changeset to remove printing a path name. mysql-test/suite/rpl/r/rpl_cross_version.result: removing a local exec env dependency mysql-test/suite/rpl/t/rpl_cross_version.test: refining a test to not have local exec env dependency.
-
Andrei Elkin authored
-
- 22 Jan, 2009 5 commits
-
-
Andrei Elkin authored
It's a regression issue. The reason of the bug appeared to be an error introduced into 5.1 source code. A piece of code in Create_file_log_event::do_apply_event() did not have test coverage which made make test and pb unaware. Fixed with inverting the old value of the return value from Create_file_log_event::do_apply_event(). The rpl test suite is extended with `rpl_cross_version' the file to hold regression cases similar to the current. mysql-test/suite/rpl/r/rpl_cross_version.result: new results file mysql-test/suite/rpl/t/rpl_cross_version-master.opt: options to the server to be able to start replication to itself mysql-test/suite/rpl/t/rpl_cross_version.test: regression test for bug#31240. sql/log_event.cc: Correcting the return value from Create_file_log_event::do_apply_event()
-
Satya B authored
-
Davi Arnaut authored
sql/sql_cache.cc: Assert that results are always complete.
-
Davi Arnaut authored
The problem is that the query cache was storing partial results if the statement failed when sending the results to the client. This could cause clients to hang when trying to read the results from the cache as they would, for example, wait indefinitely for a eof packet that wasn't saved. The solution is to always discard the caching of a query that failed to send its results to the associated client. mysql-test/r/query_cache_notembedded.result: Add test case result for Bug#40264 mysql-test/t/query_cache_notembedded.test: Add test case for Bug#40264 sql/sql_cache.cc: Abort if a unreported error was raised.
-
Satya B authored
Extending the existing testcase written for BUG#40949 to verify repair table operation for compressed tables mysql-test/r/myisampack.result: Modified result file for myisampack.test mysql-test/t/myisampack.test: Modified Testcase to test repair operation for compressed tables
-
- 21 Jan, 2009 1 commit
-
-
Serge Kozlov authored
clause server fires immediately after creating event and time between create and delete event sometimes is enough for firing. So adding STARTS clause moves first execution in future after drop of event 1. Added STARTS clause for CREATE EVENT. 2. Updated result file.
-
- 20 Jan, 2009 1 commit
-
-
Staale Smedseng authored
character_set_database !=character_set_server" is fixed.
-
- 16 Jan, 2009 10 commits
-
-
Timothy Smith authored
-
Timothy Smith authored
-
Timothy Smith authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
- 15 Jan, 2009 13 commits
-
-
Joerg Bruehe authored
This does not bring any contents changes, it is purely metadata which are affected. Details: Even within 5.0, most of these changesets did not cause file contents changes, because they were backports done for the "service pack" builds of 5.0.66sp1 and 5.0.72sp1. The "real" changesets are also already present in 5.1, so this upmerge doesn't change any contents. The only "real" changeset in 5.0 was a fix of the shell scripts used to configure bdb (BerkeleyDB). As we completele removed bdb from the 5.1 sources already, the affected files are not present in the 5.1 source tree, so this changeset also does not cause any contents changes.
-
Joerg Bruehe authored
this should not happen.
-
Joerg Bruehe authored
-
Joerg Bruehe authored
-
unknown authored
-
Georgi Kodinov authored
-
Davi Arnaut authored
mysql-test/r/cache_innodb.result: Update test case result.
-
Alexander Nozdrin authored
-
Joerg Bruehe authored
This is not the final merge of that release build, but we need early access to these tool fixes (use of "awk" in the BDB configuration).
-
Joerg Bruehe authored
-
Davi Arnaut authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-