1. 03 Sep, 2008 1 commit
  2. 02 Sep, 2008 2 commits
  3. 01 Sep, 2008 12 commits
    • Vladislav Vaintroub's avatar
      null merge from bugteam-5.1 · 7883866c
      Vladislav Vaintroub authored
      7883866c
    • Vladislav Vaintroub's avatar
      Bug#37226 Explicit call of my_thread_init() on Windows for every new thread. · ff884049
      Vladislav Vaintroub authored
      Bug#33031 app linked to libmysql.lib crash if run as service in vista under 
      localsystem
        
      
      There are some problems using DllMain hook functions on Windows that 
      automatically do global and per-thread initialization for libmysqld.dll
      
      1)per-thread initialization(DLL_THREAD_ATTACH)
      MySQL internally counts number of active threads that and causes a delay in in 
      my_end() if not all threads are exited. But,there are threads that can be 
      started either by Windows internally (often in TCP/IP scenarios) or by user 
      himself - those threads are not necessarily using libmysql.dll functionality, 
      but nonetheless the contribute to the count of open threads.
      
      2)process-initialization (DLL_PROCESS_ATTACH)
      my_init() calls WSAStartup that itself loads DLLs and can lead to a deadlock in 
      Windows loader.
      
      Fix is to remove dll initialization code from libmysql.dll in general case. I
      still leave an environment variable LIBMYSQL_DLLINIT, which if set to any value 
      will cause the old behavior (DLL init hooks will be called). This env.variable 
      exists only to prevent breakage of existing Windows-only applications that 
      don't do mysql_thread_init() and work ok today. Use of LIBMYSQL_DLLINIT is 
      discouraged and it will be removed in 6.0
      ff884049
    • Vladislav Vaintroub's avatar
      58f0b318
    • Davi Arnaut's avatar
      Restore tree name after merge from main. · 4be706e7
      Davi Arnaut authored
      4be706e7
    • Vladislav Vaintroub's avatar
      Bug#37226 Explicit call of my_thread_init() on Windows for every new thread. · 51bd4415
      Vladislav Vaintroub authored
      Bug#33031 app linked to libmysql.lib crash if run as service in vista under 
      localsystem
        
      
      There are some problems using DllMain hook functions on Windows that 
      automatically do global and per-thread initialization for libmysqld.dll
      
      1)per-thread initialization(DLL_THREAD_ATTACH)
      MySQL internally counts number of active threads that and causes a delay in in 
      my_end() if not all threads are exited. But,there are threads that can be 
      started either by Windows internally (often in TCP/IP scenarios) or by user 
      himself - those threads are not necessarily using libmysql.dll functionality, 
      but nonetheless the contribute to the count of open threads.
      
      2)process-initialization (DLL_PROCESS_ATTACH)
      my_init() calls WSAStartup that itself loads DLLs and can lead to a deadlock in 
      Windows loader.
      
      Fix is to remove dll initialization code from libmysql.dll in general case. I
      still leave an environment variable LIBMYSQL_DLLINIT, which if set to any value 
      will cause the old behavior (DLL init hooks will be called). This env.variable 
      exists only to prevent breakage of existing Windows-only applications that 
      don't do mysql_thread_init() and work ok today. Use of LIBMYSQL_DLLINIT is 
      discouraged and it will be removed in 6.0
      51bd4415
    • Vladislav Vaintroub's avatar
      No commit message · 7fb01cbf
      Vladislav Vaintroub authored
      No commit message
      7fb01cbf
    • Vladislav Vaintroub's avatar
      merge · b3c157b2
      Vladislav Vaintroub authored
      b3c157b2
    • Vladislav Vaintroub's avatar
      merge · 68f341e2
      Vladislav Vaintroub authored
      68f341e2
    • Vladislav Vaintroub's avatar
      merge · 60ef785e
      Vladislav Vaintroub authored
      60ef785e
    • Mats Kindahl's avatar
      Post-merge fixes to update result files. · dbe008cc
      Mats Kindahl authored
      dbe008cc
    • Mats Kindahl's avatar
      Merging 5.0-bugteam into 5.1-bugteam · d6d2f77f
      Mats Kindahl authored
      d6d2f77f
    • Mats Kindahl's avatar
      Merging in 5.0-rpl into 5.0-bugteam · 7258de38
      Mats Kindahl authored
      7258de38
  4. 29 Aug, 2008 1 commit
    • Andrei Elkin's avatar
      Bug #38798 Assertion mysql_bin_log.is_open() failed in binlog_trans_log_savepos() · c0de944f
      Andrei Elkin authored
            
      The assert is about binlogging must have been activated, but it was
      not actually according to the reported how-to-repeat instuctions.
      Analysis revealed that binlog_start_trans_and_stmt() was called
      without prior testing if binlogging is ON.
      
      Fixed with avoing entering binlog_start_trans_and_stmt() if binlog is
      not activated.
      
      
      mysql-test/r/skip_log_bin.result:
        new results.
      mysql-test/t/skip_log_bin-master.opt:
        the option to deactivate binlogging.
      mysql-test/t/skip_log_bin.test:
        regression test for the bug.
      sql/sql_insert.cc:
        avoing entering binlog_start_trans_and_stmt() if binlog is not activated.
      c0de944f
  5. 28 Aug, 2008 9 commits
  6. 27 Aug, 2008 11 commits
    • Gleb Shchepa's avatar
      Bug #37799: SELECT with a BIT column in WHERE clause · 54a59681
      Gleb Shchepa authored
                  returns unexpected result
      
      If:
        1. a table has a not nullable BIT column c1 with a length
           shorter than 8 bits and some additional not nullable
           columns c2 etc, and
        2. the WHERE clause is like: (c1 = constant) AND c2 ...,
      the SELECT query returns unexpected result set.
      
      
      The server stores BIT columns in a tricky way to save disk
      space: if column's bit length is not divisible by 8, the
      server places reminder bits among the null bits at the start
      of a record. The rest bytes are stored in the record itself,
      and Field::ptr points to these rest bytes.
      
      However if a bit length of the whole column is less than 8,
      there are no remaining bytes, and there is nothing to store in
      the record at its regular place. In this case Field::ptr points
      to bytes actually occupied by the next column in a record.
      If both columns (BIT and the next column) are NOT NULL,
      the Field::eq function incorrectly deduces that this is the
      same column, so query transformation/equal item elimination
      code (see build_equal_items_for_cond) may mix these columns
      and damage conditions containing references to them.
      
      
      mysql-test/r/type_bit.result:
        Added test case for bug #37799.
      mysql-test/t/type_bit.test:
        Added test case for bug #37799.
      sql/field.h:
        1. The Field::eq function has been modified to take types of
        comparing columns into account to distinguish between BIT and
        not BIT columns referencing the same bytes in a record.
        
        2. Unnecessary type comparison has been removed from the
        Field_bit::eq function (moved to Field::eq).
      54a59681
    • Mats Kindahl's avatar
      Merging 5.1 into 5.1-rpl-merge · 84b81e6c
      Mats Kindahl authored
      84b81e6c
    • Georgi Kodinov's avatar
      merged 5.1-bugteam into B37548 tree · 0b24a954
      Georgi Kodinov authored
      0b24a954
    • Georgi Kodinov's avatar
      Bug#37548: result value erronously reported being NULL in certain subqueries · cab267ec
      Georgi Kodinov authored
            
      When switching to indexed ORDER BY we must be sure to reset the index read
      flag if we are switching from a covering index to non-covering.
      
      mysql-test/r/subselect.result:
        Bug#37548: test case
      mysql-test/t/subselect.test:
        Bug#37548: test case
      sql/sql_select.cc:
        Bug#37548: update the index read flag if the index for indexed ORDER BY is not
            covering.
      cab267ec
    • Mats Kindahl's avatar
      Automerge · fc31480f
      Mats Kindahl authored
      fc31480f
    • Mats Kindahl's avatar
      Result file change. · 554203f6
      Mats Kindahl authored
      554203f6
    • Evgeny Potemkin's avatar
      Bug#38195: Incorrect handling of aggregate functions when loose index scan is · 06bf25e4
      Evgeny Potemkin authored
      used causes server crash.
            
      When the loose index scan access method is used values of aggregated functions
      are precomputed by it. Aggregation of such functions shouldn't be performed
      in this case and functions should be treated as normal ones.
      The create_tmp_table function wasn't taking this into account and this led to
      a crash if a query has MIN/MAX aggregate functions and employs temporary table
      and loose index scan.
      Now the JOIN::exec and the create_tmp_table functions treat MIN/MAX aggregate
      functions as normal ones when the loose index scan is used.
      
      
      mysql-test/r/group_min_max.result:
        Added a test case for the bug#38195.
      mysql-test/t/group_min_max.test:
        Added a test case for the bug#38195.
      sql/sql_select.cc:
        Bug#38195: Incorrect handling of aggregate functions when loose index scan is
        used causes server crash.
        The JOIN::exec and the create_tmp_table functions treat MIN/MAX aggregate
        functions as normal ones when the loose index scan is used.
      06bf25e4
    • Mats Kindahl's avatar
      Automerge · f295ea2f
      Mats Kindahl authored
      f295ea2f
    • Mats Kindahl's avatar
      2d62bacf
    • Mats Kindahl's avatar
      Bug #38773: DROP DATABASE cause switch to stmt-mode when there are temporary · 02034091
      Mats Kindahl authored
                  tables open
      
      When executing a DROP DATABASE statement in ROW mode and having temporary
      tables open at the same time, the existance of temporary tables prevent
      the server from switching back to row mode after temporarily switching to
      statement mode to handle the logging of the statement.
      
      Fixed the problem by removing the code to switch to statement mode and added
      code to temporarily disable the binary log while dropping the objects in the
      database.
      
      
      mysql-test/extra/binlog_tests/database.test:
        Added test to ensure that DROP DATABASE does not affect the replication mode.
      sql/sql_db.cc:
        Removed code that clears the current_stmt_binlog_row_based flag.
        Added code to disable the binary log while dropping the objects
        in a database.
      02034091
    • Davi Arnaut's avatar
      Merge of mysql-5.1 branch. · 33338db8
      Davi Arnaut authored
      33338db8
  7. 26 Aug, 2008 4 commits