1. 16 Aug, 2006 2 commits
    • unknown's avatar
      BUG#21671 memory leak for mgmapi event listeners · 105ed9de
      unknown authored
      fixes the following valgrind warning (when running ndb_mgm under valgrind,
      or, indeed any other mgmapi program listening to events):
      
      ==23291== 190 (20 direct, 170 indirect) bytes in 1 blocks are definitely lost in loss record 13 of 22
      ==23291==    at 0x401C895: operator new(unsigned) (vg_replace_malloc.c:163)
      ==23291==    by 0x8075300: ParserImpl::run(Parser<ParserImpl::Dummy>::Context*, Properties const**, bool volatile*) const (Parser.cpp:178)
      ==23291==    by 0x806D09B: Parser<ParserDummy>::parse(Parser<ParserDummy>::Context&, ParserDummy&) (Parser.hpp:219)
      ==23291==    by 0x80671C4: ndb_mgm_call(ndb_mgm_handle*, ParserRow<ParserDummy> const*, char const*, Properties const*) (mgmapi.cpp:355)
      ==23291==    by 0x806AB79: ndb_mgm_listen_event_internal(ndb_mgm_handle*, int const*, int) (mgmapi.cpp:1419)
      ==23291==    by 0x806AC1F: ndb_mgm_listen_event (mgmapi.cpp:1434)
      ==23291==    by 0x805EB5D: event_thread_run(void*) (CommandInterpreter.cpp:467)
      ==23291==    by 0x806F70A: ndb_thread_wrapper (NdbThread.c:68)
      ==23291==    by 0x4042340: start_thread (in /lib/tls/i686/cmov/libpthread-2.3.6.so)
      ==23291==    by 0x429D4ED: clone (in /lib/tls/i686/cmov/libc-2.3.6.so)
      
      
      ndb/src/mgmapi/mgmapi.cpp:
        fix memory leak for mgmapi event listeners (1 per connect)
        
        (missing delete of reply Properties object returned by ndb_mgm_call)
      105ed9de
    • unknown's avatar
      BUG#21670 memory leak in ndb_mgm -e show · 60a0e3d0
      unknown authored
      fix the following valgrind warning when running ndb_mgm -e show (leak only in client)
      
      ==20398== 14,596 (11,936 direct, 2,660 indirect) bytes in 4 blocks are definitely lost in loss record 24 of 25
      ==20398==    at 0x401C4A1: malloc (vg_replace_malloc.c:149)
      ==20398==    by 0x80797A3: ConfigValuesFactory::create(unsigned, unsigned) (ConfigValues.cpp:309)
      ==20398==    by 0x8079F03: ConfigValuesFactory::expand(unsigned, unsigned) (ConfigValues.cpp:325)
      ==20398==    by 0x8079967: ConfigValuesFactory::put(ConfigValues::Entry const&) (ConfigValues.cpp:414)
      ==20398==    by 0x807A7B6: ConfigValuesFactory::unpack(void const*, unsigned) (ConfigValues.cpp:701)
      ==20398==    by 0x806CB9D: ConfigValuesFactory::unpack(UtilBuffer const&) (ConfigValues.hpp:252)
      ==20398==    by 0x8069160: ndb_mgm_get_configuration (mgmapi.cpp:1941)
      ==20398==    by 0x8060661: CommandInterpreter::executeShow(char*) (CommandInterpreter.cpp:1242)
      ==20398==    by 0x8063966: CommandInterpreter::execute_impl(char const*) (CommandInterpreter.cpp:715)
      ==20398==    by 0x8064040: CommandInterpreter::execute(char const*, int, int*) (CommandInterpreter.cpp:625)
      ==20398==    by 0x8064189: Ndb_mgmclient::execute(char const*, int, int*) (CommandInterpreter.cpp:203)
      ==20398==    by 0x805E56C: read_and_execute(int) (main.cpp:124)
      ==20398==    by 0x805E754: main (main.cpp:162)
      ==20398==
      
      
      ndb/src/mgmclient/CommandInterpreter.cpp:
        correctly free (destroy) the configuration fetched for show
      60a0e3d0
  2. 15 Aug, 2006 2 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · f32014a9
      unknown authored
      into  willster.(none):/home/stewart/Documents/MySQL/5.0/ndb
      
      
      f32014a9
    • unknown's avatar
      BUG#20823 testBackup FailMaster failing · 5cafb623
      unknown authored
        
      few cases not handled properly (NF occurs).
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Don't write fragment info if we haven't retreived any fragment info yet
        (FailMaster test 2)
            
        Go directly onto closing files if the tabPtr is RNIL (as we're in recovery)
      5cafb623
  3. 14 Aug, 2006 5 commits
    • unknown's avatar
      Merge baker@bk-internal.mysql.com:/home/bk/mysql-5.0 · 61d5563b
      unknown authored
      into  zim.(none):/home/brian/mysql/dep-5.0
      
      
      61d5563b
    • unknown's avatar
      Fix a test case (proper clean up). · 492e7b08
      unknown authored
      
      mysql-test/r/mysqldump.result:
        Update results.
      mysql-test/t/mysqldump.test:
        Fix a bug in the test case that left user mysqltest_1@localhost 
        around (this broke furhter tests).
      492e7b08
    • unknown's avatar
      Merge may.pils.ru:/home/svoj/devel/mysql/BUG18874/mysql-4.1 · 867f7368
      unknown authored
      into  may.pils.ru:/home/svoj/devel/mysql/BUG18874/mysql-5.0
      
      
      myisam/sort.c:
        Auto merged
      mysql-test/r/repair.result:
        Auto merged
      mysql-test/t/repair.test:
        Auto merged
      867f7368
    • unknown's avatar
      BUG#18874 - Setting myisam_repair_threads > 1, index cardinality always 1 · f6d7985a
      unknown authored
      Fixed by moving update_key_parts() down to be after write_index().
      
      
      myisam/sort.c:
        write_index() collects index statistic which is further used in
        update_key_parts(). Thus update_key_parts() must be called after
        write_index().
      mysql-test/r/repair.result:
        Test case for bug#18874.
      mysql-test/t/repair.test:
        Test case for bug#18874.
      f6d7985a
    • unknown's avatar
      Fix for bug#20648 We introduce a new field method for knowing "real size", and... · ba8be739
      unknown authored
      Fix for bug#20648 We introduce a new field method for knowing "real size", and we now in archive null unused bits of a row to null before writing. 
      
      
      sql/field.cc:
        data_length for field needs to be calculated directly.
      sql/field.h:
        The new method data_length() returns the "real" length of the field.
      sql/ha_archive.cc:
        Before a write_row() archive nulls space beyond the size of the row in varchars to make sure that compression only sees NULL.
      ba8be739
  4. 11 Aug, 2006 2 commits
  5. 10 Aug, 2006 3 commits
    • unknown's avatar
      Merge updates. · 12eb42ac
      unknown authored
      
      mysql-test/r/grant2.result:
        Merge update:  Change between versions, it appears.
      mysql-test/r/heap_btree.result:
        Merge update:  Add deterministic ordering of data, as the order is different 
        between versions.
      mysql-test/r/mysql_client.result:
        Merge update: Help options changed between versions.
      mysql-test/t/heap_btree.test:
        Merge update:  Add deterministic ordering of data, as the order is different 
        between versions.
      BitKeeper/deleted/.del-bug20328.test~c76d766fe3e1eb5:
        Delete: mysql-test/t/bug20328.test
      BitKeeper/deleted/.del-bug20328.result~4fee68989442c2a3:
        Delete: mysql-test/r/bug20328.result
      12eb42ac
    • unknown's avatar
      Removed Iggy's accidentally-added files. · 78c9885f
      unknown authored
      78c9885f
    • unknown's avatar
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-4.1 · d278381e
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0
      
      
      client/mysql.cc:
        Auto merged
      heap/hp_delete.c:
        Auto merged
      mysql-test/t/mysqlbinlog.test:
        Auto merged
      scripts/fill_func_tables.sh:
        Auto merged
      scripts/mysql_install_db.sh:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      mysql-test/r/grant2.result:
        Manual merge
      mysql-test/r/heap_btree.result:
        Manual merge
      mysql-test/r/mysql_client.result:
        Manual merge
      mysql-test/t/grant2.test:
        Manual merge
      mysql-test/t/heap_btree.test:
        Manual merge
      mysql-test/t/mysql_client.test:
        Manual merge
      d278381e
  6. 09 Aug, 2006 5 commits
    • unknown's avatar
      Merge may.pils.ru:/home/svoj/devel/mysql/BUG20060/mysql-4.1 · 51bb3b2a
      unknown authored
      into  may.pils.ru:/home/svoj/devel/mysql/BUG20060/mysql-5.0
      
      
      myisam/mi_update.c:
        Auto merged
      51bb3b2a
    • unknown's avatar
      BUG#20060 - mysqld option "--flush " doesn't work for update statement · a2a5f2b5
      unknown authored
      Problem described in this bug report affects MyISAM tables only.
      
      Running mysqld --flush instructs mysqld to sync all changes to disk
      after each SQL statement. It worked well for INSERT and DELETE
      statements, but it did sync for UPDATE only in case if there was
      index change (change of colum that has an index). If no updated column
      has an index, data wasn't synced to disk.
      
      This fix makes UPDATE statement to sync data to disk even if there is
      no index change (that is only data change) and mysqld is run with
      --flush option.
      
      
      myisam/mi_update.c:
        Every myisam function that updates myisam table must end with
        call to _mi_writeinfo(). If operation (second param of
        _mi_writeinfo()) is not 0 it sets share->changed to 1, that is
        flags that data has changed. If operation is 0, this function
        equals to no-op in this case.
        
        mi_update() must always pass !0 value as operation, since even if
        there is no index change there could be data change.
      a2a5f2b5
    • unknown's avatar
      remove undeeded printing of newline. · 1bd553d4
      unknown authored
      
      ndb/src/ndbapi/ClusterMgr.cpp:
        remove extra 'ndbout << endl'
      1bd553d4
    • unknown's avatar
      BUG#13985 · 7fcb36e2
      unknown authored
      fixups after review by jonas
      
      
      ndb/src/mgmclient/CommandInterpreter.cpp:
        Guard the print mutex when running SHOW
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        replace global_flag_send_heartbeat_now with forceHB()/updateStatus()
        
        don't use bitmask as parameter to forceHB to reflect reality of what the
        function does.
        
        remove get_connected_ndb_nodes() as it is no longer used
      ndb/src/mgmsrv/MgmtSrvr.hpp:
        remove unused get_connected_ndb_nodes()
        
        update updateStatus prototype
      ndb/src/mgmsrv/Services.cpp:
        use new prototype for updateStatus() - doesn't accept NodeBitmask
      ndb/src/ndbapi/ClusterMgr.cpp:
        remove global_flag_send_heartbeat_now, replace with forceHB.
        
        compute bitmask of nodes to send HB to in forceHB
      ndb/src/ndbapi/ClusterMgr.hpp:
        update prototype for forceHB, don't give the illusion that NodeBitmask means much.
      7fcb36e2
    • unknown's avatar
      sql_view.cc: · 4abe4b17
      unknown authored
        After merge fix
      
      
      sql/sql_view.cc:
        After merge fix
      4abe4b17
  7. 08 Aug, 2006 5 commits
  8. 07 Aug, 2006 1 commit
    • unknown's avatar
      sql_view.cc: · 55bd1096
      unknown authored
        Memory leak fix
      
      
      sql/sql_view.cc:
        Memory leak fix
      55bd1096
  9. 06 Aug, 2006 3 commits
  10. 03 Aug, 2006 12 commits