1. 08 Aug, 2005 6 commits
    • unknown's avatar
      item_strfunc.cc: · 10805ec2
      unknown authored
        BUG #11104 
            Took out the offset-=delimiter_length-1 out of the for loop. It was causing
            basically this: 
            select substring_index('the king of the the hill', 'the', -2) to not work.
            The first iteration, offset would be initialised to 24, then strstr would 
            point at 'the king of the the* hill' ('*'means right before the 
            character following), returning a offset of 16. The for loop would then 
            decrement offset by two (3 - 1), to 14, now pointing at 
            "the king of th*e the hill", _skipping_ past the 'e' in the second to last
            'the', and therefore strstr would never have a chance of matching the 
            second to last 'the', then moving on to the 'the' at the begginning of the 
            string!
            In a nutshell, offset was being decremented by too great a value, preventing
            the second to last 'the' from being ever found, hence the result of 
            'king of the the hill' from the query that is reported in the bug report
      func_str.test:
        BUG #11104
        Added tests to make sure fix addresses issues in original bug report
      func_str.result:
        BUG #11104 
        New results for new tests
      
      
      mysql-test/r/func_str.result:
        BUG #11104 
        
        New results for new tests
      mysql-test/t/func_str.test:
        BUG #11104
        
        Added tests to make sure fix addresses issues in original bug report
      sql/item_strfunc.cc:
        BUG #11104 
            Took out the offset-=delimiter_length-1 out of the for loop. It was causing
            basically this: 
            select substring_index('the king of the the hill', 'the', -2) to not work.
            The first iteration, offset would be initialised to 24, then strstr would 
            point at 'the king of the the* hill' ('*'means right before the 
            character following), returning a offset of 16. The for loop would then 
            decrement offset by two (3 - 1), to 14, now pointing at 
            "the king of th*e the hill", _skipping_ past the 'e' in the second to last
            'the', and therefore strstr would never have a chance of matching the 
            second to last 'the', then moving on to the 'the' at the begginning of the 
            string!
        
            In a nutshell, offset was being decremented by too great a value, preventing
            the second to last 'the' from being ever found, hence the result of 
            'king of the the hill' from the query that is reported in the bug report
      10805ec2
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · e6301003
      unknown authored
      into  mysql.com:/usr/home/bar/mysql-4.1.b10892
      
      
      e6301003
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 00267b9f
      unknown authored
      into  mysql.com:/usr/home/bar/mysql-4.1.b10892
      
      
      00267b9f
    • unknown's avatar
      item.cc: · b9ffa4db
      unknown authored
        After review fix
      
      
      sql/item.cc:
        After review fix
      b9ffa4db
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 00e74048
      unknown authored
      into  mishka.local:/home/my/mysql-4.1
      
      
      00e74048
    • unknown's avatar
      Fix for BUG #11642: [Patch]es x86 Assembler and text relocations · 38b4ccf5
      unknown authored
      Changed assembler functions to not access global variables or variables in text segement
      Added wrapper function in C to longlong2str() to pass _dig_vec_upper as an argument
      
      
      mysql-test/r/bigint.result:
        More tests for parsing of bigint's
        More tests for different values to conv()
      mysql-test/t/bigint.test:
        More tests for parsing of bigint's
        More tests for different values to conv()
      strings/Makefile.am:
        Added longlong2str_asm.c
      strings/longlong2str-x86.s:
        Changed functions to not access variables in text segment
        Fixed this by adding global variable '_dig_vec_upper' as an argument to longlong2str_with_dig_vector()
      strings/my_strtoll10-x86.s:
        Removd array lfactor by calculating the value in code
        (this is to to make the code position independent)
      strings/longlong2str_asm.c:
        New BitKeeper file ``strings/longlong2str_asm.c''
      38b4ccf5
  2. 07 Aug, 2005 6 commits
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-4.1 · 23095e27
      unknown authored
      into rurik.mysql.com:/home/igor/mysql-4.1
      
      
      23095e27
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.1 · 25201f23
      unknown authored
      into  mysql.com:/home/mydev/mysql-4.1-4100
      
      
      25201f23
    • unknown's avatar
      subselect.result: · 84d34d9d
      unknown authored
        Added test case for bug #11867.
        Fixed results for two existing test cases.
      subselect.test:
        Added test case for bug #11867.
      item_subselect.cc:
        Fixed bug #11867.
        Added missing code in Item_in_subselect::row_value_transformer
        that caused problems for queries with
        ROW(elems) IN (SELECT DISTINCT cols FROM ...).
      
      
      sql/item_subselect.cc:
        Fixed bug #11867.
        Added missing code in Item_in_subselect::row_value_transformer
        that caused problems for queries with
        ROW(elems) IN (SELECT DISTINCT cols FROM ...).
      mysql-test/t/subselect.test:
        Added test case for bug #11867.
      mysql-test/r/subselect.result:
        Added test case for bug #11867.
        Fixed results for two existing test cases.
      84d34d9d
    • unknown's avatar
      BUG#11869: part2: post-review fixes: · b9e04cf1
      unknown authored
      In init_prepare_fake_select_lex() don't empty ftfunc_list. UNION's ORDER BY clause may 
      contain MATCH(...), for which fix_index() should be called.
      
      
      mysql-test/r/fulltext_order_by.result:
        BUG#11869 part2 : added another test case
      mysql-test/t/fulltext_order_by.test:
        BUG#11869 part2 : added another test case
      b9e04cf1
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.1 · 1ab80cf4
      unknown authored
      into  mysql.com:/home/mydev/mysql-4.1-4100
      
      
      1ab80cf4
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-4.1 · 1b431c42
      unknown authored
      into mysql.com:/home/psergey/mysql-4.1-bug11869-part2
      
      
      1b431c42
  3. 06 Aug, 2005 1 commit
    • unknown's avatar
      BUG#11869 (cont'd, eliminating "table type doesn't support FULLTEXT" error): · 852dcb75
      unknown authored
      When creating temporary table for UNION, pass TMP_TABLE_FORCE_MYISAM flag to 
      create_tmp_table if we will be using fulltext function(s) when reading from the 
      temp. table.
      
      
      mysql-test/r/fulltext_order_by.result:
        Testcase for BUG#11869 (cont'd, eliminating "table type doesn't support FULLTEXT" error)
      mysql-test/t/fulltext_order_by.test:
        Testcase for BUG#11869 (cont'd, eliminating "table type doesn't support FULLTEXT" error)
      sql/mysql_priv.h:
        BUG#11869 (cont'd, eliminating "table type doesn't support FULLTEXT" error):
        Added TMP_TABLE_FORCE_MYISAM flag
      sql/sql_select.cc:
        BUG#11869 (cont'd, eliminating "table type doesn't support FULLTEXT" error):
        In create_tmp_table(), honor the TMP_TABLE_FORCE_MYISAM flag
      852dcb75
  4. 05 Aug, 2005 1 commit
    • unknown's avatar
      Bug#9459 - deadlock with flush with lock, and lock table write · 2977a3a4
      unknown authored
      Added a check before taking a global read lock if
      the own thread has a write locked table.
      
      
      mysql-test/r/flush.result:
        Bug#9459 - deadlock with flush with lock, and lock table write
        The test result.
      mysql-test/t/flush.test:
        Bug#9459 - deadlock with flush with lock, and lock table write
        The test case.
      2977a3a4
  5. 04 Aug, 2005 20 commits
  6. 03 Aug, 2005 6 commits
    • unknown's avatar
      BUG#12330 Adding updated result file which I missed in last changeset. · 357ebcc2
      unknown authored
      Adds --replace_column to make test results deterministic.
      
      
      mysql-test/r/rpl_slave_status.result:
        BUG#12330 updated result file which I missed in last changeset
        This updates the test to use --replace_column to make the test
        deterministic.
      357ebcc2
    • unknown's avatar
      Merge mysql.com:/Users/emurphy/src/bk-clean/mysql-4.1 · 6743d718
      unknown authored
      into  mysql.com:/Users/emurphy/src/work/mysql-4.1-bug12330
      
      
      6743d718
    • unknown's avatar
      BUG#12330 Add --replace_column in order to make test deterministic. · e3036421
      unknown authored
      
      mysql-test/t/rpl_slave_status.test:
        Add --replace-column to make show slave status deterministic
      e3036421
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-4.1 · 1764a75f
      unknown authored
      into mysql.com:/M41/mysql-4.1
      
      
      1764a75f
    • unknown's avatar
      Manual merge: Current 4.1.14 has precedence over 4.1.10b · d868eaf4
      unknown authored
      
      BitKeeper/etc/config:
        Auto merged
      VC++Files/client/mysql.dsp:
        Auto merged
      VC++Files/client/mysqladmin.dsp:
        Auto merged
      VC++Files/client/mysqlcheck.dsp:
        Auto merged
      VC++Files/client/mysqldump.dsp:
        Auto merged
      VC++Files/client/mysqlimport.dsp:
        Auto merged
      VC++Files/client/mysqlshow.dsp:
        Auto merged
      VC++Files/client/mysqltest.dsp:
        Auto merged
      VC++Files/mysql-test/mysql_test_run_new.dsp:
        Auto merged
      VC++Files/mysqlbinlog/mysqlbinlog.dsp:
        Auto merged
      VC++Files/mysqlcheck/mysqlcheck.dsp:
        Auto merged
      VC++Files/mysqlmanager/mysqlmanager.dsp:
        Auto merged
      acinclude.m4:
        Auto merged
      zlib/ChangeLog:
        Auto merged
      zlib/FAQ:
        Auto merged
      zlib/INDEX:
        Auto merged
      zlib/README:
        Auto merged
      zlib/crc32.c:
        Auto merged
      zlib/deflate.c:
        Auto merged
      zlib/deflate.h:
        Auto merged
      zlib/gzio.c:
        Auto merged
      zlib/infback.c:
        Auto merged
      zlib/inffast.c:
        Auto merged
      zlib/inflate.c:
        Auto merged
      zlib/inftrees.c:
        Auto merged
      zlib/inftrees.h:
        Auto merged
      zlib/trees.c:
        Auto merged
      zlib/zconf.h:
        Auto merged
      zlib/zlib.3:
        Auto merged
      zlib/zlib.h:
        Auto merged
      zlib/zutil.h:
        Auto merged
      d868eaf4
    • unknown's avatar
      Merge lgrimmer@bk-internal.mysql.com:/home/bk/mysql-4.1 · bb10cc45
      unknown authored
      into mysql.com:/space/my/mysql-4.1
      
      
      bb10cc45