1. 01 Feb, 2008 18 commits
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge · 10aaf68b
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      client/mysqlbinlog.cc:
        Auto merged
      10aaf68b
    • unknown's avatar
      Fixes to make tests pass in pushbuild. · f72adc70
      unknown authored
      
      mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result:
        Result change.
      mysql-test/suite/binlog/t/binlog_start_comment.test:
        Removing --short-form since that cause test to fail.
      f72adc70
    • unknown's avatar
      Merge cbell@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl-merge · c078b5c5
      unknown authored
      into  mysql_cab_desk.:D:/source/c++/mysql-5.0-rpl-merge
      
      
      c078b5c5
    • unknown's avatar
      BUG#32205 : Replaying statements from mysqlbinlog fails with a syntax error, replicates fine · b0747b45
      unknown authored
      This patch adds code to convert the path for LOAD DATA INFILE 
      events to a Unix path which is needed for running mysql client
      on Windows. 
      
      
      client/mysqlbinlog.cc:
        BUG#32205 : Replaying statements from mysqlbinlog fails with a syntax error, replicates fine
        
        This patch adds code to convert the path for LOAD DATA INFILE 
        events to a Unix path which is needed for running mysql client
        on Windows. 
        
        The 'd:\x\y\z' path becomes 'd:xyz' when run in the client.
      b0747b45
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge · 44e89ac0
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      mysql-test/r/mysqlbinlog.result:
        Auto merged
      mysql-test/t/mysqlbinlog.test:
        SCCS merged
      44e89ac0
    • unknown's avatar
      Again blanking out some numbers in file names that is dependent · 0a9fa826
      unknown authored
      on the context.
      
      
      mysql-test/r/mysqlbinlog.result:
        Result file change.
      mysql-test/t/mysqlbinlog.test:
        Blanking out yet some numbers in file names.
      0a9fa826
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge · 7fabc514
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      mysql-test/r/mysqlbinlog.result:
        Auto merged
      mysql-test/t/mysqlbinlog.test:
        Auto merged
      7fabc514
    • unknown's avatar
      Fixes to make tests pass in pushbuild. · 818358ed
      unknown authored
      
      mysql-test/r/mysqlbinlog.result:
        Result file change.
      mysql-test/t/mysqlbinlog.test:
        Fixing test to not be dependent on the sequence numbers
        for file names generated by mysqlbinlog.
      818358ed
    • unknown's avatar
      Fixes to makes tests pass on Windows and vanilla build. · 1e40902c
      unknown authored
      
      mysql-test/suite/binlog/t/binlog_old_versions.test:
        MYSQL_BINLOG was missing --local-load option.
        MYSQL was missing --local-infile=1 option.
      1e40902c
    • unknown's avatar
      Re-creating binlog_start_comment.test to make sure that changes · 2d57d780
      unknown authored
      are propagated from earlier versions.
      
      
      BitKeeper/deleted/.del-binlog_start_comment.result:
        Delete: mysql-test/suite/binlog/r/binlog_start_comment.result
      mysql-test/suite/binlog/r/binlog_start_comment.result:
        Rename: mysql-test/suite/r/binlog_start_comment.result -> mysql-test/suite/binlog/r/binlog_start_comment.result
      BitKeeper/deleted/.del-binlog_start_comment.test:
        Delete: mysql-test/suite/binlog/t/binlog_start_comment.test
      mysql-test/suite/binlog/t/binlog_start_comment.test:
        Rename: mysql-test/suite/t/binlog_start_comment.test -> mysql-test/suite/binlog/t/binlog_start_comment.test
      2d57d780
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge · 32555d82
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      BitKeeper/deleted/.del-binlog_start_comment.test:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        Auto merged
      mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test:
        Auto merged
      32555d82
    • unknown's avatar
      Various fixes to make tests pass on Windows. · d3151177
      unknown authored
      
      mysql-test/r/mix_innodb_myisam_binlog.result:
        Result change
      mysql-test/t/binlog_start_comment.test:
        Adding --local-load to mysqlbinlog to prevent it from failing
        on Windows. Also adding --short-form.
      mysql-test/t/mix_innodb_myisam_binlog.test:
        Extending LIKE pattern to use either \n or \r\n in order to work
        on Windows.
      d3151177
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge · bae60143
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      BitKeeper/deleted/.del-binlog_start_comment.test:
        Auto merged
      include/my_sys.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      bae60143
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-rpl-merge · 050fffcf
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      BitKeeper/deleted/.del-bdb_notembedded.result:
        Auto merged
      BitKeeper/deleted/.del-strict_autoinc_4bdb.result:
        Auto merged
      050fffcf
    • unknown's avatar
      Committing premature delete (the file will be deleted in a soon-to-come cset). · 594c7b59
      unknown authored
      .del-strict_autoinc_4bdb.result:
        Delete: mysql-test/r/strict_autoinc_4bdb.result
      strict_autoinc_4bdb.result:
        Rename: BitKeeper/deleted/.del-strict_autoinc_4bdb.result -> mysql-test/r/strict_autoinc_4bdb.result
      
      
      BitKeeper/deleted/.del-strict_autoinc_4bdb.result:
        Delete: mysql-test/r/strict_autoinc_4bdb.result
      594c7b59
    • unknown's avatar
      Fixing result files to make tests pass in pushbuild. · 25d49490
      unknown authored
      
      BitKeeper/deleted/.del-bdb_notembedded.result:
        Delete: mysql-test/r/bdb_notembedded.result
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        Result file held binlog for row-based replication,
        but test is for statement-based replication.
      25d49490
    • unknown's avatar
      Deleting Berkeley DB test files since BDB is not distributed with 5.1. · e5312b4e
      unknown authored
      .del-bdb_notembedded.test:
        Delete: mysql-test/t/bdb_notembedded.test
      .del-strict_autoinc_4bdb.result:
        Delete: mysql-test/r/strict_autoinc_4bdb.result
      .del-bdb_notembedded.result:
        Delete: mysql-test/r/bdb_notembedded.result
      
      
      BitKeeper/deleted/.del-bdb_notembedded.test:
        Delete: mysql-test/t/bdb_notembedded.test
      BitKeeper/deleted/.del-bdb_notembedded.result:
        Delete: mysql-test/r/bdb_notembedded.result
      BitKeeper/deleted/.del-strict_autoinc_4bdb.result:
        Delete: mysql-test/r/strict_autoinc_4bdb.result
      e5312b4e
    • unknown's avatar
      Changes to make tests pass on vanilla build. · 1b150185
      unknown authored
      
      mysql-test/t/binlog_start_comment.test:
        Adding --local-infile=1 to enable local infile for mysql client.
      1b150185
  2. 31 Jan, 2008 6 commits
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1 · a36faa7e
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      client/client_priv.h:
        Auto merged
      include/my_sys.h:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/lib/mtr_report.pl:
        Auto merged
      mysql-test/suite/rpl/t/rpl_err_ignoredtable.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/set_var.h:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      mysql-test/suite/rpl/r/rpl_invoked_features.result:
        Manual merge.
      mysql-test/suite/rpl/t/rpl_invoked_features.test:
        Manual merge.
      sql/log.cc:
        Manual merge.
      a36faa7e
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0 · dc8e43ed
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge
      
      
      include/my_sys.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      dc8e43ed
    • unknown's avatar
      Fixes to make tests pass on pushbuild. · 681bf14e
      unknown authored
      
      mysql-test/suite/rpl/t/rpl_loaddata_map-master.opt:
        Rename: mysql-test/t/rpl_loaddata_map-master.opt -> mysql-test/suite/rpl/t/rpl_loaddata_map-master.opt
      mysql-test/suite/rpl/t/rpl_loaddata_map-slave.opt:
        Rename: mysql-test/t/rpl_loaddata_map-slave.opt -> mysql-test/suite/rpl/t/rpl_loaddata_map-slave.opt
      mysql-test/include/show_binlog_events2.inc:
        Binlog position change.
      mysql-test/suite/rpl/r/rpl_loaddata_map.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_user.result:
        Result change.
      mysql-test/suite/rpl/t/rpl_loaddata_map.test:
        Test is only sensible to execute for statement and mixed mode.
      mysql-test/suite/rpl/t/rpl_user.test:
        Test assumed that binary log is identical for row- and statement-
        based logging, which it was not. Deleting users individually
        on master and slave respectively, without involving binary
        log.
      681bf14e
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge · f7c56990
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      BitKeeper/deleted/.del-binlog_start_comment.test:
        Auto merged
      mysql-test/suite/rpl/t/rpl_sp.test:
        Manual merge
      sql/sql_repl.cc:
        Manual merge
      f7c56990
    • unknown's avatar
      Changes to fix tests in pushbuild. · 1fa51318
      unknown authored
      
      mysql-test/include/have_local_infile.inc:
        BitKeeper file /data0/mkindahl/mysql-5.0-rpl-merge/mysql-test/include/have_local_infile.inc
      mysql-test/r/have_local_infile.require:
        BitKeeper file /data0/mkindahl/mysql-5.0-rpl-merge/mysql-test/r/have_local_infile.require
      mysql-test/t/binlog_start_comment.test:
        Test requires that local_infile is on, so added require for that.
      mysql-test/t/rpl_sp.test:
        Adding missing sync_slave_with_master causing following tests to fail.
      1fa51318
    • unknown's avatar
      Fixes to make code compile on Windows. · 34b9c6f5
      unknown authored
      
      sql/sql_repl.cc:
        Adding cast to remove compile error on Windows platform.
      34b9c6f5
  3. 30 Jan, 2008 12 commits
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge · ee24d7b1
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      BitKeeper/deleted/.del-rpl_transaction.test:
        Auto merged
      include/my_sys.h:
        Auto merged
      mysql-test/extra/binlog_tests/blackhole.test:
        Auto merged
      mysql-test/r/case.result:
        Auto merged
      mysql-test/r/mysqlbinlog2.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_blackhole.result:
        Auto merged
      mysql-test/t/case.test:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      ee24d7b1
    • unknown's avatar
      Disabling rpl_transaction test for non-debug builds. · 79f20964
      unknown authored
      
      mysql-test/t/rpl_transaction.test:
        Test only works for debug build.
      79f20964
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl · 7b8ec92e
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      7b8ec92e
    • unknown's avatar
      Fixing return value. · b0283afb
      unknown authored
      
      sql/item_cmpfunc.cc:
        Minor fix to return correct value in case of error.
      sql/rpl_utility.cc:
        Minor fix to return correct value in case of error.
      b0283afb
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl · b3954904
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      BitKeeper/deleted/.del-show_binlog_events2.inc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      b3954904
    • unknown's avatar
      .del-show_binlog_events2.inc: · 401628a1
      unknown authored
        Delete: mysql-test/include/show_binlog_events2.inc
      
      
      BitKeeper/deleted/.del-show_binlog_events2.inc:
        Delete: mysql-test/include/show_binlog_events2.inc
      401628a1
    • unknown's avatar
      Post-merge changes. · 101c30cc
      unknown authored
      
      BitKeeper/deleted/.del-show_binlog_events2.inc:
        Delete: mysql-test/include/show_binlog_events2.inc
      client/mysqlbinlog.cc:
        char -> uchar for raw memory.
      sql/item_cmpfunc.cc:
        Adding cast to remove warning when converting negative integer
        to unsigned type.
      sql/log_event.cc:
        char -> uchar for raw memory.
      sql/log_event.h:
        char -> uchar for raw memory.
      sql/rpl_utility.cc:
        Adding cast to remove warning when converting negative integer
        to unsigned type.
      sql/slave.cc:
        char -> uchar for raw memory.
      sql/sql_repl.cc:
        char -> uchar for raw memory.
      sql-common/client.c:
        char -> uchar for raw memory.
      101c30cc
    • unknown's avatar
      Changes to make tests pass in pushbuild. · 55fbcacf
      unknown authored
      
      mysql-test/r/bdb_notembedded.result:
        Result change.
      mysql-test/r/rpl_loaddata_map.result:
        Result change.
      mysql-test/t/rpl_loaddata_map.test:
        Blanking out file id as well.
      55fbcacf
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl · 9a51d88b
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      BitKeeper/deleted/.del-binlog_start_comment.result:
        Auto merged
      include/my_sys.h:
        Auto merged
      mysql-test/extra/binlog_tests/blackhole.test:
        Auto merged
      mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test:
        Auto merged
      mysql-test/r/case.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_blackhole.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_000015.result:
        Auto merged
      mysql-test/suite/rpl/t/rpl_000015.test:
        Auto merged
      mysql-test/t/case.test:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      BitKeeper/deleted/.del-binlog_start_comment.test:
        Using remote file.
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        Manual merge. Taking remote file to update result set after merge,
      mysql-test/suite/rpl/r/rpl_row_tabledefs_2myisam.result:
        Manual merge.
      mysql-test/suite/rpl/r/rpl_row_tabledefs_3innodb.result:
        Manual merge.
      9a51d88b
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl · 817bfa35
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      sql/sql_parse.cc:
        Auto merged
      include/my_sys.h:
        Manual merge
      mysql-test/suite/rpl/r/rpl_grant.result:
        Manual merge
      sql/sql_acl.cc:
        Manual merge
      sql/sql_repl.cc:
        Manual merge
      817bfa35
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl · 20677056
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge
      
      
      include/my_sys.h:
        Auto merged
      mysql-test/r/blackhole.result:
        Auto merged
      mysql-test/r/case.result:
        Auto merged
      mysql-test/r/mysqlbinlog2.result:
        Auto merged
      mysql-test/t/blackhole.test:
        Auto merged
      mysql-test/t/case.test:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      20677056
    • unknown's avatar
      Merge zhe@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · 7faa7d60
      unknown authored
      into  mail.hezx.com:/media/sda3/work/mysql/bkwork/bug26489_corruption_in_relay_log/5.0
      
      
      7faa7d60
  4. 29 Jan, 2008 3 commits
    • unknown's avatar
      Test changes to fix failures in pushbuild. · b0f52885
      unknown authored
      
      mysql-test/include/show_binlog_events.inc:
        Replacing file_id=N with file_id=# to avoid result mismatches
      mysql-test/suite/binlog/r/binlog_killed_simulate.result:
        Result change
      mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result:
        Result change
      mysql-test/suite/binlog/r/binlog_stm_blackhole.result:
        Result change
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        Result change
      mysql-test/suite/binlog/t/binlog_stm_mix_innodb_myisam.test:
        Binlog positions differ between mixed and statement based replication.
      mysql-test/suite/rpl/r/rpl_stm_log.result:
        Result change
      b0f52885
    • unknown's avatar
      update test result · 6766554f
      unknown authored
      
      mysql-test/r/rpl_grant.result:
        update result
      6766554f
    • unknown's avatar
      BUG#26489 Corruption in relay logs · 5a039fa2
      unknown authored
      Here is the scenario that causes the failure.(by Mats)
      
      1. The to-be corrupt log event (let's call it X), is split into two
         packets B and C on the network level (net_write_buff()). The parts
         are X = (x',x''). The part x' ends up in packet B and part x''
         ends up in packet C. Prior to the corrupt event X, the event Y has
         been written successfully, but has been split into two packets as
         well, which we call (y',y'').
      2. The master sends packet A = (y'',x') to the slave, increases the
         packet sequence number, the slave receives the packet, but fails
         to reply before the master gets a timeout.
      3. Since the master got a timeout, it reports failure, and aborts
         sending the binary log by exiting mysql_binlog_send(). However, it
         leaves the buffer intact, still holding y'' (but not x', since the
         write_pos is not increased).
      4. After exiting mysql_binlog_send(), the master does a
         disconnection of the client thread, which involves sending an
         error message e to the client (i.e., the slave).
      5. In this case, net_write_buff() is used again, but this time the
         old contents of the packet is used so that the new packet is
         D = (y'',e). Note that this will use a new packet sequence number,
         since the packet number was increased in step 2.
      6. The slave receives the tail y'' of the Y log event, concatenates
         this with x' (which it already received), and writes the event
         (x',y'') it to the relay log since it hasn't noticed anything is
         amiss.
      7. It then tries to read more bytes, which is either e (if the length
         given for X just happened to match the length given for Y, or just
         plain garbage because the slave is out of sync with what is
         actually sent.
      8. After a while, the SQL thread tries to execute the event (x',y''),
         which is very likely to be just nonsense.
      
      The problem can be fixed by not resetting net->error after the call of 
      mysql_binlog_send, so the error message will not be sent and the connection
      will be closed.
      
      
      sql/sql_parse.cc:
        Do not reset net->error, if net->error == 2, we should not try to use the connection again
      5a039fa2
  5. 27 Jan, 2008 1 commit