- 27 Jul, 2007 1 commit
-
-
kostja@bodhi.(none) authored
between perm and temp tables. Review fixes. The original bug report complains that if we locked a temporary table with LOCK TABLES statement, we would not leave LOCK TABLES mode when this temporary table is dropped. Additionally, the bug was escalated when it was discovered than when a temporary transactional table that was previously locked with LOCK TABLES statement was dropped, futher actions with this table, such as UNLOCK TABLES, would lead to a crash. The problem originates from incomplete support of transactional temporary tables. When we added calls to handler::store_lock()/handler::external_lock() to operations that work with such tables, we only covered the normal server code flow and did not cover LOCK TABLES mode. In LOCK TABLES mode, ::external_lock(LOCK) would sometimes be called without matching ::external_lock(UNLOCK), e.g. when a transactional temporary table was dropped. Additionally, this table would be left in the list of LOCKed TABLES. The patch aims to address this inadequacy. Now, whenever an instance of 'handler' is destroyed, we assert that it was priorly external_lock(UNLOCK)-ed. All the places that violate this assert were fixed. This patch introduces no changes in behavior -- the discrepancy in behavior will be fixed when we start calling ::store_lock()/::external_lock() for all tables, regardless whether they are transactional or not, temporary or not.
-
- 25 Jul, 2007 3 commits
-
-
anozdrin/alik@ibm. authored
binary SHOW CREATE TABLE or SELECT FROM I_S. The problem is that mysqldump generates incorrect dump for a table with non-ASCII column name if the mysqldump's character set is ASCII. The fix is to: 1. Switch character_set_client for the mysqldump's connection to binary before issuing SHOW CREATE TABLE statement in order to avoid conversion. 2. Dump switch character_set_client statements to UTF8 and back for CREATE TABLE statement.
-
anozdrin/alik@ibm. authored
This allows 5.0 to work with 5.1 databases.
-
malff/marcsql@weblab.(none) authored
into weblab.(none):/home/marcsql/TREE/mysql-5.0-29959
-
- 24 Jul, 2007 1 commit
-
-
kostja@bodhi.(none) authored
into bodhi.(none):/opt/local/work/mysql-5.0-runtime
-
- 23 Jul, 2007 1 commit
-
-
malff/marcsql@weblab.(none) authored
In sql/sql_yacc.yy, use the %prec construct at the end of rule join_table
-
- 21 Jul, 2007 1 commit
-
-
kostja@bodhi.(none) authored
into bodhi.(none):/opt/local/work/mysql-5.0-runtime
-
- 20 Jul, 2007 5 commits
-
-
kent@kent-amd64.(none) authored
into mysql.com:/home/kent/bk/tmp3/mysql-5.0-build
-
evgen@moonbone.local authored
into moonbone.local:/mnt/gentoo64/work/29898-bug-5.0-opt-mysql
-
kostja@bodhi.(none) authored
-
joerg@trift-lap.none authored
into trift-lap.none:/MySQL/M50/push-5.0
-
df@pippilotta.erinye.com authored
into pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build
-
- 19 Jul, 2007 16 commits
-
-
gshchepa/uchum@gleb.loc authored
into gleb.loc:/home/uchum/work/bk/5.0-opt
-
df@pippilotta.erinye.com authored
into pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0.46
-
df@pippilotta.erinye.com authored
-
evgen@moonbone.local authored
The Item_date_typecast::val_int function doesn't reset null_value flag. This makes all values that follows the first null value to be treated as nulls and led to a wrong result. Now the Item_date_typecast::val_int function correctly sets the null_value flag for both null and non-null values.
-
joerg@trift2. authored
into trift2.:/MySQL/M50/push-5.0
-
evgen@moonbone.local authored
into moonbone.local:/mnt/gentoo64/work/29850-bug-5.0-opt-mysql
-
evgen@moonbone.local authored
a temporary table. The result string of the Item_func_group_concat wasn't initialized in the copying constructor of the Item_func_group_concat class. This led to a wrong charset of GROUP_CONCAT result when the select employs a temporary table. The copying constructor of the Item_func_group_concat class now correctly initializes the charset of the result string.
-
holyfoot/hf@hfmain.(none) authored
into mysql.com:/home/hf/work/29687/my50-29687
-
holyfoot/hf@hfmain.(none) authored
into mysql.com:/home/hf/work/29687/my50-29687
-
tsmith@bk-internal.mysql.com authored
into bk-internal.mysql.com:/data0/bk/tsmith-tmp/mysql-5.0-maint
-
kostja@bodhi.(none) authored
for consistency.
-
kostja@bodhi.(none) authored
No test case, since the bug requires a stress case with 30 INSERT DELAYED threads and 1 killer thread to repeat. The patch is verified manually. Review fixes. The server that is running DELAYED inserts would deadlock itself or crash under high load if some of the delayed threads were KILLed in the meanwhile. The fix is to change internal lock acquisition order of delayed inserts subsystem and to ensure that Delayed_insert::table_list::db does not point to volatile memory in some cases. For details, please see a comment for sql_insert.cc.
-
gshchepa/uchum@gleb.loc authored
into gleb.loc:/home/uchum/work/bk/5.0-opt
-
joerg@trift-lap.none authored
by renaming "include/md5.h" to "include/my_md5.h". Fixes bug#14151.
-
i5 compatibility
-
gshchepa/uchum@gleb.loc authored
into gleb.loc:/home/uchum/work/bk/5.0-opt
-
- 18 Jul, 2007 7 commits
-
-
gshchepa/uchum@gleb.loc authored
For each view the mysqldump utility creates a temporary table with the same name and the same columns as the view in order to satisfy views that depend on this view. After the creation of all tables, mysqldump drops all temporary tables and creates actual views. However, --skip-add-drop-table and --compact flags disable DROP TABLE statements for those temporary tables. Thus, it was impossible to create the views because of existence of the temporary tables with the same names.
-
kent@mysql.com/kent-amd64.(none) authored
Allow to set mysqld exe suffix
-
kostja@bodhi.(none) authored
function results in inconsistent behavior. The bug itself was fixed by the patch for bug 20662.
-
gkodinov/kgeorge@magare.gmz authored
table (datadir) Set errno when retunring an error in my_create_with_symlink.
-
kostja@bodhi.(none) authored
Fix the typo in the constructor. Cover a semantic check that previously never worked with a test.
-
kostja@bodhi.(none) authored
table. The bug itself is yet another manifestation of Bug 26141.
-
sergefp@mysql.com authored
-
- 17 Jul, 2007 5 commits
-
-
sergefp@mysql.com authored
-
joerg@trift2. authored
into trift2.:/MySQL/M50/push-5.0
-
joerg@trift2. authored
into trift2.:/MySQL/M50/push-5.0
-
sergefp@mysql.com authored
-
tsmith@ramayana.hindu.god authored
into ramayana.hindu.god:/home/tsmith/m/bk/maint/50
-