1. 11 Mar, 2014 2 commits
    • Michael Widenius's avatar
      Merge with 5.5 · 17278496
      Michael Widenius authored
      17278496
    • Michael Widenius's avatar
      Fixed a compiler failure and removed some warnings in windows · 800a278f
      Michael Widenius authored
      extra/replace.c:
        Removed compiler warning
      sql/unireg.cc:
        Removed compiler warning
      storage/maria/ma_blockrec.c:
        Removed compiler warning
      storage/maria/ma_dynrec.c:
        Fixed compiler failure
      storage/maria/ma_unique.c:
        Removed compiler warning
      storage/myisam/mi_check.c:
        Removed compiler warning
      storage/myisam/mi_checksum.c:
        Removed compiler warning
      800a278f
  2. 10 Mar, 2014 1 commit
    • Michael Widenius's avatar
      Fixed MDEV-5724 "Server crashes on SQL select containing more group by and... · 599eb0dc
      Michael Widenius authored
      Fixed MDEV-5724 "Server crashes on SQL select containing more group by and left join statements using innodb tables"
        
      The problem was that a big record was allocated on the stack, which casued stack to run out.
        
      Fixed by using my_safe_alloca() instead of my_alloca() when allocating records.
      Now only records <= 16384 are allocated on the stack.
      
      mysql-test/r/stack-crash.result:
        Added test case
      mysql-test/t/stack-crash.test:
        Added test case
      storage/maria/ma_blockrec.c:
        Use my_safe_alloca() instead of my_alloca()
      storage/maria/ma_dynrec.c:
        Use my_safe_alloca() instead of my_alloca()
      storage/maria/maria_def.h:
        Added MARIA_MAX_RECORD_ON_STACK
      storage/maria/maria_pack.c:
        Use my_safe_alloca() instead of my_alloca()
      599eb0dc
  3. 04 Mar, 2014 9 commits
  4. 03 Mar, 2014 2 commits
    • Sergey Petrunya's avatar
      MDEV-5778: Valgrind failure in innodb_ext_keys.test · 24d9bf82
      Sergey Petrunya authored
      - Fix valgrind failure: make test_if_order_by_key() account for extended keys 
        feature.
      24d9bf82
    • unknown's avatar
      MDEV-5764: START SLAVE UNTIL does not work with parallel replication · 641feed4
      unknown authored
      With parallel replication, there can be any number of events queued on
      in-memory lists in the worker threads.
      
      For normal STOP SLAVE, we want to skip executing any remaining events on those
      lists and stop as quickly as possible.
      
      However, for START SLAVE UNTIL, when the UNTIL position is reached in the SQL
      driver thread, we must _not_ stop until all already queued events for the
      workers have been executed - otherwise we would stop too early, before the
      actual UNTIL position had been completely reached.
      
      The code did not handle UNTIL correctly, stopping too early due to not
      executing the queued events to completion. Fix this, and also implement that
      an explicit STOP SLAVE in the middle (when the SQL driver thread has reached
      the UNTIL position but the workers have not) _will_ cause an immediate stop.
      641feed4
  5. 27 Feb, 2014 5 commits
  6. 26 Feb, 2014 5 commits
    • unknown's avatar
      6d3150c4
    • unknown's avatar
      MDEV-5657: Parallel replication. · e90f68c0
      unknown authored
      Clean up and improve the parallel implementation code, mainly related to
      scheduling of work to threads and handling of stop and errors.
      
      Fix a lot of bugs in various corner cases that could lead to crashes or
      corruption.
      
      Fix that a single replication domain could easily grab all worker threads and
      stall all other domains; now a configuration variable
      --slave-domain-parallel-threads allows to limit the number of
      workers.
      
      Allow next event group to start as soon as previous group begins the commit
      phase (as opposed to when it ends it); this allows multiple event groups on
      the slave to participate in group commit, even when no other opportunities for
      parallelism are available.
      
      Various fixes:
      
       - Fix some races in the rpl.rpl_parallel test case.
      
       - Fix an old incorrect assertion in Log_event iocache read.
      
       - Fix repeated malloc/free of wait_for_commit and rpl_group_info objects.
      
       - Simplify wait_for_commit wakeup logic.
      
       - Fix one case in queue_for_group_commit() where killing one thread would
         fail to correctly signal the error to the next, causing loss of the
         transaction after slave restart.
      
       - Fix leaking of pthreads (and their allocated stack) due to missing
         PTHREAD_CREATE_DETACHED attribute.
      
       - Fix how one batch of group-committed transactions wait for the previous
         batch before starting to execute themselves. The old code had a very
         complex scheduling where the first transaction was handled differently,
         with subtle bugs in corner cases. Now each event group is always scheduled
         for a new worker (in a round-robin fashion amongst available workers).
         Keep a count of how many transactions have started to commit, and wait for
         that counter to reach the appropriate value.
      
       - Fix slave stop to wait for all workers to actually complete processing;
         before, the wait was for update of last_committed_sub_id, which happens a
         bit earlier, and could leave worker threads potentially accessing bits of
         the replication state that is no longer valid after slave stop.
      
       - Fix a couple of places where the test suite would kill a thread waiting
         inside enter_cond() in connection with debug_sync; debug_sync + kill can
         crash in rare cases due to a race with mysys_var_current_mutex in this
         case.
      
       - Fix some corner cases where we had enter_cond() but no exit_cond().
      
       - Fix that we could get failure in wait_for_prior_commit() but forget to flag
         the error with my_error().
      
       - Fix slave stop (both for normal stop and stop due to error). Now, at stop
         we pick a specific safe point (in terms of event groups executed) and make
         sure that all event groups before that point are executed to completion,
         and that no event group after start executing; this ensures a safe place to
         restart replication, even for non-transactional stuff/DDL. In error stop,
         make sure that all prior event groups are allowed to execute to completion,
         and that any later event groups that have started are rolled back, if
         possible. The old code could leave eg. T1 and T3 committed but T2 not, or
         it could even leave half a transaction not rolled back in some random
         worker, which would cause big problems when that worker was later reused
         after slave restart.
      
       - Fix the accounting of amount of events queued for one worker. Before, the
         amount was reduced immediately as soon as the events were dequeued (which
         happens all at once); this allowed twice the amount of events to be queued
         in memory for each single worker, which is not what users would expect.
      
       - Fix that an error set during execution of one event was sometimes not
         cleared before executing the next, causing problems with the error
         reporting.
      
       - Fix incorrect handling of thd->killed in worker threads.
      e90f68c0
    • Elena Stepanova's avatar
      Increment the version number · 525c00c6
      Elena Stepanova authored
      525c00c6
    • Jan Lindström's avatar
      MDEV-5746: Slow file extend when innodb_use_fallocate=1 and SSD · 752ba087
      Jan Lindström authored
      file storage.
      
      Analysis: posix_fallocate was called using 0 as offset and len as
      desired size. This is not optimal for SSDs.
      
      Fix: Call posix_fallocate with correct offset i.e. current file size
      and extend the file from there len bytes.
      752ba087
    • Jan Lindström's avatar
      MDEV-5742: Assertion failure node->n_pending on fil0fil.c line 5039 · e479829a
      Jan Lindström authored
      on debug build when innodb_use_fallocate=1
      
      Analysis: There was merge error that caused additional call to 
      fil_node_complete_io.
      
      Fixed by removing incorrect call and fixed calculation of extended
      file size.
      e479829a
  7. 25 Feb, 2014 4 commits
  8. 24 Feb, 2014 2 commits
  9. 22 Feb, 2014 1 commit
  10. 21 Feb, 2014 2 commits
  11. 20 Feb, 2014 3 commits
  12. 19 Feb, 2014 4 commits