1. 24 Jan, 2008 1 commit
    • unknown's avatar
      Bug#29182 - MyISAMCHK reports wrong character set · 1804046d
      unknown authored
      myisamchk did always show Character set: latin1_swedish_ci (8),
      regardless what DEFAULT CHARSET the table had.
      
      When the server created a MyISAM table, it did not copy the
      characterset number into the MyISAM create info structure.
      
      Added assignment of charset number to MI_CREATE_INFO.
      
      
      mysql-test/r/myisam.result:
        Bug#29182 - MyISAMCHK reports wrong character set
        Added test result.
      mysql-test/t/myisam.test:
        Bug#29182 - MyISAMCHK reports wrong character set
        Added test.
      storage/myisam/ha_myisam.cc:
        Bug#29182 - MyISAMCHK reports wrong character set
        Added assignment of charset number to MI_CREATE_INFO.
      1804046d
  2. 21 Jan, 2008 1 commit
  3. 19 Jan, 2008 1 commit
  4. 17 Jan, 2008 1 commit
    • unknown's avatar
      Bug#33067 · 8f3a0ea2
      unknown authored
        "Update of CSV row incorrect for some BLOBs"
        when reading in rows, move blob columns into temporary storage not
        allocated by Field_blob class or else row update operation will
        alter original row and make mysql think that nothing has been changed.
      fix incrementing wrong statistic values.
      
      
      mysql-test/r/csv.result:
        test for bug33067
      mysql-test/t/csv.test:
        test for bug33067
      storage/csv/ha_tina.cc:
        bug33067
          when reading in rows, move blob columns into temporary storage not
          allocated by Field_blob class or else row update operation will
          alter original row and make mysql think that nothing has been changed.
        fix incrementing wrong statistic values.
      storage/csv/ha_tina.h:
        bug33067
          new memroot attribute for blobs
      8f3a0ea2
  5. 16 Jan, 2008 4 commits
    • unknown's avatar
      Bug#32705 - myisam corruption: Key in wrong position · dd40d4ea
      unknown authored
                  at page 1024 with ucs2_bin
      Post merge fix
      
      
      dd40d4ea
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · 794753cd
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/t/ctype_ucs2_def.test:
        Auto merged
      mysql-test/t/myisam.test:
        Auto merged
      mysql-test/r/ctype_ucs2_def.result:
        SCCS merged
      mysql-test/r/myisam.result:
        SCCS merged
      794753cd
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-bug32705 · 8f7c42de
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      mysql-test/r/myisam.result:
        Bug#32705 - myisam corruption: Key in wrong position
                    at page 1024 with ucs2_bin
        Manual merge
      mysql-test/t/myisam.test:
        Bug#32705 - myisam corruption: Key in wrong position
                    at page 1024 with ucs2_bin
        Manual merge
      8f7c42de
    • unknown's avatar
      Bug#32705 - myisam corruption: Key in wrong position · 4fe64cf6
      unknown authored
                  at page 1024 with ucs2_bin
      Post-pushbuild fix.
      Moved test from myisam.test to ctype_ucs2_def.test.
      UCS2 is not always available.
      
      
      mysql-test/r/ctype_ucs2_def.result:
        Bug#32705 - myisam corruption: Key in wrong position
                    at page 1024 with ucs2_bin
        Moved test result from myisam.result to here.
      mysql-test/r/myisam.result:
        Bug#32705 - myisam corruption: Key in wrong position
                    at page 1024 with ucs2_bin
        Moved test result from here to ctype_ucs2_def.result.
      mysql-test/t/ctype_ucs2_def.test:
        Bug#32705 - myisam corruption: Key in wrong position
                    at page 1024 with ucs2_bin
        Moved test from myisam.test to here.
        UCS2 is not always available.
      mysql-test/t/myisam.test:
        Bug#32705 - myisam corruption: Key in wrong position
                    at page 1024 with ucs2_bin
        Moved test from here to ctype_ucs2_def.test.
        UCS2 is not always available.
      4fe64cf6
  6. 15 Jan, 2008 4 commits
  7. 14 Jan, 2008 1 commit
    • unknown's avatar
      Bug#33222 - myisam-table drops rows when column is added · c3bf7021
      unknown authored
                 and a char-field > 128 exists
      
      CHECK TABLE (non-QUICK) and any form of repair table did wrongly rate
      records as corrupted under the following conditions:
      1. The table has dynamic row format and
      2. it has a CHAR like column > 127 bytes (but not VARCHAR)
         (for multi-byte character sets this could be less than 127
         characters) and
      3. it has records with > 127 bytes significant length in that column
         (a byte beyond byte position 127 must be non-space).
      Affected were the statements CHECK TABLE, REPAIR TABLE, OPTIMIZE TABLE,
      ALTER TABLE. CHECK TABLE reported and marked the table as crashed if any
      record was present that fulfilled condition 3. The other statements
      deleted these records.
      
      The problem was a signed/unsigned compare in MyISAM code. A
      char to uchar change became necessary after the big byte to uchar
      change.
      
      
      mysql-test/r/myisam.result:
        Bug#33222 - myisam-table drops rows when column is added
                   and a char-field > 128 exists
        Added test result.
      mysql-test/t/myisam.test:
        Bug#33222 - myisam-table drops rows when column is added
                   and a char-field > 128 exists
        Added test.
      storage/myisam/mi_dynrec.c:
        Bug#33222 - myisam-table drops rows when column is added
                   and a char-field > 128 exists
        char -> uchar became necessary after big byte -> uchar change.
        Fixed some small coding style violations near the changes.
      c3bf7021
  8. 10 Jan, 2008 12 commits
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 8a757010
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      8a757010
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-5.1 · 824ced46
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      client/mysqltest.c:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/repl_failsafe.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_db.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      824ced46
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-5.0 · 84762ce2
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.0-opt
      
      
      client/mysql.cc:
        Auto merged
      84762ce2
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.0-opt · cd6dc10c
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-opt
      
      
      sql/filesort.cc:
        Auto merged
      cd6dc10c
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · eb80c468
      unknown authored
      into  moonbone.local:/work/33675-bug-5.0-opt-mysql
      
      
      eb80c468
    • unknown's avatar
      filesort.cc: · 1a8bcceb
      unknown authored
        Bug#33675: Usage of an uninitialized memory by filesort in a subquery caused
        server crash.
        Free smaller buffer before allocating bigger one.
      
      
      sql/filesort.cc:
        Bug#33675: Usage of an uninitialized memory by filesort in a subquery caused
        server crash.
        Free smaller buffer before allocating bigger one.
      1a8bcceb
    • unknown's avatar
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 1040bea9
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      sql/field.h:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Manual merge.
      mysql-test/t/subselect.test:
        Manual merge.
      sql/filesort.cc:
        Manual merge.
      1040bea9
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-4.1-opt · dafd3f43
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.0-opt
      
      
      sql/set_var.cc:
        Auto merged
      dafd3f43
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug33305/my51-bug33305 · 3869d363
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/union.result:
        Auto merged
      mysql-test/t/union.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      3869d363
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug33305/my50-bug33305 · 7085583c
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.0-opt
      
      
      7085583c
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug33305/my50-bug33305 · 10909bf4
      unknown authored
      into  kaamos.(none):/data/src/opt/bug33305/my51-bug33305
      
      
      mysql-test/r/cast.result:
        Auto merged
      mysql-test/r/type_date.result:
        Auto merged
      mysql-test/r/union.result:
        Auto merged
      mysql-test/t/cast.test:
        Auto merged
      mysql-test/t/skip_grants.test:
        Auto merged
      mysql-test/t/type_date.test:
        Auto merged
      mysql-test/t/union.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/skip_grants.result:
        Manual merge.
      10909bf4
  9. 09 Jan, 2008 5 commits
  10. 08 Jan, 2008 3 commits
    • unknown's avatar
      Bug#33675: Usage of an uninitialized memory by filesort in a subquery caused · 8845553a
      unknown authored
      server crash.
      
      The filesort implementation has an optimization for subquery execution which
      consists of reusing previously allocated buffers. In particular the call to
      the read_buffpek_from_file function might be skipped when a big enough buffer
      for buffer descriptors (buffpeks) is already allocated. Beside allocating
      memory for buffpeks this function fills allocated buffer with data read from
      disk. Skipping it might led to using an arbitrary memory as fields' data and
      finally to a crash.
      
      Now the read_buffpek_from_file function is always called. It allocates
      new buffer only when necessary, but always fill it with correct data.
      
      
      sql/filesort.cc:
        Bug#33675: Usage of an uninitialized memory by filesort in a subquery caused
        server crash.Now the read_buffpek_from_file function is always called. It allocates
        new buffer only when necessary, but always fill it with correct data.
      mysql-test/r/subselect.result:
        Added a test case for the bug#33675: Usage of an uninitialized memory by
        filesort in a subquery caused server crash.
      mysql-test/t/subselect.test:
        Added a test case for the bug#33675: Usage of an uninitialized memory by
        filesort in a subquery caused server crash.
      8845553a
    • unknown's avatar
      merge of bug 33256 5.0-opt -> 5.1-opt · 34cae156
      unknown authored
      34cae156
    • unknown's avatar
      Merge macbook.gmz:/Users/kgeorge/mysql/work/B33256-5.0-opt · c82a7b94
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B33256-5.1-opt
      
      
      mysql-test/r/union.result:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/type_decimal.result:
        merge of bug 33256 5.0-opt -> 5.1-opt
      mysql-test/t/union.test:
        merge of bug 33256 5.0-opt -> 5.1-opt
      sql/field.h:
        merge of bug 33256 5.0-opt -> 5.1-opt
      sql/item.cc:
        merge of bug 33256 5.0-opt -> 5.1-opt
      sql/item_sum.cc:
        merge of bug 33256 5.0-opt -> 5.1-opt
      sql/item_timefunc.cc:
        merge of bug 33256 5.0-opt -> 5.1-opt
      sql/item_timefunc.h:
        merge of bug 33256 5.0-opt -> 5.1-opt
      c82a7b94
  11. 07 Jan, 2008 1 commit
  12. 24 Dec, 2007 2 commits
    • unknown's avatar
      Fix for bug #33305: Test case in 'skip_grants' file need dynamic loading · bdad41ba
      unknown authored
                          to be compiled in
      
      The problem was that on a statically built server an attempt to create
      a UDF resulted in a different, but reasonable error ("Can't open shared
      library" instead of "UDFs are unavailable with the --skip-grant-tables
      option"), which caused a failure for the test case for bug #32020.
      
      Fixed by moving the test case for bug #32020 from skip_grants.test to a
      separate test to ensure that it is only run when the server is built
      with support for dynamically loaded libraries.
      
      
      mysql-test/r/skip_grants.result:
        Moved the test case for bug #32020 to a separate test.
      mysql-test/t/skip_grants.test:
        Moved the test case for bug #32020 to a separate test.
      mysql-test/r/udf_skip_grants.result:
        Moved the test case for bug #32020 to a separate test.
      mysql-test/t/udf_skip_grants-master.opt:
        Moved the test case for bug #32020 to a separate test.
      mysql-test/t/udf_skip_grants.test:
        Moved the test case for bug #32020 to a separate test.
      bdad41ba
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-amain · 51cb4ffc
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      sql/sql_table.cc:
        Auto merged
      51cb4ffc
  13. 21 Dec, 2007 4 commits