An error occurred fetching the project authors.
  1. 24 Feb, 2006 1 commit
    • unknown's avatar
      Bug #17443 mysqldump test failure · 3a78156e
      unknown authored
      client/mysqlimport.c:
        Remove disabled --use-threads option
      mysql-test/r/mysqldump.result:
        Update result
      mysql-test/t/disabled.def:
        Remove disable of mysqldump
      mysql-test/t/mysqldump.test:
        Remove the disable_parsing on tests for --use-threads to mysqlimport
      3a78156e
  2. 22 Feb, 2006 1 commit
    • unknown's avatar
      Bug#10460 SHOW CREATE TABLE uses inconsistent upper/lower case · 31a7a0d6
      unknown authored
      mysql-test/r/alter_table.result:
        Update test result
      mysql-test/r/analyse.result:
        Update test result
      mysql-test/r/archive.result:
        Update test result
      mysql-test/r/archive_bitfield.result:
        Update test result
      mysql-test/r/archive_gis.result:
        Update test result
      mysql-test/r/bdb.result:
        Update test result
      mysql-test/r/bdb_gis.result:
        Update test result
      mysql-test/r/bigint.result:
        Update test result
      mysql-test/r/binary.result:
        Update test result
      mysql-test/r/case.result:
        Update test result
      mysql-test/r/cast.result:
        Update test result
      mysql-test/r/constraints.result:
        Update test result
      mysql-test/r/create.result:
        Update test result
      mysql-test/r/ctype_collate.result:
        Update test result
      mysql-test/r/ctype_create.result:
        Update test result
      mysql-test/r/ctype_latin1_de.result:
        Update test result
      mysql-test/r/ctype_many.result:
        Update test result
      mysql-test/r/ctype_mb.result:
        Update test result
      mysql-test/r/ctype_recoding.result:
        Update test result
      mysql-test/r/ctype_sjis.result:
        Update test result
      mysql-test/r/ctype_tis620.result:
        Update test result
      mysql-test/r/ctype_ucs.result:
        Update test result
      mysql-test/r/ctype_ujis.result:
        Update test result
      mysql-test/r/ctype_utf8.result:
        Update test result
      mysql-test/r/default.result:
        Update test result
      mysql-test/r/events.result:
        Update test result
      mysql-test/r/federated.result:
        Update test result
      mysql-test/r/fulltext.result:
        Update test result
      mysql-test/r/func_gconcat.result:
        Update test result
      mysql-test/r/func_group.result:
        Update test result
      mysql-test/r/func_math.result:
        Update test result
      mysql-test/r/func_misc.result:
        Update test result
      mysql-test/r/func_str.result:
        Update test result
      mysql-test/r/func_system.result:
        Update test result
      mysql-test/r/gis-rtree.result:
        Update test result
      mysql-test/r/heap.result:
        Update test result
      mysql-test/r/index_merge_innodb.result:
        Update test result
      mysql-test/r/information_schema.result:
        Update test result
      mysql-test/r/innodb.result:
        Update test result
      mysql-test/r/innodb_gis.result:
        Update test result
      mysql-test/r/key.result:
        Update test result
      mysql-test/r/merge.result:
        Update test result
      mysql-test/r/myisam.result:
        Update test result
      mysql-test/r/mysqldump-max.result:
        Update test result
      mysql-test/r/mysqldump.result:
        Update test result
      mysql-test/r/ndb_bitfield.result:
        Update test result
      mysql-test/r/ndb_gis.result:
        Update test result
      mysql-test/r/ndb_partition_key.result:
        Update test result
      mysql-test/r/null.result:
        Update test result
      mysql-test/r/partition.result:
        Update test result
      mysql-test/r/partition_02myisam.result:
        Update test result
      mysql-test/r/partition_mgm_err.result:
        Update test result
      mysql-test/r/partition_range.result:
        Update test result
      mysql-test/r/ps_2myisam.result:
        Update test result
      mysql-test/r/ps_3innodb.result:
        Update test result
      mysql-test/r/ps_4heap.result:
        Update test result
      mysql-test/r/ps_5merge.result:
        Update test result
      mysql-test/r/ps_6bdb.result:
        Update test result
      mysql-test/r/rpl_mixed_ddl_dml.result:
        Update test result
      mysql-test/r/rpl_multi_engine.result:
        Update test result
      mysql-test/r/rpl_ndb_UUID.result:
        Update test result
      mysql-test/r/show_check.result:
        Update test result
      mysql-test/r/sp-vars.result:
        Update test result
      mysql-test/r/sp.result:
        Update test result
      mysql-test/r/sql_mode.result:
        Update test result
      mysql-test/r/strict.result:
        Update test result
      mysql-test/r/subselect.result:
        Update test result
      mysql-test/r/symlink.result:
        Update test result
      mysql-test/r/synchronization.result:
        Update test result
      mysql-test/r/system_mysql_db.result:
        Update test result
      mysql-test/r/temp_table.result:
        Update test result
      mysql-test/r/trigger.result:
        Update test result
      mysql-test/r/type_binary.result:
        Update test result
      mysql-test/r/type_bit.result:
        Update test result
      mysql-test/r/type_bit_innodb.result:
        Update test result
      mysql-test/r/type_blob.result:
        Update test result
      mysql-test/r/type_decimal.result:
        Update test result
      mysql-test/r/type_enum.result:
        Update test result
      mysql-test/r/type_float.result:
        Update test result
      mysql-test/r/type_nchar.result:
        Update test result
      mysql-test/r/type_newdecimal.result:
        Update test result
      mysql-test/r/type_set.result:
        Update test result
      mysql-test/r/type_timestamp.result:
        Update test result
      mysql-test/r/type_varchar.result:
        Update test result
      mysql-test/r/union.result:
        Update test result
      mysql-test/r/user_var.result:
        Update test result
      mysql-test/r/variables.result:
        Update test result
      sql/sql_show.cc:
        Make ouput from SHOW CREATE TABLE use uppercase for "CHARACTER SET", "COLLATE", "DEFAULT", "ON UPDATE" and "AUTO_INCREMENT"
      31a7a0d6
  3. 21 Feb, 2006 2 commits
    • unknown's avatar
      Bug#14857 Reading dump files with single statement stored routines fails.Bug... · 1f12107f
      unknown authored
      Bug#14857 Reading dump files with single statement stored routines fails.Bug #14857  	Reading dump files with single statement stored routines fails.
       - Add tests, fixed by patch for 16878
      
      
      mysql-test/r/mysqldump.result:
        Update test results
      mysql-test/t/mysqldump.test:
        Add tests for bug 14857
      1f12107f
    • unknown's avatar
      Bug#14871 mysqldump: invalid view dump output · 15c37025
      unknown authored
       - Add comments with embeded veriosn info around the parts of the view syntax that are only supported by a certain version of MySQL Server
      
      
      client/mysqldump.c:
        Use information_schema.views to gather information about the view, then replace some parts of the output from "SHOW CREATE VIEW" with comment markers with version, to make thos parts of the view syntax become parsed only of MySQL servers that supports it.
        Create common function "open_sql_file_for_table" to open the individual .sql file where to dump the table or view.
      mysql-test/r/mysqldump.result:
        Update results
      mysql-test/t/mysqldump.test:
        Add test to see that views can be deumped and reloaded alos when they contain "SECURITY TYPE", "CHECK OPTION" and "DEFINER"
      15c37025
  4. 20 Feb, 2006 1 commit
    • unknown's avatar
      Bug#17382 mysql-test-run mysqldump fails with mysqlimport · 0934ad5d
      unknown authored
      client/Makefile.am:
        Use LDADD_R as common variable for programs to be linked with thread safe library.
      client/mysqlimport.c:
        Enable "--use-threads"
        Formatting
      mysql-test/r/mysqldump.result:
        Update test result
      mysql-test/t/disabled.def:
        Enable mysqldump
      mysql-test/t/mysqldump.test:
        Enable test for mysqlimport with threads
        Add test for failed mysqlimport
      0934ad5d
  5. 17 Feb, 2006 2 commits
    • unknown's avatar
      Bug#17382 mysql-test-run mysqldump fails with mysqlimport: Error:client run out of memory · 0c7568f1
      unknown authored
       - Disable --use-threads option in 5.1.7
      
      
      client/mysqlimport.c:
        Disable --use-threads option
      mysql-test/r/mysqldump.result:
        Update test result
      mysql-test/t/mysqldump.test:
        Disable test for --use-threads
      0c7568f1
    • unknown's avatar
      Replace win filename s with unix equivalent · c61fb3c3
      unknown authored
      Evaluate commands passed to "exec" and "system" to expand any $variables before executing command.
      
      
      client/mysqltest.c:
        do_exec, do_system 
         - call do_eval on the command to be executed in order to expand any $variables
         - Remove old subst_env_var and my_popen, not needed anymore
        Rewrite 'replace_strings' into 'replace_strings_append'
         - copy whole strings instead of byte by byte copy
         - insert result directly inito dynamic_string, no need to check if out 
           string needs to be realloced for every byte.
         - Add comments and DBUG_PRINT's
        New function 'fix_win_paths', detect filenames in win format that should be converted 
        do_eval
        - Only set "escaped" if next char is \ or $
      mysql-test/mysql-test-run.pl:
        Always pass path for DBUG .trace file in unix format
        Add search path client_debug to find debug compiled windows binaries
        Remove unused MYSQL_TEST_WINDIR and MASTER_WINMYSOCK
      mysql-test/r/mysqldump.result:
        Update test result
      mysql-test/t/client_xml.test:
        Use " instead of '
      mysql-test/t/mysql_client_test.test:
        Remove the useless "exec echo" command
      mysql-test/t/mysqltest.test:
        Escape $variables passed to --exec, that should not be evaluated in exec.
      mysql-test/t/rpl000015.test:
        Remove unneccessary replace
      mysql-test/t/system_mysql_db_fix.test:
        Call the "shell script" $MYSQL_FIX_SYSTEM_TABLE using --system
      c61fb3c3
  6. 14 Feb, 2006 1 commit
  7. 13 Feb, 2006 1 commit
    • unknown's avatar
      Adding thread support for mysqlimport. You can now specify a number of threads... · bee0941d
      unknown authored
      Adding thread support for mysqlimport. You can now specify a number of threads to use and it will thread the loading of the database. Anyone who has had to go through the pain of loading the database will immediatly get the reason for this.
      
      
      client/Makefile.am:
        Adding client_thread_libs for mysqlimport (aka it gets pthreads)
      client/client_priv.h:
        New option
      client/mysqlimport.c:
        Reworked logic to allow someone to use threads.
      mysql-test/r/mysqldump.result:
        New results
      mysql-test/t/mysqldump.test:
        Added tests for threads.
      bee0941d
  8. 09 Feb, 2006 1 commit
    • unknown's avatar
      Bug#16878 dump of trigger · 2caa5608
      unknown authored
       - Pass "in_comment" variable on to new lex in sp_head::reset_lex
       - Add testcases for dumping and reloading trigger without BEGIN/END
      
      
      mysql-test/r/mysqldump.result:
        Update test result
      mysql-test/t/mysqldump.test:
        Add test for dumping trigger without begin/end, and test that the output from mysqldump can be reloaded.
      sql/sp_head.cc:
        If already in a comment before parsing a substatement, set in_comment in the new lex as well.
        This will handle cases where the comment starts before the substatement, which is common in 
        output from mysqldump to mask away syntax not supported by earlier versions of MySQL.
        Ex:
        /*!50003 CREATE TRIGGER `tr1` BEFORE INSERT ON `t1` FOR EACH ROW
        set new.created=now() */;
        ^=== sp_head::reset_lex is called when already in comment
      2caa5608
  9. 12 Jan, 2006 1 commit
    • unknown's avatar
      Fix for BUG#15103: SHOW TRIGGERS: small output alignment problem. · f315b0b8
      unknown authored
      mysql-test/r/information_schema.result:
        Remove extra spaces from result file.
      mysql-test/r/mysqldump.result:
        Remove extra spaces from result file.
      mysql-test/r/rpl_ddl.result:
        Remove extra spaces from result file.
      mysql-test/r/trigger-compat.result:
        Remove extra spaces from result file.
      mysql-test/r/trigger-grant.result:
        Remove extra spaces from result file.
      mysql-test/r/trigger.result:
        Remove extra spaces from result file.
      sql/sql_yacc.yy:
        Remove leading spaces.
      f315b0b8
  10. 10 Jan, 2006 1 commit
    • unknown's avatar
      Fix for BUG#15110: mysqldump --triggers: does not include DEFINER clause · d4d29edb
      unknown authored
      There are two main idea of this fix:
        - introduce a common function for server and client to split user value
          (<user name>@<host name>) into user name and host name parts;
        - dump DEFINER clause in correct format in mysqldump.
      
      
      BitKeeper/etc/ignore:
        added client/my_user.c libmysqld/my_user.c sql/my_user.c
      client/Makefile.am:
        Use my_user.c in linking of mysqldump executable.
      client/mysqldump.c:
        Fix for BUG#15110(mysqldump --triggers: does not include DEFINER clause)
      include/Makefile.am:
        Add my_user.c
      include/mysql_com.h:
        Introduce a constant for max user length.
      libmysqld/Makefile.am:
        Add my_user.c
      mysql-test/r/mysqldump.result:
        Update result file.
      sql-common/Makefile.am:
        Add my_user.c
      sql/Makefile.am:
        Add my_user.c
      sql/sp.cc:
        Use constant for max user length.
      sql/sp_head.cc:
        Use common function to parse user value.
      sql/sql_acl.cc:
        Use constant for max user length.
      sql/sql_parse.cc:
        Use constant for max user length.
      sql/sql_show.cc:
        Use constant for max user length.
      sql/sql_trigger.cc:
        Use constant for max user length.
      include/my_user.h:
        A header file for parse_user().
      sql-common/my_user.c:
        A new file for parse_user() implementation.
      d4d29edb
  11. 31 Dec, 2005 1 commit
    • unknown's avatar
      WL#1324 table name to file name encoding · 9c7412ca
      unknown authored
      - Encoding itself, implemented as a charset
        "filename". Originally planned to use '.'
        as an escape character, but now changed to '@'
        for two reasons: "ls" does not return
        file names starting with '.' considering them
        as a kind of hidden files; some platforms
        do not allow several dots in a file name.
      - replacing many calls of my_snprintf() and
        strnxmov() to the new build_table_filename().
      - Adding MY_APPEND_EXT mysys flag, to append
        an extention rather that replace it.
      - Replacing all numeric constants in fn_format
        flag arguments to their mysys definitions, e.g.
        MY_UNPACK_FILENAME,
      - Predictability in several function/methods:
        when a table name can appear with or withot .frm
        extension. Some functions/methods were changed
        so accept names strictly with .frm, other - strictly
        without .frm extensions. Several DBUG_ASSERTs were
        added to check whether an extension is passed.
      Many files:
        table name to file name encoding
      mysql_priv.h:
        Prototypes for new table name encoding tools.
      ctype-utf8.c:
        Implementing "filename" charset for
        table name to file name encoding.
      row0mysql.c:
        Fixing table name prefix.
      mf_format.c:
        Adding MY_APPEND_EXT processing.
      Many files:
        Fixing tests.
      my_sys.h:
        Adding new flag to append rather than replace an extension.
      m_ctype.h:
        Adding "filename" charset definition.
      
      
      include/m_ctype.h:
        Adding "filename" charset definition.
      include/my_sys.h:
        Adding new flag to append rather than replace an extension.
      mysql-test/t/alter_table.test:
        Fixing tests.
      mysql-test/t/create.test:
        Fixing tests.
      mysql-test/t/show_check.test:
        Fixing tests.
      mysql-test/r/alter_table.result:
        Fixing tests.
      mysql-test/r/create.result:
        Fixing tests.
      mysql-test/r/mysqldump.result:
        Fixing tests.
      mysys/mf_format.c:
        Adding MY_APPEND_EXT processing.
      sql/discover.cc:
        table name to file name encoding
      sql/ha_berkeley.cc:
        table name to file name encoding
      sql/ha_innodb.cc:
        table name to file name encoding
      sql/ha_myisam.cc:
        table name to file name encoding
      sql/ha_myisammrg.cc:
        table name to file name encoding
      sql/ha_ndbcluster.cc:
        table name to file name encoding
      sql/ha_partition.cc:
        table name to file name encoding
      sql/handler.cc:
        table name to file name encoding.
      sql/init.cc:
        table name to file name encoding
      sql/mysqld.cc:
        table name to file name encoding
      sql/parse_file.cc:
        table name to file name encoding
      sql/sql_acl.cc:
        table name to file name encoding
      sql/sql_base.cc:
        table name to file name encoding
      sql/sql_db.cc:
        table name to file name encoding
      sql/sql_delete.cc:
        table name to file name encoding
      sql/sql_rename.cc:
        table name to file name encoding
      sql/sql_show.cc:
        table name to file name encoding
      sql/sql_table.cc:
        table name to file name encoding
      sql/sql_trigger.cc:
        table name to file name encoding
      sql/sql_view.cc:
        table name to file name encoding
      sql/strfunc.cc:
        table name to file name encoding
      sql/table.cc:
        table name to file name encoding
      sql/unireg.cc:
        table name to file name encoding
      storage/innobase/row/row0mysql.c:
        Fixing table name prefix.
        ,
      storage/myisam/mi_create.c:
        table name to file name encoding
      storage/myisam/mi_delete_table.c:
        table name to file name encoding
      storage/myisam/mi_open.c:
        table name to file name encoding
      storage/myisam/mi_rename.c:
        table name to file name encoding
      strings/ctype-utf8.c:
        Implementing "filename" charset for
        table name to file name encoding.
      sql/mysql_priv.h:
        Prototypes for new table name encoding tools.
      storage/myisammrg/myrg_create.c:
        table name to file name encoding
      storage/myisammrg/myrg_open.c:
        table name to file name encoding
      9c7412ca
  12. 02 Dec, 2005 1 commit
    • unknown's avatar
      Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE · ca34f415
      unknown authored
        -issue more correct message for incorrect date|datetime|time values
        -ER_WARN_DATA_OUT_OF_RANGE message is changed
        -added new error message
      
      
      mysql-test/r/auto_increment.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/bigint.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/ctype_ucs.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/date_formats.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/func_sapdb.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/func_str.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/func_time.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/insert.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/loaddata.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/mysqldump.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/ps_2myisam.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/ps_3innodb.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/ps_4heap.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/ps_5merge.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/ps_6bdb.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/ps_7ndb.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/rpl_rewrite_db.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/sp.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/strict.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/timezone2.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/timezone_grant.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/type_bit.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/type_bit_innodb.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/type_date.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/type_datetime.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/type_decimal.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/type_float.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/type_newdecimal.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/type_ranges.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/type_time.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/type_uint.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/view.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      mysql-test/r/warnings.result:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          result change
      sql/share/errmsg.txt:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          -ER_WARN_DATA_OUT_OF_RANGE message is changed
          -added new error message
      sql/time.cc:
        Fix for bug#8294 Traditional: Misleading error message for invalid CAST to DATE
          issue more correct message for incorrect date|datetime|time values
      ca34f415
  13. 01 Dec, 2005 1 commit
  14. 24 Nov, 2005 3 commits
    • unknown's avatar
      Fixing result file from previous merge. · a167f63b
      unknown authored
      mysql-test/r/mysqldump.result:
        Fixing result from merge
      a167f63b
    • unknown's avatar
      Its funny, I am reading through the forums and someone asks "Can I please have... · b0b86ec1
      unknown authored
      Its funny, I am reading through the forums and someone asks "Can I please have a REPLACE INTO, instead an INSERT INTO?" and I remember how often I have used a sed script to modify MySQL dumps to have exactly that.
      So, use --replace and instead of getting INSERT INTO you will INSTEAD get REPLACE INTO. Buyer beward, REPLACE is a MySQL SQL, so you will not end up with a dump that can be used for other databases.
      
      Though I hear you could just use a sed line to modify it back :)
      
      
      client/client_priv.h:
        New option for --replace
      client/mysqldump.c:
        Added option for REPLACE INTO instead of INSERT INTO
      mysql-test/r/mysqldump.result:
        Updated REsultes for replace into
      mysql-test/t/mysqldump.test:
        Added new test for --replace
      b0b86ec1
    • unknown's avatar
      Fix values printed by mysqldump for empty blob fields when · eb92d6a1
      unknown authored
      --hex-blob is used. (Bug #13318)
      
      
      client/mysqldump.c:
        Don't use 0x... syntax for empty fields.
      mysql-test/r/mysqldump.result:
        Add new results
      mysql-test/t/mysqldump.test:
        Add new regression test
      eb92d6a1
  15. 21 Nov, 2005 1 commit
    • unknown's avatar
      Fixed BUG #14554: mysqldump does not separate "ROW" and trigger · 3ecbc8e6
      unknown authored
       statement for tables created in the IGNORE_SPACE sql mode.
      
      
      client/mysqldump.c:
        Modified dump_triggers_for_table(): if trigger statement returned
         by SHOW TRIGGERS query does not contain a leading white space,
         additional space is inserted between "ROW" and the statement.
         The leading white spaces are removed by yylex() in the
         IGNORE_SPACE sql mode.
      mysql-test/r/mysqldump.result:
        Fixed test case result for bug 14554.
      mysql-test/t/mysqldump.test:
        Added test case for bug 14554.
      3ecbc8e6
  16. 10 Nov, 2005 2 commits
    • unknown's avatar
      WL#2818 (Add creator to the trigger definition for privilege · 7dbea7df
      unknown authored
      checks on trigger activation)
      
      
      mysql-test/r/information_schema.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/mysqldump.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/rpl_ddl.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/rpl_sp.result:
        Update result file: a new clause DEFINER has been added to
        CREATE TRIGGER statement.
      mysql-test/r/rpl_trigger.result:
        Results for new test cases were added.
      mysql-test/r/skip_grants.result:
        Error message has been changed.
      mysql-test/r/trigger.result:
        Added DEFINER column.
      mysql-test/r/view.result:
        Error messages have been changed.
      mysql-test/r/view_grant.result:
        Error messages have been changed.
      mysql-test/t/mysqldump.test:
        Drop created procedure to not affect further tests.
      mysql-test/t/rpl_trigger.test:
        Add tests for new column in information schema.
      mysql-test/t/skip_grants.test:
        Error tag has been renamed.
      mysql-test/t/view.test:
        Error tag has been renamed.
      mysql-test/t/view_grant.test:
        Error tag has been changed.
      sql/item_func.cc:
        Fix typo in comments.
      sql/mysql_priv.h:
        A try to minimize copy&paste:
          - introduce operations to be used from sql_yacc.yy;
          - introduce an operation to be used from trigger and
            view processing code.
      sql/share/errmsg.txt:
        - Rename ER_NO_VIEW_USER to ER_MALFORMED_DEFINER in order to
          be shared for view and trigger implementations;
        - Fix a typo;
        - Add a new error code for trigger warning.
      sql/sp.cc:
        set_info() was split into set_info() and set_definer().
      sql/sp_head.cc:
        set_info() was split into set_info() and set_definer().
      sql/sp_head.h:
        set_info() was split into set_info() and set_definer().
      sql/sql_acl.cc:
        Add a new check: exit from the cycle if the table is NULL.
      sql/sql_lex.h:
        - Rename create_view_definer to definer, since it is used for views
          and triggers;
        - Change st_lex_user to LEX_USER, since st_lex_user is a structure.
          So, formally, it should be "struct st_lex_user", which is longer
          than just LEX_USER;
        - Add trigger_definition_begin.
      sql/sql_parse.cc:
        - Add a new check: exit from the cycle if the table is NULL;
        - Implement definer-related functions.
      sql/sql_show.cc:
        Add DEFINER column.
      sql/sql_trigger.cc:
        Add DEFINER support for triggers.
      sql/sql_trigger.h:
        Add DEFINER support for triggers.
      sql/sql_view.cc:
        Rename create_view_definer to definer.
      sql/sql_yacc.yy:
        Add support for DEFINER-clause in CREATE TRIGGER statement.
        
        Since CREATE TRIGGER and CREATE VIEW can be similar at the start,
        yacc is unable to distinguish between them. So, had to modify both
        statements in order to make it parsable by yacc.
      mysql-test/r/trigger-compat.result:
        Result file for triggers backward compatibility test.
      mysql-test/r/trigger-grant.result:
        Result file of the test for WL#2818.
      mysql-test/t/trigger-compat.test:
        Triggers backward compatibility test: check that the server
        still can load triggers w/o definer attribute and modify
        tables with such triggers (add a new trigger, etc).
      mysql-test/t/trigger-grant.test:
        Test for WL#2818 -- check that DEFINER support in triggers
        works properly
      7dbea7df
    • unknown's avatar
      Fix for bug #14822: Test "mysqldump" fails, "result" protocol seems wrong. · 0c97fbef
      unknown authored
      mysql-test/t/mysqldump.test:
        Fix for bug #14822: Test "mysqldump" fails, "result" protocol seems wrong.
        2>&1 added to be able to see error messages.
      0c97fbef
  17. 04 Nov, 2005 1 commit
  18. 27 Oct, 2005 1 commit
    • unknown's avatar
      Add DROP TABLE before trying to create view (in mysqldump) · fd0ed478
      unknown authored
      Cleaned up xxxx_gis.test's and made gis_generic.inc independent of ndb
      (Note that archive_gis.test fails, but this is independent of this patch)
      
      
      client/mysqldump.c:
        Add DROP TABLE to be able to re-run mysqldump if it fails after 'table-named-as-view' is created
      mysql-test/include/gis_generic.inc:
        Remove dependency of ndb
      mysql-test/include/have_archive.inc:
        Fix syntax
      mysql-test/include/have_geometry.inc:
        Fix syntax
      mysql-test/r/mysqldump.result:
        New test results after adding 'drop table'
      mysql-test/t/archive_gis.test:
        gis_generic tests for have_geometry.inc
      mysql-test/t/bdb_gis.test:
        gis_generic tests for have_geometry.inc
      mysql-test/t/innodb_gis.test:
        gis_generic tests for have_geometry.inc
      mysql-test/t/ndb_gis.test:
        gis_generic tests for have_geometry.inc
      sql/item_func.cc:
        Simplify code (as signal_divide_by_null sets 'null_value')
      fd0ed478
  19. 25 Oct, 2005 2 commits
    • unknown's avatar
      BUG# 12123 · cf59103d
      unknown authored
      Made change to mysqlimport to set character_set_database to binary to 
      make importing various charsets/columns work correctly.
      
      
      client/mysqlimport.c:
        BUG# 12123
        
        Added 'set @@character_set_database=binary' to make loading of tables with
        mixed charset types and non-latin characters load.
      mysql-test/mysql-test-run.pl:
        BUG #12123
        
        Added $MYSQL_IMPORT in order to test mysqlimport bug.
      mysql-test/mysql-test-run.sh:
        BUG #12123
        
        Added $MYSQL_IMPORT in order to test mysqlimport bug.
      mysql-test/r/mysqldump.result:
        BUG #12123
        
        Added dumping and reloading (using mysql, mysqldump, and mysqlimport) to
        show that this fix handles dumping and reloading of non-latin1 charsets
        in table with different charset columns (mixing of charsets, also can be a
        UTF table with latin1 tables). Note the select before and after dump and 
        restore - should be exact.
      mysql-test/t/mysqldump.test:
        BUG #12123
        
        Added dumping and reloading (using mysql, mysqldump, and mysqlimport) to
        show that this fix handles dumping and reloading of non-latin1 charsets
        in table with different charset columns (mixing of charsets, also can be a
        UTF table with latin1 tables). Note the select before and after dump and 
        restore - should be exact. (results of this)
      cf59103d
    • unknown's avatar
      This cset fixes BUG# 12838, 14061, 12129 · cecdc15a
      unknown authored
      mysqldump.result:
        BUG# 12838
            New test results for mysqldump -x on a DB with views
      mysqldump.test:
        sqldump.test:
            BUG# 12838
            New test to run mysqldump -x on a DB with views
      mysqldump.c:
        BUG# 12838
            Removed/Changed code which created tables to be put into the dump
            (For loading views of views) by creating temp tables and then using
            the CREATE TABLE information in those temp tables. The problem with this
            is that when mysqldump -x is called, it locks all tables, so the
            temp tables could not be created, causing the mysqldump to exit with
            failure. The code was changed to use SHOW FIELDS to get the column
            names and type to build CREATE TABLE text used to create these tables
            that views need in the dump.
      
      
      client/mysqldump.c:
        BUG# 12838
            Removed/Changed code which created tables to be put into the dump
            (For loading views of views) by creating temp tables and then using
            the CREATE TABLE information in those temp tables. The problem with this
            is that when mysqldump -x is called, it locks all tables, so the
            temp tables could not be created, causing the mysqldump to exit with
            failure. The code was changed to use SHOW FIELDS to get the column
            names and type to build CREATE TABLE text used to create these tables
            that views need in the dump.
      mysql-test/t/mysqldump.test:
        sqldump.test:
            BUG# 12838
            New test to run mysqldump -x on a DB with views
      mysql-test/r/mysqldump.result:
        BUG# 12838
            New test results for mysqldump -x on a DB with views
      cecdc15a
  20. 13 Oct, 2005 2 commits
    • unknown's avatar
      BUG# 13146 · b52b67eb
      unknown authored
      Re-application of patch to clean 5.0 tree. Fixed issue with ANSI quotes 
      when dumping triggers
      
      
      client/mysqldump.c:
        BUG# 13146
        
        Re-application of fix to clean 5.0 tree. 
        
        Added comments for quote_name, moved declarations into proper order, 
        unset MASK_ANSI_QUOTES flag in opt_compatible_mode global when dumping
        triggers
      mysql-test/r/mysqldump.result:
        BUG# 13146
        
        New test results
      mysql-test/t/mysqldump.test:
        BUG# 13146
        
        New test
      b52b67eb
    • unknown's avatar
      BUG# 13052 · a2ceebf2
      unknown authored
      Clean application of patch - 
      - Added --tz-utc to fix issue of dumping timestamp values between 
      servers with different global time zone settings, particularly 
      with regard to the day of DST changeover, which without this fix,
       would dump duplicate timestamp values.
      
      
      client/client_priv.h:
        BUG# 13052 - clean application of http://lists.mysql.com/internals/30993
      client/mysqldump.c:
        BUG# 13052
        
        Clean application of patch http://lists.mysql.com/internals/30993
        
        - added new --tz-utc option
        - added saving of TIME_ZONE in dump file
        - set TIME_ZONE to "+00:00" in dump
      mysql-test/r/mysqldump.result:
        BUG# 13052 New results
      mysql-test/t/mysqldump.test:
        BUG# 13052
        
        Added new test to test if the new option --tz-utc places 
        'SET TIME_ZONE="+00:00" at the top of the file and that this fixes 
        the problem of ending up with duplicate timestamp values that should
         be unique on eve of DST
      a2ceebf2
  21. 06 Oct, 2005 1 commit
    • unknown's avatar
      Review of code pushed since last 5.0 pull: · c807724f
      unknown authored
      Ensure that ccache is also used for C programs
      mysql: Ensure that 'delimiter' works the same way in batch mode as in normal mode
      mysqldump: Change to use ;; (instead of //) as a stored procedure/trigger delimiter
      Fixed test cases by adding missing DROP's and rename views to be of type 'v#'
      Removed MY_UNIX_PATH from fn_format()
      Removed current_db_used from TABLE_LIST
      Removed usage of 'current_thd' in Item_splocal
      Removed some compiler warnings
      A bit faster longlong2str code
      
      
      
      BUILD/FINISH.sh:
        Ensure that ccache is also used for C programs
      BUILD/SETUP.sh:
        Ensure that ccache is also used for C programs
      client/mysql.cc:
        More debugging
        Ensure that 'delimiter' works the same way in batch mode as in normal mode.
        Compare 'delimiter' command case-insensitive.
        The above fixes the delimiter bugs so that we can now use ;; as a trigger/SP function delimiter in mysqldump.
      client/mysqldump.c:
        Indentation fixes
        Use ;; as a delmimiter for stored procedures and triggers instead of //
      client/mysqltest.c:
        Indentation fixes
      include/my_sys.h:
        Remove not needed MY_UNIX_PATH parameter
      mysql-test/r/alter_table.result:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/r/func_str.result:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/r/information_schema.result:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/r/information_schema_inno.result:
        Drop all used tables
      mysql-test/r/multi_statement.result:
        Drop used tables
      mysql-test/r/mysql.result:
        Add error messages to result
      mysql-test/r/mysqldump.result:
        ;; is now used as SP/trigger delimiter
      mysql-test/r/mysqlshow.result:
        Drop used tables
      mysql-test/r/temp_table.result:
        Drop used views
        Rename views to v#
      mysql-test/t/alter_table.test:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/t/func_str.test:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/t/information_schema.test:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/t/information_schema_inno.test:
        Drop all used tables
      mysql-test/t/multi_statement.test:
        Drop used tables
      mysql-test/t/mysql.test:
        Add error messages to result
      mysql-test/t/mysqlshow.test:
        Drop used tables
      mysql-test/t/temp_table.test:
        Drop used views
        Rename views to v#
      mysys/mf_format.c:
        Remove not needed MY_UNIX_PATH parameter
        (This goes against how fn_format() is supposed to work and also conflicts with other options like MY_RETURN_REAL_PATH)
      sql/ha_federated.cc:
        Removed extra empty line
      sql/item.cc:
        Use 'str_value' instead of 'str_value_ptr' to hold result for Item_splocal
        Remove some calls to 'thd' in Item_splocal by making 'thd' a class variable
        One doesn't have to set 'null_value' when calling 'is_null()'
      sql/item.h:
        Add THD as a class variable to Item_splocal
        Use 'str_value' instead of 'str_value_ptr' to hold temp result
        Fixed bug in Item_hex when used in CAST()
      sql/item_func.cc:
        Optimize new code
      sql/log_event.cc:
        Move 'to_unix_path()' out of fn_format()
      sql/opt_range.cc:
        Simplify code
      sql/sp_head.cc:
        Ensure that Item_splocal has thd set before we call '->this_item()'
      sql/sql_class.cc:
        Return error if Statement::insert() fails in either hash_insert()
      sql/sql_parse.cc:
        Remove 'current_db_used' as we can trivially check if db table qualifier was used without this.
        Simplify code
      sql/sql_prepare.cc:
        Use enum instead of const int, to avoid ugly code for VC++
      sql/structs.h:
        Remove compiler warnings when using STRING_WITH_LEN() with constant strings.
      sql/table.cc:
        Fixed indentation
      sql/table.h:
        Remove not needed current_db_used
      strings/decimal.c:
        Simplify code
      strings/longlong2str-x86.s:
        A bit faster longlong2str.
        (Took some ideas from Peter Gulutzan's code)
      strings/my_strtoll10.c:
        Simplify code for MetroWerks compiler
      c807724f
  22. 29 Sep, 2005 1 commit
  23. 27 Sep, 2005 1 commit
    • unknown's avatar
      BUG #7815 · f0a9ad91
      unknown authored
      Changes per serg to http://lists.mysql.com/internals/30281
      
      Re-enabled --delayed-insert
      
      
      client/mysqldump.c:
        BUG #7815 
        
        Changes per serg on patch: http://lists.mysql.com/internals/30281
        
        1. Re-enabled --delayed-insert
             - modified options, removed code that was in place until bug was 
               fixed    
        2. Moved the call to get_table_structure to dump_table 
          - Use added 'ignore_flag' variable to determine what exactly is
            being ignored - whole table or just delayed insert ability
        3. Changed return type of ignore_table to char with byte value that
           determines what exactly is being ignored - the whole table, or
           delayed inserts
        4. Added ignore_table flags IGNORE_DATA and IGNORE_INSERT_DELAYED
        5. Added logic in get_table_structure to not append INSERT data text
           if the table's data isn't going to be dumped because the return
           value from ignore_table is IGNORE_DATA
        6. Changed the name of numFields to numfields. Studly caps aren't
           consistent with the rest of the code!
        7. Added inclusive list to check_if_ignore_table to set the flag to
           IGNORE_INSERT_DELAYED if the table type doesn't support delayed
           inserts.
        8. More documentation
      mysql-test/r/mysqldump.result:
        BUG #7815 new results
      mysql-test/r/mysqldump-max.result:
        BUG #7815
        
        New test results
      mysql-test/t/mysqldump-max.test:
        BUG #7815
        New test for testing if insert delayed is applied to tables that support
        it in mysqldump, but only if all storage engines in test have been compiled
        in
      f0a9ad91
  24. 14 Sep, 2005 2 commits
    • unknown's avatar
      postmerge fix · 98b6fd87
      unknown authored
      98b6fd87
    • unknown's avatar
      part 1 (ver 2, postreview fix) of WL#2787 · f7aeb6f9
      unknown authored
      view definer information syntax/storage/replication
      fixed SOURCE field of .frm
      
      
      mysql-test/r/func_in.result:
        definer information added to CREATE VIEW
      mysql-test/r/lowercase_view.result:
        definer information added to CREATE VIEW
      mysql-test/r/mysqldump.result:
        definer information added to CREATE VIEW
      mysql-test/r/rpl_view.result:
        check log of queries
      mysql-test/r/skip_grants.result:
        --skip-grants do not allow use user information
      mysql-test/r/sql_mode.result:
        definer information added to CREATE VIEW
      mysql-test/r/temp_table.result:
        definer information added to CREATE VIEW
      mysql-test/r/view.result:
        definer information added to CREATE VIEW
        test of storing/restoring definer information
      mysql-test/r/view_grant.result:
        test of grant check of definer information
        definer information added to CREATE VIEW
      mysql-test/t/rpl_view.test:
        check log of queries
      mysql-test/t/skip_grants.test:
        --skip-grants do not allow use user information
      mysql-test/t/view.test:
        test of storing/restoring definer information
      mysql-test/t/view_grant.test:
        test of grant check of definer information
      sql/mysql_priv.h:
        CREATE/ALTER VIEW print support
        set current user as definer procedure
      sql/share/errmsg.txt:
        new errors/warnings
      sql/sql_acl.cc:
        make find_acl_user public to allow to check user
      sql/sql_acl.h:
        make find_acl_user public to allow to check user
      sql/sql_lex.h:
        storing definer information
      sql/sql_parse.cc:
        send CREATE/ALTER VIEW for replication with full list of options
        set current user as definer procedure
      sql/sql_show.cc:
        new CREATE VIEW options printed
      sql/sql_view.cc:
        check of definer clause
        changes in .frm file
        definer information storage support
        now we store only original SELECT in SOURCE field of .frm
      sql/sql_yacc.yy:
        definer information sintax support
        getting SOURCE field information for .frm
      sql/table.h:
        definer information storage
      f7aeb6f9
  25. 13 Sep, 2005 2 commits
    • unknown's avatar
      after pull review - many bugs in mysqldump --routines · 21f4f6cf
      unknown authored
      mysql-test/r/mysqldump.result:
        updated
      mysql-test/t/mysqldump.test:
        cleanup, new test
      21f4f6cf
    • unknown's avatar
      BUG#10713 mysqldump includes database in create view and referenced tables · 2761c648
      unknown authored
       - Update test results
       - Updates after review
      
      
      mysql-test/r/func_in.result:
        Update test results
      mysql-test/r/lowercase_view.result:
        Update test results
      mysql-test/r/mysqldump.result:
        Update test results
      mysql-test/r/sql_mode.result:
        Update test results
      mysql-test/r/temp_table.result:
        Update test results
      mysql-test/r/view.result:
        Update test results
      mysql-test/t/mysqldump.test:
        Update test results
      sql/sql_show.cc:
        Updated after review
      2761c648
  26. 09 Sep, 2005 2 commits
    • unknown's avatar
      BUG #12597 after merge, needed to produce results · b5622d49
      unknown authored
      mysql-test/r/mysqldump.result:
        BUG #12597 - new results file because of merge of test and results file
      b5622d49
    • unknown's avatar
      A fix (bug #12917: The --defaults-extra-file option is ignored by the 5.0 client binaries). · af05c8d3
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        A fix (bug #12917: The --defaults-extra-file option is ignored by the 5.0 client binaries).
        MYSQL_MY_PRINT_DEFAULTS added
      mysql-test/mysql-test-run.sh:
        A fix (bug #12917: The --defaults-extra-file option is ignored by the 5.0 client binaries).
        MYSQL_MY_PRINT_DEFAULTS added
      mysys/default.c:
        A fix (bug #12917: The --defaults-extra-file option is ignored by the 5.0 client binaries).
        Set defaults_extra_file as we use it widely.
      af05c8d3
  27. 08 Sep, 2005 2 commits
    • unknown's avatar
      BUG #12597 This is a complete patch (2nd) containing fixes per Serg's review · 6c231284
      unknown authored
      client/mysqldump.c:
        BUG #12597
        - Dump triggers after data dump of each table
        - created dump_triggers_for_table function
        - added space between "MODE" and "*/"
      mysql-test/r/mysqldump.result:
        Tests to test BUG #12597
      mysql-test/t/mysqldump.test:
        BUG #12597
        - New tests to test bug #12597
      6c231284
    • unknown's avatar
      BUG #9056 Changes to patch #2 per Serg's review · b024d74f
      unknown authored
      client/mysqldump.c:
        BUG #9056 Fixes per serg
        * if opt_lock for locking mysql.proc
        * calling mysql_query_with_error_report where needed
        * print functions same way as procs, file bug about commented functions
      mysql-test/r/mysqldump.result:
        BUG #9056 New results
      mysql-test/t/mysqldump.test:
        BUG #9056 Removed redirect, simplified, dump in results, per Serg
      b024d74f
  28. 03 Sep, 2005 1 commit
    • unknown's avatar
      BUG #9056 Added --routines flag to mysqldump to enable mysqldump to be able · 3058d9fd
      unknown authored
      to dump PROCEDURES and FUNCTIONS.
      
      
      client/mysqldump.c:
        BUG #9056, added dumping of functions/procs to mysqldump
        - added opt_routines (--routines/-R)
        - added dump_routines_for_db, function that dumps proc and funcs
        - added calling of dump_routines to dump_all_tables_in_db and dump_selected_tables
      mysql-test/r/mysqldump.result:
        BUG #9056 new test results for mysqldump --routines
      mysql-test/t/mysqldump.test:
        BUG #9056 New tests for mysqldump --routines
      3058d9fd
  29. 01 Sep, 2005 1 commit
    • unknown's avatar
      Bug10213 mysqldump crashes when dumping VIEWs · 74ea939f
      unknown authored
       - Added testcase for this bug
       - Check if compact view format can be used
       - Clean up mysqld_show_create
      
      
      mysql-test/r/mysqldump.result:
        Updated test result
      mysql-test/t/mysqldump.test:
        Added testcase
      sql/item.cc:
        Check if compact format can be used
      sql/sql_select.cc:
        Check if compact format can be used
      sql/sql_show.cc:
        Cleanup of mysqld_show_create
         -remove extra invocation of view_store_create_info
         -Remove unused vars
         -Remove unused codes
        Check if compact show view format can be used 
          - if user has db of this view as current db
          - if this view only references table inside it's own db
      sql/table.h:
        Add variable for compact_view_format indicator
      74ea939f